FrontMenus::register() - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

FrontMenus::register() B
last analyzed 2017-01-20 14:45 UTC

↳ Parent: FrontMenus

Complexity

Conditions	2
Paths	1

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	18
nc	1
nop	0
dl	0
loc	30
rs	8.8571
c	0
b	0
f	0

<?php

namespace App\Services\Navigation\Menu;

use app\Models\Article;
use Spatie\Menu\Laravel\Menu;

class FrontMenus
{
    public function register()
    {
        Menu::macro('front', function () {
            return Menu::new()->setActiveFromRequest(locale());
        });

        Menu::macro('main', function () {
            return Menu::front()
                ->addClass('nav__list')
                ->url('/', 'Home');
        });

        Menu::macro('language', function () {
            return Menu::build(locales(), function (Menu $menu, string $locale) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return $menu->url($locale, strtoupper($locale));
            })->setActiveFromRequest();
        });

        Menu::macro('articleSiblings', function (Article $article) {
            return $article->siblings->reduce(function (Menu $menu, Article $article) {
                return $menu->url($article->url, $article->name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }, Menu::front());
        });

        Menu::macro('article', function ($article) {
            $article = $article instanceof Article ? $article : article($article);

            return $this->url($article->url, $article->name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });
    }
}


1			<?php
2
3			namespace App\Services\Navigation\Menu;
4
5			use app\Models\Article;
6			use Spatie\Menu\Laravel\Menu;
7
8			class FrontMenus
9			{
10			public function register()
11			{
12			Menu::macro('front', function () {
13			return Menu::new()->setActiveFromRequest(locale());
14			});
15
16			Menu::macro('main', function () {
17			return Menu::front()
18			->addClass('nav__list')
19			->url('/', 'Home');
20			});
21
22			Menu::macro('language', function () {
23			return Menu::build(locales(), function (Menu $menu, string $locale) {
			0 ignored issues – show Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report `locales()` is of type `object<Illuminate\Support\Collection>`, but the function expects a `array\|object<Iterator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			return $menu->url($locale, strtoupper($locale));
25			})->setActiveFromRequest();
26			});
27
28			Menu::macro('articleSiblings', function (Article $article) {
29			return $article->siblings->reduce(function (Menu $menu, Article $article) {
30			return $menu->url($article->url, $article->name);
			0 ignored issues – show Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report The property `url` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31			}, Menu::front());
32			});
33
34			Menu::macro('article', function ($article) {
35			$article = $article instanceof Article ? $article : article($article);
36
37			return $this->url($article->url, $article->name);
			0 ignored issues – show Bug introduced 2017-01-06 10:04 UTC by Report Bug Copy Issue Report The method `url()` does not seem to exist on `object<App\Services\Navigation\Menu\FrontMenus>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report The property `url` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			});
39			}
40			}
41

spatie-custom / blender

FrontMenus::register() B last analyzed 2017-01-20 14:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FrontMenus::register() B
last analyzed 2017-01-20 14:45 UTC