HtmlServiceProvider::registerFormBuilder() - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

HtmlServiceProvider::registerFormBuilder() A
last analyzed 2017-01-20 14:45 UTC

↳ Parent: HtmlServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Services\Html;

use Collective\Html\HtmlServiceProvider as ServiceProvider;

class HtmlServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = true;

    /**
     * Register the service provider.
     */
    public function register()
    {
        $this->registerHtmlBuilder();
        $this->registerFormBuilder();
        $this->registerBlenderBuilder();

        $this->app->alias('html', HtmlBuilder::class);
        $this->app->alias('form', FormBuilder::class);
    }

    /**
     * Register the HTML builder instance.
     */
    protected function registerHtmlBuilder()
    {
        $this->app->singleton('html', function ($app) {
            return new HtmlBuilder($app['url'], view());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        });
    }

    /**
     * Register the form builder instance.
     */
    protected function registerFormBuilder()
    {
        $this->app->singleton('form', function ($app) {
            $formBuilder = new FormBuilder($app['html'], $app['url'], view(), $app['session.store']->getToken());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            $formBuilder->setSessionStore($app['session.store']);

            return $formBuilder;
        });
    }

    /**
     * Register the blender builder instance.
     */
    protected function registerBlenderBuilder()
    {
        $this->app->singleton(BlenderFormBuilder::class);
    }
}


1			<?php
2
3			namespace App\Services\Html;
4
5			use Collective\Html\HtmlServiceProvider as ServiceProvider;
6
7			class HtmlServiceProvider extends ServiceProvider
8			{
9			/**
10			* Indicates if loading of the provider is deferred.
11			*
12			* @var bool
13			*/
14			protected $defer = true;
15
16			/**
17			* Register the service provider.
18			*/
19			public function register()
20			{
21			$this->registerHtmlBuilder();
22			$this->registerFormBuilder();
23			$this->registerBlenderBuilder();
24
25			$this->app->alias('html', HtmlBuilder::class);
26			$this->app->alias('form', FormBuilder::class);
27			}
28
29			/**
30			* Register the HTML builder instance.
31			*/
32			protected function registerHtmlBuilder()
33			{
34			$this->app->singleton('html', function ($app) {
35			return new HtmlBuilder($app['url'], view());
			0 ignored issues – show Bug introduced 2016-07-13 10:48 UTC by Report Bug Copy Issue Report It seems like `view()` can also be of type `object<Illuminate\View\View>`; however, `Collective\Html\HtmlBuilder::__construct()` does only seem to accept `object<Illuminate\Contracts\View\Factory>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
36			});
37			}
38
39			/**
40			* Register the form builder instance.
41			*/
42			protected function registerFormBuilder()
43			{
44			$this->app->singleton('form', function ($app) {
45			$formBuilder = new FormBuilder($app['html'], $app['url'], view(), $app['session.store']->getToken());
			0 ignored issues – show Bug introduced 2016-07-13 10:48 UTC by Report Bug Copy Issue Report It seems like `view()` can also be of type `object<Illuminate\View\View>`; however, `Collective\Html\FormBuilder::__construct()` does only seem to accept `object<Illuminate\Contracts\View\Factory>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
46
47			$formBuilder->setSessionStore($app['session.store']);
48
49			return $formBuilder;
50			});
51			}
52
53			/**
54			* Register the blender builder instance.
55			*/
56			protected function registerBlenderBuilder()
57			{
58			$this->app->singleton(BlenderFormBuilder::class);
59			}
60			}
61

spatie-custom / blender

HtmlServiceProvider::registerFormBuilder() A last analyzed 2017-01-20 14:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

HtmlServiceProvider::registerFormBuilder() A
last analyzed 2017-01-20 14:45 UTC