AuthServiceProvider::boot() - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

AuthServiceProvider::boot() A
last analyzed 2017-01-20 14:45 UTC

↳ Parent: AuthServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	4
rs	10

<?php

namespace App\Services\Auth;

use Illuminate\Contracts\Auth\Access\Gate as GateContract;
use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;

class AuthServiceProvider extends ServiceProvider
{
    protected $policies = [];

    public function boot(GateContract $gate)
    {
        parent::registerPolicies($gate);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function register()
    {
        parent::register();

        $this->registerDefaultAuthDriver();
    }

    protected function registerDefaultAuthDriver()
    {
        auth()->shouldUse(request()->section());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace App\Services\Auth;
4
5			use Illuminate\Contracts\Auth\Access\Gate as GateContract;
6			use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;
7
8			class AuthServiceProvider extends ServiceProvider
9			{
10			protected $policies = [];
11
12			public function boot(GateContract $gate)
13			{
14			parent::registerPolicies($gate);
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-16 16:14 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`registerPolicies()` instead of `boot()`). Are you sure this is correct? If so, you might want to change this to `$this->registerPolicies()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Unused Code introduced 2016-08-27 00:12 UTC by Report Bug Copy Issue Report The call to `AuthServiceProvider::registerPolicies()` has too many arguments starting with `$gate`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
15			}
16
17			public function register()
18			{
19			parent::register();
20
21			$this->registerDefaultAuthDriver();
22			}
23
24			protected function registerDefaultAuthDriver()
25			{
26			auth()->shouldUse(request()->section());
			0 ignored issues – show Bug introduced 2016-07-26 13:40 UTC by Report Bug Copy Issue Report The method `shouldUse` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27			}
28			}
29

spatie-custom / blender

AuthServiceProvider::boot() A last analyzed 2017-01-20 14:45 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

AuthServiceProvider::boot() A
last analyzed 2017-01-20 14:45 UTC