ArticleController::index() - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

ArticleController::index() A
last analyzed 2017-01-20 14:45 UTC

↳ Parent: ArticleController

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	1
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Front;

use App\Http\Controllers\Controller;
use App\Repositories\ArticleRepository;

class ArticleController extends Controller
{
    public function index(...$articleSlugs)
    {
        $articleSlug = collect($articleSlugs)->last();

        $article = ArticleRepository::findBySlug($articleSlug);

        if ($article->hasChildren()) {
            return redirect($article->first_child->url);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return view('front.article.index')->with(compact('article'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Front;
4
5			use App\Http\Controllers\Controller;
6			use App\Repositories\ArticleRepository;
7
8			class ArticleController extends Controller
9			{
10			public function index(...$articleSlugs)
11			{
12			$articleSlug = collect($articleSlugs)->last();
13
14			$article = ArticleRepository::findBySlug($articleSlug);
15
16			if ($article->hasChildren()) {
17			return redirect($article->first_child->url);
			0 ignored issues – show Documentation introduced 2017-01-11 09:39 UTC by Report Bug Copy Issue Report The property `first_child` does not exist on `object<App\Models\Article>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
18			}
19
20			return view('front.article.index')->with(compact('article'));
			0 ignored issues – show Bug introduced 2016-07-05 09:39 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21			}
22			}
23

spatie-custom / blender

ArticleController::index() A last analyzed 2017-01-20 14:45 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ArticleController::index() A
last analyzed 2017-01-20 14:45 UTC