FragmentsController::hidden() - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

FragmentsController::hidden() A
last analyzed 2017-01-20 14:45 UTC

↳ Parent: FragmentsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Back;

use App\Models\Fragment;
use Spatie\FragmentImporter\Exporter;
use App\Http\Requests\Back\FragmentRequest;
use Spatie\Blender\Model\Updaters\UpdateMedia;

class FragmentsController
{
    use UpdateMedia;

    public function index()
    {
        $fragments = Fragment::where('hidden', false)->get();

        return view('back.fragments.index')->with(compact('fragments'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function hidden()
    {
        $fragments = Fragment::where('hidden', true)->get();

        return view('back.fragments.index')->with(compact('fragments'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function create()
    {
        $fragment = new Fragment();
        $fragment->save();

        return redirect()->action('Back\FragmentsController@edit', [$fragment->id]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function edit($id)
    {
        $fragment = Fragment::find($id);

        return view('back.fragments.edit')->with(compact('fragment'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function update($id, FragmentRequest $request)
    {
        $fragment = Fragment::find($id);

        foreach (locales() as $locale) {
            $requestAttribute = "translated_{$locale}_text";

            $fragment->setTranslation($locale, $request->get($requestAttribute));
        }

        $fragment->save();
        $this->updateMedia($fragment, $request);
        app('cache')->flush();

        $eventDescription = fragment('back.events.updated', ['model' => 'Fragment', 'name' => $fragment->name]);

        flash()->success(strip_tags($eventDescription));

        return redirect()->action('Back\FragmentsController@index');
    }

    public function download()
    {
        Exporter::sendExportToBrowser();
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Back;
4
5			use App\Models\Fragment;
6			use Spatie\FragmentImporter\Exporter;
7			use App\Http\Requests\Back\FragmentRequest;
8			use Spatie\Blender\Model\Updaters\UpdateMedia;
9
10			class FragmentsController
11			{
12			use UpdateMedia;
13
14			public function index()
15			{
16			$fragments = Fragment::where('hidden', false)->get();
17
18			return view('back.fragments.index')->with(compact('fragments'));
			0 ignored issues – show Bug introduced 2017-01-13 14:22 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
19			}
20
21			public function hidden()
22			{
23			$fragments = Fragment::where('hidden', true)->get();
24
25			return view('back.fragments.index')->with(compact('fragments'));
			0 ignored issues – show Bug introduced 2015-11-23 22:38 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26			}
27
28			public function create()
29			{
30			$fragment = new Fragment();
31			$fragment->save();
32
33			return redirect()->action('Back\FragmentsController@edit', [$fragment->id]);
			0 ignored issues – show Documentation introduced 2015-11-23 22:38 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Models\Fragment>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			}
35
36			public function edit($id)
37			{
38			$fragment = Fragment::find($id);
39
40			return view('back.fragments.edit')->with(compact('fragment'));
			0 ignored issues – show Bug introduced 2015-11-23 22:38 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41			}
42
43			public function update($id, FragmentRequest $request)
44			{
45			$fragment = Fragment::find($id);
46
47			foreach (locales() as $locale) {
48			$requestAttribute = "translated_{$locale}_text";
49
50			$fragment->setTranslation($locale, $request->get($requestAttribute));
51			}
52
53			$fragment->save();
54			$this->updateMedia($fragment, $request);
55			app('cache')->flush();
56
57			$eventDescription = fragment('back.events.updated', ['model' => 'Fragment', 'name' => $fragment->name]);
58
59			flash()->success(strip_tags($eventDescription));
60
61			return redirect()->action('Back\FragmentsController@index');
62			}
63
64			public function download()
65			{
66			Exporter::sendExportToBrowser();
67			}
68			}
69

spatie-custom / blender

FragmentsController::hidden() A last analyzed 2017-01-20 14:45 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

FragmentsController::hidden() A
last analyzed 2017-01-20 14:45 UTC