Person - Code Metrics - spatie-custom/blender - Measure and Improve Code Quality continuously with Scrutinizer

Person A
last analyzed 2017-01-20 14:45 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	4
dl	0
loc	25
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	registerMediaConversions()	0	9	1
A	generateSlug()	0	4	1

<?php

namespace App\Models;

use Spatie\Blender\Model\Model;
use Spatie\EloquentSortable\Sortable;
use Spatie\Blender\Model\Traits\HasSlug;
use Spatie\EloquentSortable\SortableTrait;

class Person extends Model implements Sortable
{
    use HasSlug, SortableTrait;

    protected $with = ['media'];

    public $translatable = ['text'];

    protected $mediaLibraryCollections = ['images'];

    public function registerMediaConversions()
    {
        parent::registerMediaConversions();

        $this->addMediaConversion('thumb')
            ->setWidth(368)
            ->setHeight(232)
            ->performOnCollections('images');
    }

    protected function generateSlug(): string
    {
        return str_slug($this->name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace App\Models;
4
5			use Spatie\Blender\Model\Model;
6			use Spatie\EloquentSortable\Sortable;
7			use Spatie\Blender\Model\Traits\HasSlug;
8			use Spatie\EloquentSortable\SortableTrait;
9
10			class Person extends Model implements Sortable
11			{
12			use HasSlug, SortableTrait;
13
14			protected $with = ['media'];
15
16			public $translatable = ['text'];
17
18			protected $mediaLibraryCollections = ['images'];
19
20			public function registerMediaConversions()
21			{
22			parent::registerMediaConversions();
23
24			$this->addMediaConversion('thumb')
25			->setWidth(368)
26			->setHeight(232)
27			->performOnCollections('images');
28			}
29
30			protected function generateSlug(): string
31			{
32			return str_slug($this->name);
			0 ignored issues – show Documentation introduced 2016-04-12 15:07 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Models\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33			}
34			}
35

spatie-custom / blender

Person A last analyzed 2017-01-20 14:45 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

Person A
last analyzed 2017-01-20 14:45 UTC