App\Exceptions\Handler

Complexity

Total Complexity

12

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	report()	0	8	3
A	render()	0	16	4
A	renderExceptionWithWhoops()	0	13	1
A	unsetSensitiveData()	0	8	2
A	unauthenticated()	0	8	2

<?php

namespace App\Exceptions;

use Exception;
use Illuminate\Http\Response;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Bugsnag\BugsnagLaravel\BugsnagExceptionHandler as BugsnagExceptionHandler;

class Handler extends ExceptionHandler
{
    protected $dontReport = [
        \Illuminate\Auth\AuthenticationException::class,
        \Illuminate\Auth\Access\AuthorizationException::class,
        \Symfony\Component\HttpKernel\Exception\HttpException::class,
        \Illuminate\Database\Eloquent\ModelNotFoundException::class,
        \Illuminate\Validation\ValidationException::class,
    ];

    public function report(Exception $e)
    {
        parent::report($e);

        if (app()->environment('production') && $this->shouldReport($e)) {
            app(BugsnagExceptionHandler::class)->report($e);
        }
    }

    public function render($request, Exception $e)
    {
        if ($this->isHttpException($e)) {
            return $this->renderHttpException($e);

$e of type object<Exception> is not a sub-type of object<Symfony\Component\HttpKernel\Exception\HttpException>. It seems like you assume a child class of the class Exception to be always present.

        }

        if ($this->shouldntReport($e)) {
            return parent::render($request, $e);
        }

        if (config('app.debug')) {
            return $this->renderExceptionWithWhoops($e);
        }

        return parent::render($request, $e);
    }

    protected function renderExceptionWithWhoops(Exception $e): Response
    {
        $this->unsetSensitiveData();

        $whoops = new \Whoops\Run();
        $whoops->pushHandler(new \Whoops\Handler\PrettyPageHandler());

new \Whoops\Handler\PrettyPageHandler() is of type object<Whoops\Handler\PrettyPageHandler>, but the function expects a callable.

        return new \Illuminate\Http\Response(
            $whoops->handleException($e),

$e is of type object<Exception>, but the function expects a object<Throwable>.

            $e->getStatusCode(),

It seems like you code against a specific sub-type and not the parent class Exception as the method getStatusCode() does only exist in the following sub-classes of Exception: Aws\Acm\Exception\AcmException, Aws\ApiGateway\Exception\ApiGatewayException, Aws\ApplicationAutoScaling\Exception\ApplicationAutoScalingException, Aws\ApplicationDiscoveryService\Exception\ApplicationDiscoveryServiceException, Aws\Appstream\Exception\AppstreamException, Aws\AutoScaling\Exception\AutoScalingException, Aws\Batch\Exception\BatchException, Aws\Budgets\Exception\BudgetsException, Aws\CloudFormation\Exception\CloudFormationException, Aws\CloudFront\Exception\CloudFrontException, Aws\CloudHsm\Exception\CloudHsmException, Aws\CloudSearchDomain\Exception\CloudSearchDomainException, Aws\CloudSearch\Exception\CloudSearchException, Aws\CloudTrail\Exception\CloudTrailException, Aws\CloudWatchEvents\Exception\CloudWatchEventsException, Aws\CloudWatchLogs\Exception\CloudWatchLogsException, Aws\CloudWatch\Exception\CloudWatchException, Aws\CodeBuild\Exception\CodeBuildException, Aws\CodeCommit\Exception\CodeCommitException, Aws\CodeDeploy\Exception\CodeDeployException, Aws\CodePipeline\Exception\CodePipelineException, Aws\CognitoIdentityProvider\Exception\CognitoIdentityProviderException, Aws\CognitoIdentity\Exception\CognitoIdentityException, Aws\CognitoSync\Exception\CognitoSyncException, Aws\ConfigService\Exception\ConfigServiceException, Aws\DataPipeline\Exception\DataPipelineException, Aws\DatabaseMigrationService\Exception\DatabaseMigrationServiceException, Aws\DeviceFarm\Exception\DeviceFarmException, Aws\DirectConnect\Exception\DirectConnectException, Aws\DirectoryService\Exception\DirectoryServiceException, Aws\DynamoDbStreams\Exception\DynamoDbStreamsException, Aws\DynamoDb\Exception\DynamoDbException, Aws\Ec2\Exception\Ec2Exception, Aws\Ecr\Exception\EcrException, Aws\Ecs\Exception\EcsException, Aws\Efs\Exception\EfsException, Aws\ElastiCache\Exception\ElastiCacheException, Aws\ElasticBeanstalk\Exception\ElasticBeanstalkException, Aws\ElasticLoadBalancingV2\Exception\ElasticLoadBalancingV2Exception, Aws\ElasticLoadBalancing\Exception\ElasticLoadBalancingException, Aws\ElasticTranscoder\Exception\ElasticTranscoderException, Aws\ElasticsearchService\Exception\ElasticsearchServiceException, Aws\Emr\Exception\EmrException, Aws\Exception\AwsException, Aws\Firehose\Exception\FirehoseException, Aws\GameLift\Exception\GameLiftException, Aws\Glacier\Exception\GlacierException, Aws\Health\Exception\HealthException, Aws\Iam\Exception\IamException, Aws\ImportExport\Exception\ImportExportException, Aws\Inspector\Exception\InspectorException, Aws\IotDataPlane\Exception\IotDataPlaneException, Aws\Iot\Exception\IotException, Aws\KinesisAnalytics\Exception\KinesisAnalyticsException, Aws\Kinesis\Exception\KinesisException, Aws\Kms\Exception\KmsException, Aws\Lambda\Exception\LambdaException, Aws\Lightsail\Exception\LightsailException, Aws\MachineLearning\Exception\MachineLearningException, Aws\MarketplaceCommerceAnalytics\Exception\MarketplaceCommerceAnalyticsException, Aws\MarketplaceMetering\Exception\MarketplaceMeteringException, Aws\OpsWorksCM\Exception\OpsWorksCMException, Aws\OpsWorks\Exception\OpsWorksException, Aws\Pinpoint\Exception\PinpointException, Aws\Polly\Exception\PollyException, Aws\Rds\Exception\RdsException, Aws\Redshift\Exception\RedshiftException, Aws\Rekognition\Exception\RekognitionException, Aws\Route53Domains\Exception\Route53DomainsException, Aws\Route53\Exception\Route53Exception, Aws\S3\Exception\PermanentRedirectException, Aws\S3\Exception\S3Exception, Aws\ServiceCatalog\Exception\ServiceCatalogException, Aws\Ses\Exception\SesException, Aws\Sfn\Exception\SfnException, Aws\Shield\Exception\ShieldException, Aws\Sms\Exception\SmsException, Aws\SnowBall\Exception\SnowBallException, Aws\Sns\Exception\SnsException, Aws\Sqs\Exception\SqsException, Aws\Ssm\Exception\SsmException, Aws\StorageGateway\Exception\StorageGatewayException, Aws\Sts\Exception\StsException, Aws\Support\Exception\SupportException, Aws\Swf\Exception\SwfException, Aws\WafRegional\Exception\WafRegionalException, Aws\Waf\Exception\WafException, Aws\WorkSpaces\Exception\WorkSpacesException, Aws\XRay\Exception\XRayException, Illuminate\Foundation\Http\Exceptions\MaintenanceModeException, Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException, Symfony\Component\HttpKernel\Exception\BadRequestHttpException, Symfony\Component\HttpKernel\Exception\ConflictHttpException, Symfony\Component\HttpKernel\Exception\GoneHttpException, Symfony\Component\HttpKernel\Exception\HttpException, Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException, Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException, Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException, Symfony\Component\HttpKernel\Exception\NotFoundHttpException, Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException, Symfony\Component\HttpKernel\Exception\PreconditionRequiredHttpException, Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException, Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException, Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException, Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException. Maybe you want to instanceof check for one of these explicitly?

            $e->getHeaders()

It seems like you code against a specific sub-type and not the parent class Exception as the method getHeaders() does only exist in the following sub-classes of Exception: Illuminate\Foundation\Http\Exceptions\MaintenanceModeException, Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException, Symfony\Component\HttpKernel\Exception\BadRequestHttpException, Symfony\Component\HttpKernel\Exception\ConflictHttpException, Symfony\Component\HttpKernel\Exception\GoneHttpException, Symfony\Component\HttpKernel\Exception\HttpException, Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException, Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException, Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException, Symfony\Component\HttpKernel\Exception\NotFoundHttpException, Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException, Symfony\Component\HttpKernel\Exception\PreconditionRequiredHttpException, Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException, Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException, Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException, Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException. Maybe you want to instanceof check for one of these explicitly?

        );
    }

    /*
     * Don't ever display sensitive data in Whoops pages.
     */
    protected function unsetSensitiveData()
    {
        foreach ($_ENV as $key => $value) {
            unset($_SERVER[$key]);
        }

        $_ENV = [];
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param \Illuminate\Http\Request                 $request
     * @param \Illuminate\Auth\AuthenticationException $e
     *
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $e)

The parameter $e is not used and could be removed.

    {
        if ($request->expectsJson()) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        return redirect()->guest('login');
    }
}