RowIterator::processEndElement() - Code Metrics - Inspection of "refactor: reduce complexity" - spaghettisolutions/xlsx-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — spaghetti ( d276c8...efb1b1 )

by simpletoimplement

created 2022-12-06 09:55 UTC

RowIterator::processEndElement() A

↳ Parent: RowIterator

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php declare(strict_types = 1);

namespace Spaghetti\XLSXParser;

use Iterator;
use XMLReader;

/**
 * @internal
 */
final class RowIterator implements Iterator
{
    private ?Row $row = null;
    private ?int $currentKey;
    private ?int $index = null;
    private ?string $style = null;
    private ?string $type = null;
    private XMLReader $xml;
    private array $currentValue;
    private bool $valid;
    private readonly Transformer\Column $columnTransformer;

    public function __construct(
        private readonly Transformer\Value $valueTransformer,
        private readonly string $path,
        ?Transformer\Column $columnTransformer = null,
    ) {
        $this->columnTransformer = $columnTransformer ?? new Transformer\Column();

    }

    public function current(): array
    {
        return $this->currentValue;
    }

    public function key(): int
    {
        return $this->currentKey;

    }

    public function next(): void
    {
        $this->valid = false;

        while ($this->xml->read()) {
            $this->processEndElement();

            if ($this->valid) {
                return;
            }

            $this->process();
        }
    }

    public function rewind(): void
    {
        $xml = new XMLReader();

        $this->xml = false === $xml->open(uri: $this->path) ? null : $xml;

        $this->next();
    }

    public function valid(): bool
    {
        return $this->valid;
    }

    private function processEndElement(): void
    {
        if (XMLReader::END_ELEMENT === $this->xml->nodeType) {
            $this->processEndValue();
        }
    }

    private function processEndValue(): void
    {
        if ('row' === $this->xml->name) {
            $currentValue = $this->row->getData();
            $currentValue = $this->row->getData();
            if ([] !== $currentValue) {
                $this->currentValue = $currentValue;
                $this->valid = true;
            }
        }
    }

    private function process(): void
    {
        if (XMLReader::ELEMENT === $this->xml->nodeType) {
            match ($this->xml->name) {
                'row' => $this->processRow(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                'c' => $this->processColumn(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                'v' => $this->processValue(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                default => $this->processDefault(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            };
        }
    }

    private function processRow(): void
    {
        $this->currentKey = (int) $this->xml->getAttribute(name: 'r');
        $this->row = new Row();
    }

    private function processColumn(): void
    {
        $this->index = $this->columnTransformer->transform(name: $this->xml->getAttribute(name: 'r'));
        $this->style = $this->xml->getAttribute(name: 's') ?? '';
        $this->type = $this->xml->getAttribute(name: 't') ?? '';
    }

    private function processValue(): void
    {
        $this->row->addValue(
            columnIndex: $this->index,
            /** @scrutinizer ignore-type */ columnIndex: $this->index,
            value: $this->valueTransformer->transform(value: $this->xml->readString(), type: $this->type, style: $this->style),
            value: $this->valueTransformer->transform(value: $this->xml->readString(), type: $this->type, /** @scrutinizer ignore-type */ style: $this->style),
        );
    }

    private function processDefault(): void
    {
        $this->row?->addValue(columnIndex: $this->index, value: $this->xml->readString());
        $this->row?->addValue(/** @scrutinizer ignore-type */ columnIndex: $this->index, value: $this->xml->readString());
    }
}


spaghettisolutions / xlsx-parser

Push — spaghetti ( d276c8...efb1b1 )

RowIterator::processEndElement() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like