AbstractXMLResource::validateXMLReader() - Code Metrics - Inspection of "refactor: reduce CRAP" - spaghettisolutions/xlsx-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — spaghetti ( fcb196...2528e5 )

by simpletoimplement

created 2022-12-07 16:07 UTC

AbstractXMLResource::validateXMLReader() A

↳ Parent: AbstractXMLResource

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	9
rs	10

<?php declare(strict_types = 1);

namespace Spaghetti\XLSXParser;

use InvalidArgumentException;
use Throwable;
use XMLReader;

use function sprintf;

/**
 * @internal
 */
abstract class AbstractXMLResource
{
    private ?XMLReader $xml = null;

    public function __construct(private readonly string $path)
    {
    }

    public function __destruct()
    {
        $this->closeXMLReader();
    }

    protected function getXMLReader(): XMLReader
    {
        return $this->xml ??= $this->createXMLReader();
    }

    protected function createXMLReader(): XMLReader
    {
        return $this->validateXMLReader(xml: new XMLReader());
    }

    protected function closeXMLReader(): void
    {
        $this->xml?->close();
        $this->xml = null;
    }

    private function validateXMLReader(XMLReader $xml): XMLReader
    {
        try {
            $xml->open(uri: $this->path);
        } catch (Throwable $throwable) {
            throw new InvalidArgumentException(message: sprintf('Not a XLSX file: %s', $this->path), previous: $throwable);
        }

        return $xml;
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Spaghetti\XLSXParser;
4
5			use InvalidArgumentException;
6			use Throwable;
7			use XMLReader;
8
9			use function sprintf;
10
11			/**
12			* @internal
13			*/
14			abstract class AbstractXMLResource
15			{
16			private ?XMLReader $xml = null;
17
18			public function __construct(private readonly string $path)
19			{
20			}
21
22			public function __destruct()
23			{
24			$this->closeXMLReader();
25			}
26
27			protected function getXMLReader(): XMLReader
28			{
29			return $this->xml ??= $this->createXMLReader();
30			}
31
32			protected function createXMLReader(): XMLReader
33			{
34			return $this->validateXMLReader(xml: new XMLReader());
35			}
36
37			protected function closeXMLReader(): void
38			{
39			$this->xml?->close();
40			$this->xml = null;
41			}
42
43			private function validateXMLReader(XMLReader $xml): XMLReader
44			{
45			try {
46			$xml->open(uri: $this->path);
47			} catch (Throwable $throwable) {
48			throw new InvalidArgumentException(message: sprintf('Not a XLSX file: %s', $this->path), previous: $throwable);
49			}
50
51			return $xml;
52			}
53			}
54

spaghettisolutions / xlsx-parser

Push — spaghetti ( fcb196...2528e5 )

AbstractXMLResource::validateXMLReader() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like