Completed
Pull Request — master (#8)
by Emily
02:26
created
src/Service/RawPropertyAccessor.php 1 patch
Spacing   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -48,8 +48,7 @@  discard block
 block discarded – undo
48 48
      */
49 49
     public function setRawValue($key, $value)
50 50
     {
51
-        $this->getPropertyOrFail
52
-        (
51
+        $this->getPropertyOrFail(
53 52
             $key,
54 53
             CannotWritePropertyException::class
55 54
         )
@@ -68,8 +67,7 @@  discard block
 block discarded – undo
68 67
     public function getRawValue($key)
69 68
     {
70 69
         return
71
-            $this->getPropertyOrFail
72
-            (
70
+            $this->getPropertyOrFail(
73 71
                 $key,
74 72
                 CannotReadPropertyException::class
75 73
             )
@@ -86,8 +84,7 @@  discard block
 block discarded – undo
86 84
      */ 
87 85
     public function rawAddToValue($key, $value)
88 86
     {
89
-        $property = $this->getPropertyOrFail
90
-        (
87
+        $property = $this->getPropertyOrFail(
91 88
             $key,
92 89
             CannotWritePropertyException::class
93 90
         );
@@ -113,8 +110,7 @@  discard block
 block discarded – undo
113 110
         }
114 111
         catch (ReflectionException $e)
115 112
         {
116
-            throw new $class
117
-            (
113
+            throw new $class(
118 114
                 get_class($this->object),
119 115
                 $key,
120 116
                 $e
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionFileFactory.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,8 +60,7 @@  discard block
 block discarded – undo
60 60
                     case T_NAMESPACE:
61 61
                         $ns = new NamespaceBlock($classname);
62 62
                         $currentNS = new RawPropertyAccessor($ns);
63
-                        $this->accessor->getRawValue
64
-                        (
63
+                        $this->accessor->getRawValue(
65 64
                             'namespaces'
66 65
                         )
67 66
                         ->add($classname, $ns);
@@ -76,8 +75,7 @@  discard block
 block discarded – undo
76 75
                             $as = end($as);
77 76
                         }
78 77
 
79
-                        $currentNS->getRawValue
80
-                        (
78
+                        $currentNS->getRawValue(
81 79
                             'useStatements'
82 80
                         )
83 81
                         ->add($as, new UseStatement($classname, $as));
Please login to merge, or discard this patch.
src/Traits/PropertyAccessTrait.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         if (!$this->accessor)
31 31
         {
32
-            $this->accessor = new ConditionalPropertyAccessor
33
-            (
32
+            $this->accessor = new ConditionalPropertyAccessor(
34 33
                 $this,
35 34
                 self::getReflectionComposite()
36 35
             );
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionPropertyFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
      * Builds the ReflectionProperty from the provided parameters,
75 75
      * linking to a parent ReflectionComposite
76 76
      *
77
-     * @param ReflectionCompostite $parent The reflector for the class
77
+     * @param ReflectionComposite $parent The reflector for the class
78 78
      *     this property belongs to
79 79
      * @param mixed $default This property's default value
80 80
      * @return ReflectionProperty
Please login to merge, or discard this patch.
Spacing   +12 added lines, -24 removed lines patch added patch discarded remove patch
@@ -53,8 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public static function fromName($class, $property)
55 55
     {
56
-        return new static(new PHPNativeReflectionProperty
57
-        (
56
+        return new static(new PHPNativeReflectionProperty(
58 57
             $class, $property
59 58
         ));
60 59
     }
@@ -72,14 +71,12 @@  discard block
 block discarded – undo
72 71
     {
73 72
         $this->accessor->setRawValue('owner', $parent);
74 73
         $this->accessor->setRawValue('defaultValue', $default);
75
-        $this->accessor->setRawValue
76
-        (
74
+        $this->accessor->setRawValue(
77 75
             'name',
78 76
             $this->reflector->getName()
79 77
         );
80 78
 
81
-        $this->parseDocComment
82
-        ([
79
+        $this->parseDocComment([
83 80
             'readable' => 'setBool',
84 81
             'writable' => 'setBool',
85 82
             'var' => 'setType',
@@ -97,8 +94,7 @@  discard block
 block discarded – undo
97 94
      */
98 95
     protected function setType($name, $value)
99 96
     {
100
-        $this->accessor->setRawValue
101
-        (
97
+        $this->accessor->setRawValue(
102 98
             'type',
103 99
             (new TypeParser($this->object->owner))->parse($value)
104 100
         );
@@ -120,50 +116,42 @@  discard block
 block discarded – undo
120 116
         switch ($value[0])
121 117
         {
122 118
             case 'required':
123
-                $this->accessor->setRawValue
124
-                (
119
+                $this->accessor->setRawValue(
125 120
                     'passedToConstructor',
126 121
                     true
127 122
                 );
128
-                $this->accessor->setRawValue
129
-                (
123
+                $this->accessor->setRawValue(
130 124
                     'requiredInConstructor',
131 125
                     true
132 126
                 );
133
-                $compositeAccessor->rawAddToValue
134
-                (
127
+                $compositeAccessor->rawAddToValue(
135 128
                     'requiredProperties',
136 129
                     $this->object
137 130
                 );
138 131
                 break;
139 132
             case 'new':
140
-                $this->accessor->setRawValue
141
-                (
133
+                $this->accessor->setRawValue(
142 134
                     'builtInConstructor',
143 135
                     true
144 136
                 );
145
-                $compositeAccessor->rawAddToValue
146
-                (
137
+                $compositeAccessor->rawAddToValue(
147 138
                     'builtProperties',
148 139
                     $this->object
149 140
                 );
150 141
                 break;
151 142
             case 'optional':
152
-                $this->accessor->setRawValue
153
-                (
143
+                $this->accessor->setRawValue(
154 144
                     'passedToConstructor',
155 145
                     true
156 146
                 );
157
-                $compositeAccessor->rawAddToValue
158
-                (
147
+                $compositeAccessor->rawAddToValue(
159 148
                     'optionalProperties',
160 149
                     $this->object
161 150
                 );
162 151
 
163 152
                 if (isset($value[1]) && $value[1] === 'new')
164 153
                 {
165
-                    $this->accessor->setRawValue
166
-                    (
154
+                    $this->accessor->setRawValue(
167 155
                         'builtInConstructor',
168 156
                         true
169 157
                     );
Please login to merge, or discard this patch.
src/Exception/PropertyAccessException.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -47,15 +47,13 @@
 block discarded – undo
47 47
      * @param string $property The property accessed
48 48
      * @param Throwable $previous The exception which caused this
49 49
      */
50
-    public function __construct
51
-    (
50
+    public function __construct(
52 51
         string $class,
53 52
         string $property,
54 53
         Throwable $previous = null
55 54
     )
56 55
     {
57
-        parent::__construct
58
-        (
56
+        parent::__construct(
59 57
               'Cannot ' . static::ACCESS_TYPE . ' property: '
60 58
             . $class . '::$' . $property . '. ' . static::ERROR_REASON,
61 59
             0,
Please login to merge, or discard this patch.
src/Exception/MissingRequiredParameterException.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,15 +30,13 @@
 block discarded – undo
30 30
      * @param string $parameter The name of the missing parameter
31 31
      * @param Throwable The exception which caused this
32 32
      */
33
-    public function __construct
34
-    (
33
+    public function __construct(
35 34
         string $class,
36 35
         string $parameter,
37 36
         Throwable $previous = null
38 37
     )
39 38
     {
40
-        parent::__construct
41
-        (
39
+        parent::__construct(
42 40
               'Missing required parameter in constructor. '
43 41
             . $class . ' requires a value for ' . $parameter,
44 42
             0,
Please login to merge, or discard this patch.
src/Exception/IllegalPropertyTypeException.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -32,8 +32,7 @@  discard block
 block discarded – undo
32 32
      * @param string $got The type that was provided
33 33
      * @param Exception $previous The exception which caused this
34 34
      */
35
-    public function __construct
36
-    (
35
+    public function __construct(
37 36
         string $class,
38 37
         string $property,
39 38
         string $expected,
@@ -41,10 +40,9 @@  discard block
 block discarded – undo
41 40
         Exception $previous = null
42 41
     )
43 42
     {
44
-        parent::__construct
45
-        (
43
+        parent::__construct(
46 44
               'Tried to set an illegal property type for '
47
-            . $class .'::$' . $property . '. Excpected ' . $expected
45
+            . $class . '::$' . $property . '. Excpected ' . $expected
48 46
             . ', got ' . $got,
49 47
             0,
50 48
             $previous
Please login to merge, or discard this patch.
src/Service/ConditionalPropertyAccessor.php 1 patch
Spacing   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@  discard block
 block discarded – undo
35 35
         }
36 36
         else
37 37
         {
38
-            throw new PropertyNotWritableException
39
-            (
38
+            throw new PropertyNotWritableException(
40 39
                 get_class($this->object),
41 40
                 $property->name
42 41
             );
@@ -50,16 +49,14 @@  discard block
 block discarded – undo
50 49
     {
51 50
         if (!$this->reflect->properties->containsKey($property))
52 51
         {
53
-            throw new CannotReadPropertyException
54
-            (
52
+            throw new CannotReadPropertyException(
55 53
                 get_class($this->object),
56 54
                 $property
57 55
             );
58 56
         }
59 57
         elseif (!$this->reflect->properties[$property]->readable)
60 58
         {
61
-            throw new PropertyNotReadableException
62
-            (
59
+            throw new PropertyNotReadableException(
63 60
                 get_class($this->object),
64 61
                 $property
65 62
             );
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionCompositeFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
      *
131 131
      * @param string $name
132 132
      * @param bool $checkFile
133
-     * @param string $singular
133
+     * @param string $signular
134 134
      */
135 135
     protected function addItems
136 136
     (
Please login to merge, or discard this patch.
Spacing   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -78,8 +78,7 @@  discard block
 block discarded – undo
78 78
      * @param PHPNativeReflectionClass $reflect
79 79
      * @param ReflectionCompositeProviderInterface $provider
80 80
      */
81
-    public function __construct
82
-    (
81
+    public function __construct(
83 82
         PHPNativeReflectionClass $reflect,
84 83
         ReflectionCompositeProviderInterface $provider
85 84
     )
@@ -112,8 +111,7 @@  discard block
 block discarded – undo
112 111
             $this->addInheritance('interfaces', $interface);
113 112
         }
114 113
 
115
-        $this->parseDocComment
116
-        ([
114
+        $this->parseDocComment([
117 115
             'generic' => 'addGeneric'
118 116
         ]);
119 117
 
@@ -122,13 +120,11 @@  discard block
 block discarded – undo
122 120
         $file = (new ReflectionFileFactory($fileName))->build();
123 121
         $this->accessor->setRawValue('file', $file);
124 122
 
125
-        $this->accessor->setRawValue
126
-        (
123
+        $this->accessor->setRawValue(
127 124
             'classname',
128 125
             $this->reflector->name
129 126
         );
130
-        $this->accessor->setRawValue
131
-        (
127
+        $this->accessor->setRawValue(
132 128
             'namespace',
133 129
             $file->namespaces[$this->reflector->getNamespaceName()]
134 130
         );
@@ -151,8 +147,7 @@  discard block
 block discarded – undo
151 147
             $size = count($this->reflector->{'get' . $name}());
152 148
             foreach ($prefixes as $prefix)
153 149
             {
154
-                $this->accessor->setRawValue
155
-                (
150
+                $this->accessor->setRawValue(
156 151
                     $prefix . $name,
157 152
                     new FixedList($size)
158 153
                 );
@@ -207,8 +202,7 @@  discard block
 block discarded – undo
207 202
      * @param bool $checkFile
208 203
      * @param string $singular
209 204
      */
210
-    protected function addItems
211
-    (
205
+    protected function addItems(
212 206
         string $name,
213 207
         bool $checkFile,
214 208
         string $signular
@@ -239,8 +233,7 @@  discard block
 block discarded – undo
239 233
                     new $factory($item),
240 234
                     $item
241 235
                 );
242
-                $this->accessor->rawAddToValue
243
-                (
236
+                $this->accessor->rawAddToValue(
244 237
                     'local' . ucfirst($name),
245 238
                     $item
246 239
                 );
@@ -257,8 +250,7 @@  discard block
 block discarded – undo
257 250
      * @param PHPNativeReflectionClass $reflect
258 251
      * @param string $method
259 252
      */
260
-    protected function addInheritance
261
-    (
253
+    protected function addInheritance(
262 254
         string $group,
263 255
         PHPNativeReflectionClass $reflect,
264 256
         string $method = 'rawAddToValue'
@@ -283,15 +275,13 @@  discard block
 block discarded – undo
283 275
      * @param ReflectionPropertyFactory $factory
284 276
      * @return ReflectionProperty
285 277
      */
286
-    protected function buildProperty
287
-    (
278
+    protected function buildProperty(
288 279
         ReflectionPropertyFactory $factory,
289 280
         PHPNativeReflectionProperty $reflect
290 281
     )
291 282
     : ReflectionProperty
292 283
     {
293
-        return $factory->build
294
-        (
284
+        return $factory->build(
295 285
             $this->object,
296 286
             $this->reflector
297 287
                 ->getDefaultProperties()[$reflect->getName()]
Please login to merge, or discard this patch.