Completed
Pull Request — master (#3)
by Emily
01:57
created
src/Service/ConditionalPropertyAccessor.php 1 patch
Spacing   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@  discard block
 block discarded – undo
35 35
         }
36 36
         else
37 37
         {
38
-            throw new PropertyNotWritableException
39
-            (
38
+            throw new PropertyNotWritableException(
40 39
                 get_class($this->object),
41 40
                 $property->name
42 41
             );
@@ -50,16 +49,14 @@  discard block
 block discarded – undo
50 49
     {
51 50
         if (!$this->reflect->properties->containsKey($property))
52 51
         {
53
-            throw new CannotReadPropertyException
54
-            (
52
+            throw new CannotReadPropertyException(
55 53
                 get_class($this->object),
56 54
                 $property
57 55
             );
58 56
         }
59 57
         elseif (!$this->reflect->properties[$property]->readable)
60 58
         {
61
-            throw new PropertyNotReadableException
62
-            (
59
+            throw new PropertyNotReadableException(
63 60
                 get_class($this->object),
64 61
                 $property
65 62
             );
Please login to merge, or discard this patch.
src/Service/PropertyAccessor.php 1 patch
Spacing   +11 added lines, -22 removed lines patch added patch discarded remove patch
@@ -65,8 +65,7 @@  discard block
 block discarded – undo
65 65
         {
66 66
             if (!isset($args[$i]))
67 67
             {
68
-                throw new MissingRequiredParameterException
69
-                (
68
+                throw new MissingRequiredParameterException(
70 69
                     get_class($this->object),
71 70
                     $property->name
72 71
                 );
@@ -144,14 +143,12 @@  discard block
 block discarded – undo
144 143
     {
145 144
         if (!$this->reflect->properties->containsKey($property))
146 145
         {
147
-            throw new CannotWritePropertyException
148
-            (
146
+            throw new CannotWritePropertyException(
149 147
                 get_class($this->object), $property
150 148
             );
151 149
         }
152 150
 
153
-        $this->setAnyValue
154
-        (
151
+        $this->setAnyValue(
155 152
             $this->reflect->properties[$property],
156 153
             $value
157 154
         );
@@ -198,8 +195,7 @@  discard block
 block discarded – undo
198 195
      * @param ReflectionProperty $property The property to set
199 196
      * @param mixed $value The value to set
200 197
      */
201
-    private function setNonNullValue
202
-    (
198
+    private function setNonNullValue(
203 199
         ReflectionProperty $property,
204 200
         $value
205 201
     )
@@ -248,8 +244,7 @@  discard block
 block discarded – undo
248 244
      * @param callable $cast Method to cast a value to the scalar data
249 245
      *     type
250 246
      */
251
-    private function setScalarValue
252
-    (
247
+    private function setScalarValue(
253 248
         ReflectionProperty $property,
254 249
         $value,
255 250
         string $name,
@@ -264,8 +259,7 @@  discard block
 block discarded – undo
264 259
         }
265 260
         elseif (is_object($value) && method_exists([$value, $method]))
266 261
         {
267
-            $this->setScalarValue
268
-            (
262
+            $this->setScalarValue(
269 263
                 $property,
270 264
                 $value->$method(),
271 265
                 $method,
@@ -284,8 +278,7 @@  discard block
 block discarded – undo
284 278
      * @param ReflectionProperty $property The property to set
285 279
      * @param mixed $value The value to set
286 280
      */
287
-    private function setObjectValue
288
-    (
281
+    private function setObjectValue(
289 282
         ReflectionProperty $property,
290 283
         $value
291 284
     )
@@ -296,8 +289,7 @@  discard block
 block discarded – undo
296 289
         }
297 290
         else
298 291
         {
299
-            $this->throwError
300
-            (
292
+            $this->throwError(
301 293
                 $property,
302 294
                 $property->type->classname,
303 295
                 $value
@@ -311,8 +303,7 @@  discard block
 block discarded – undo
311 303
      * @param ReflectionProperty $property The property to set
312 304
      * @param mixed The value to set
313 305
      */
314
-    private function setCollectionValue
315
-    (
306
+    private function setCollectionValue(
316 307
         ReflectionProperty $property,
317 308
         $value
318 309
     )
@@ -334,15 +325,13 @@  discard block
 block discarded – undo
334 325
      * @param string $expected The expected datatype
335 326
      * @param string $value The value being set
336 327
      */
337
-    private function throwError
338
-    (
328
+    private function throwError(
339 329
         ReflectionProperty $property,
340 330
         string $expected,
341 331
         $value
342 332
     )
343 333
     {
344
-        throw new IllegalPropertyTypeException
345
-        (
334
+        throw new IllegalPropertyTypeException(
346 335
             get_class($this->object),
347 336
             $property->name,
348 337
             $expected,
Please login to merge, or discard this patch.
src/Model/Collection/ArrayList.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,10 +45,9 @@
 block discarded – undo
45 45
     /**
46 46
      * {@inheritDoc}
47 47
      */
48
-    public function splice
49
-    (
48
+    public function splice(
50 49
         int $offset,
51
-        ?int $length = null,
50
+        ? int $length = null,
52 51
         array $replacement = []
53 52
     )
54 53
     {
Please login to merge, or discard this patch.
src/Model/Collection/ListInterface.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,10 +33,9 @@
 block discarded – undo
33 33
      * @param int $length The number of elements to remove
34 34
      * @param array $items Items to add
35 35
      */
36
-    public function splice
37
-    (
36
+    public function splice(
38 37
         int $offset,
39
-        ?int$length = null,
38
+        ? int$length = null,
40 39
         array $items = []
41 40
     );
42 41
 
Please login to merge, or discard this patch.
src/Model/Collection/HashMap.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@  discard block
 block discarded – undo
41 41
         return static::$defaultHashProducer;
42 42
     }
43 43
 
44
-    public static function setDefaultHashProducer
45
-    (
44
+    public static function setDefaultHashProducer(
46 45
         HashProducerInterface $hashProducer
47 46
     )
48 47
     : HashProducerInterface
@@ -60,9 +59,8 @@  discard block
 block discarded – undo
60 59
      */
61 60
     protected $hashProducer;
62 61
 
63
-    public function __construct
64
-    (
65
-        ?HashProducerInterface $hashProducer = null
62
+    public function __construct(
63
+        ? HashProducerInterface $hashProducer = null
66 64
     )
67 65
     {
68 66
         $this->hashProducer =
Please login to merge, or discard this patch.
src/Model/Collection/FixedList.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,10 +45,9 @@
 block discarded – undo
45 45
     /**
46 46
      * {@inheritDoc}
47 47
      */
48
-    public function splice
49
-    (
48
+    public function splice(
50 49
         int $offset,
51
-        ?int $length = null,
50
+        ? int $length = null,
52 51
         array $replacement = []
53 52
     )
54 53
     {
Please login to merge, or discard this patch.
src/Service/ReflectionCompositeProvider.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -39,8 +39,7 @@  discard block
 block discarded – undo
39 39
         return static::$default;
40 40
     }
41 41
 
42
-    public static function setDefault
43
-    (
42
+    public static function setDefault(
44 43
         ReflectionCompositeProviderInterface $default
45 44
     )
46 45
     {
@@ -60,8 +59,7 @@  discard block
 block discarded – undo
60 59
         {
61 60
             $this->cache[$classname] =
62 61
                 (
63
-                    ReflectionCompositeFactory::fromClassName
64
-                    (
62
+                    ReflectionCompositeFactory::fromClassName(
65 63
                         $classname
66 64
                     )
67 65
                 )
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionCompositeFactory.php 1 patch
Spacing   +9 added lines, -18 removed lines patch added patch discarded remove patch
@@ -71,8 +71,7 @@  discard block
 block discarded – undo
71 71
      * @param PHPNativeReflectionClass $reflect
72 72
      * @param ReflectionCompositeProviderInterface $provider
73 73
      */
74
-    public function __construct
75
-    (
74
+    public function __construct(
76 75
         PHPNativeReflectionClass $reflect,
77 76
         ReflectionCompositeProviderInterface $provider
78 77
     )
@@ -110,13 +109,11 @@  discard block
 block discarded – undo
110 109
         $file = (new ReflectionFileFactory($fileName))->build();
111 110
         $this->accessor->setRawValue('file', $file);
112 111
 
113
-        $this->accessor->setRawValue
114
-        (
112
+        $this->accessor->setRawValue(
115 113
             'classname',
116 114
             $this->reflector->name
117 115
         );
118
-        $this->accessor->setRawValue
119
-        (
116
+        $this->accessor->setRawValue(
120 117
             'namespace',
121 118
             $file->namespaces[$this->reflector->getNamespaceName()]
122 119
         );
@@ -148,8 +145,7 @@  discard block
 block discarded – undo
148 145
 
149 146
     protected function initFixedList(string $name, string $prefix = '')
150 147
     {
151
-        $this->accessor->setRawValue
152
-        (
148
+        $this->accessor->setRawValue(
153 149
             $prefix . $name,
154 150
             new FixedList(count($this->reflector->{'get' . $name}()))
155 151
         );
@@ -163,8 +159,7 @@  discard block
 block discarded – undo
163 159
      * @param bool $checkFile
164 160
      * @param string $singular
165 161
      */
166
-    protected function addItems
167
-    (
162
+    protected function addItems(
168 163
         string $name,
169 164
         bool $checkFile,
170 165
         string $signular
@@ -195,8 +190,7 @@  discard block
 block discarded – undo
195 190
                     new $factory($item),
196 191
                     $item
197 192
                 );
198
-                $this->accessor->rawAddToValue
199
-                (
193
+                $this->accessor->rawAddToValue(
200 194
                     'local' . ucfirst($name),
201 195
                     $item
202 196
                 );
@@ -213,8 +207,7 @@  discard block
 block discarded – undo
213 207
      * @param PHPNativeReflectionClass $reflect
214 208
      * @param string $method
215 209
      */
216
-    protected function addInheritance
217
-    (
210
+    protected function addInheritance(
218 211
         string $group,
219 212
         PHPNativeReflectionClass $reflect,
220 213
         string $method = 'rawAddToValue'
@@ -234,15 +227,13 @@  discard block
 block discarded – undo
234 227
      * @param ReflectionPropertyFactory $factory
235 228
      * @return ReflectionProperty
236 229
      */
237
-    protected function buildProperty
238
-    (
230
+    protected function buildProperty(
239 231
         ReflectionPropertyFactory $factory,
240 232
         PHPNativeReflectionProperty $reflect
241 233
     )
242 234
     : ReflectionProperty
243 235
     {
244
-        return $factory->build
245
-        (
236
+        return $factory->build(
246 237
             $this->object,
247 238
             $this->reflector
248 239
                 ->getDefaultProperties()[$reflect->getName()]
Please login to merge, or discard this patch.