spaark / composite-utils

src/Service/GenericNameProvider.php

Braces +1 added lines, -2 removed lines

@@ -68,8 +68,7 @@
         if ($reflect->generics->empty())
         {
             return $reflect->classname;
-        }
-        else
+        } else
         {
             $items = [];
             foreach ($reflect->generics as $generic)

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
      * Infers the serialized name of the given ObjectType
      *
      * @param ObjectType $reflect
-     * @return string
+     * @return ClassName
      */
     protected function inferObjectName(ObjectType $reflect)
     {

Indentation +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 
             return new ClassName
             (
-                  self::BASE . $reflect->classname
+                    self::BASE . $reflect->classname
                 . '_g' . implode('_c', $items) . '_e'
             );
         }

Unused Use Statements -2 removed lines

@@ -20,10 +20,8 @@
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
 use Spaark\CompositeUtils\Model\Reflection\Type\GenericType;
-use Spaark\CompositeUtils\Model\Generic\GenericContext;
 use Spaark\CompositeUtils\Exception\MissingContextException;
 use Spaark\CompositeUtils\Traits\HasGenericContextTrait;
 use Spaark\CompositeUtils\Model\ClassName;

Spacing +2 added lines, -4 removed lines

@@ -63,8 +63,7 @@ 
                 return $this->inferGenericName($reflect);
         }
 
-        throw new \DomainException
-        (
+        throw new \DomainException(
             'Unknown type: ' . get_class($reflect)
         );
     }
@@ -101,8 +100,7 @@ 
                 $items[] = $this->inferName($generic);
             }
 
-            return new ClassName
-            (
+            return new ClassName(
                   self::BASE . $reflect->classname
                 . '_g' . implode('_c', $items) . '_e'
             );

src/Factory/Reflection/TypeParser.php

Braces +5 added lines, -10 removed lines

@@ -113,8 +113,7 @@ 
                     if ($stack->isEmpty())
                     {
                         return $item;
-                    }
-                    else
+                    } else
                     {
                         $stack->top()->generics[] = $item;
                     }
@@ -141,12 +140,10 @@ 
         if ($i + 1 === strlen($value))
         {
             throw new \Exception('Unexpected EOF');
-        }
-        elseif ($value{$i + 1} !== ']')
+        } elseif ($value{$i + 1} !== ']')
         {
             throw new \Exception('[ must be followed by ]');
-        }
-        elseif ($i + 2 !== strlen($value))
+        } elseif ($i + 2 !== strlen($value))
         {
             if (!in_array($value{$i + 2}, ['>',',']))
             {
@@ -245,12 +242,10 @@ 
         if ($useStatements->containsKey($this->currentValue))
         {
             return $useStatements[$this->currentValue]->classname;
-        }
-        elseif ($generics->containsKey($this->currentValue))
+        } elseif ($generics->containsKey($this->currentValue))
         {
             return new GenericType($this->currentValue);
-        }
-        else
+        } else
         {
             return $this->context->namespace->namespace
                 . '\\' . $this->currentValue;

Doc Comments +3 added lines

@@ -225,6 +225,9 @@
             : new ObjectType($context);
     }
 
+    /**
+     * @param string $var
+     */
     public function scalarToType($var) : ?AbstractType
     {
         switch (strtolower($var))

Spacing +4 added lines, -5 removed lines

@@ -89,8 +89,7 @@ 
      */
     public function parseObjectName($var) : ObjectType
     {
-        return $this->parse(str_replace
-        (
+        return $this->parse(str_replace(
             [GenericNameProvider::BASE, '_g', '_e', '_c'],
             ['', '<', '>', ','],
             get_class($var)
@@ -135,7 +134,7 @@ 
                     $item = $stack->pop();
                     if ($value{$i - 1} !== '>')
                     {
-                        $item->generics[] =$this->resolveName();
+                        $item->generics[] = $this->resolveName();
                     }
 
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -183,7 +182,7 @@ 
         }
         elseif ($i + 2 !== strlen($value))
         {
-            if (!in_array($value{$i + 2}, ['>',',']))
+            if (!in_array($value{$i + 2}, ['>', ',']))
             {
                 throw new \Exception('Unexpected char after collection');
             }
@@ -226,7 +225,7 @@ 
             : new ObjectType($context);
     }
 
-    public function scalarToType($var) : ?AbstractType
+    public function scalarToType($var) : ? AbstractType
     {
         switch (strtolower($var))
         {

src/Traits/HasReflectorTrait.php

Spacing +2 added lines, -4 removed lines

@@ -41,8 +41,7 @@ 
         if (!static::$reflectionComposite)
         {
             static::$reflectionComposite =
-                ReflectionCompositeFactory::fromClassName
-                (
+                ReflectionCompositeFactory::fromClassName(
                     get_called_class()
                 )
                 ->build();
@@ -54,8 +53,7 @@ 
     /**
      * Set the default ReflectionComposite for this class
      */
-    protected static function setDefaultReflectionComposite
-    (
+    protected static function setDefaultReflectionComposite(
         ReflectionComposite $defaultReflectionComposite
     )
     {

src/Model/Common/Equatable.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * Checks if the given class is equal to this one
      *
-     * @param Type $oject
+     * @param Type $object
      * @return boolean
      */
     public function equals($object) : bool;

src/Exception/MissingContextException.php

Indentation +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     {
         parent::__construct
         (
-              'Cannot serialize object containing generics without '
+                'Cannot serialize object containing generics without '
             . 'context',
             0,
             $previous

Spacing +2 added lines, -4 removed lines

@@ -28,13 +28,11 @@
      *
      * @param Throwable $previous The exception which caused this
      */
-    public function __construct
-    (
+    public function __construct(
         Throwable $previous = null
     )
     {
-        parent::__construct
-        (
+        parent::__construct(
               'Cannot serialize object containing generics without '
             . 'context',
             0,

src/Service/ReflectionCompositeProvider.php

Spacing +2 added lines, -4 removed lines

@@ -54,8 +54,7 @@ 
      *
      * @param ReflectionCompositeProviderInterface $default
      */
-    public static function setDefault
-    (
+    public static function setDefault(
         ReflectionCompositeProviderInterface $default
     )
     {
@@ -90,8 +89,7 @@ 
         {
             $this->cache[$classname] =
                 (
-                    ReflectionCompositeFactory::fromClassName
-                    (
+                    ReflectionCompositeFactory::fromClassName(
                         $classname
                     )
                 )

src/Model/Reflection/Type/ObjectType.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     /**
      * Creates this ObjectType with the given classname
      *
-     * @param mixed $class The name of the class this must be an
+     * @param string $classname The name of the class this must be an
      *     instance of
      */
     public function __construct($classname)

Spacing +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
      */
     public function equals($type) : bool
     {
-        if
-        (
+        if (
             $type instanceof ObjectType &&
             $type->classname->equals($this->classname) &&
             $type->generics->size() === $this->generics->size()

src/Model/ClassName.php

Braces +1 added lines, -2 removed lines

@@ -46,8 +46,7 @@
         if (!$matches)
         {
             $this->classname = $classname;
-        }
-        else
+        } else
         {
             $this->classname = $matches[2];
             $this->namespace = $matches[1];

Indentation +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     public function __toString()
     {
         return
-              ($this->namespace ? $this->namespace . '\\' : '')
+                ($this->namespace ? $this->namespace . '\\' : '')
             . $this->classname;
     }
 

src/Service/PropertyAccessor.php

Unused Use Statements -5 removed lines

@@ -17,11 +17,6 @@
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
 use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
-use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
-use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
-use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\ScalarType;
 use Spaark\CompositeUtils\Model\Reflection\Type\AbstractType;
 use Spaark\CompositeUtils\Exception\CannotWritePropertyException;

Spacing +8 added lines, -16 removed lines

@@ -69,8 +69,7 @@ 
         {
             if (!isset($args[$i]))
             {
-                throw new MissingRequiredParameterException
-                (
+                throw new MissingRequiredParameterException(
                     get_class($this->object),
                     $property->name
                 );
@@ -148,14 +147,12 @@ 
     {
         if (!$this->reflect->properties->containsKey($property))
         {
-            throw new CannotWritePropertyException
-            (
+            throw new CannotWritePropertyException(
                 get_class($this->object), $property
             );
         }
 
-        $this->setAnyValue
-        (
+        $this->setAnyValue(
             $this->reflect->properties[$property],
             $value
         );
@@ -193,8 +190,7 @@ 
      * @param ScalarType $valueType The scalar type
      * @param mixed $value The value to set
      */
-    private function setScalarValue
-    (
+    private function setScalarValue(
         ReflectionProperty $property,
         ScalarType $valueType,
         $value
@@ -204,16 +200,14 @@ 
 
         if (is_scalar($value))
         {
-            $this->setRawValue
-            (
+            $this->setRawValue(
                 $property->name,
                 $property->type->cast($value)
             );
         }
         elseif (is_object($value) && method_exists([$value, $method]))
         {
-            $this->setScalarValue
-            (
+            $this->setScalarValue(
                 $property,
                 $valueType,
                 $value->$method()
@@ -231,14 +225,12 @@ 
      * @param ReflectionProperty $property The property being set
      * @param AbstractType $valueType The value being set
      */
-    private function throwError
-    (
+    private function throwError(
         ReflectionProperty $property,
         AbstractType $valueType
     )
     {
-        throw new IllegalPropertyTypeException
-        (
+        throw new IllegalPropertyTypeException(
             get_class($this->object),
             $property->name,
             $property->type,

Braces +8 added lines, -16 removed lines

@@ -88,15 +88,13 @@ 
             if ($building)
             {
                 $this->buildProperty($property);
-            }
-            else
+            } else
             {
                 if (isset($args[$i]))
                 {
                     $this->setAnyValue($property, $args[$i]);
                     $i++;
-                }
-                else
+                } else
                 {
                     $building = true;
                     $this->buildProperty($property);
@@ -120,8 +118,7 @@ 
         if (!$property->type instanceof ObjectType)
         {
             $this->setAnyValue($property, 0);
-        }
-        elseif ($property->builtInConstructor)
+        } elseif ($property->builtInConstructor)
         {
             $class = (string)$property->type->classname;
             $this->setRawValue($property->name, new $class());
@@ -175,8 +172,7 @@ 
         if ($value instanceof Generic)
         {
             $valueType = $value->getObjectType();
-        }
-        else
+        } else
         {
             $valueType = (new TypeParser())->parseFromType($value);
         }
@@ -184,12 +180,10 @@ 
         if ($comparator->compatible($property->type, $valueType))
         {
             $this->setRawValue($property->name, $value);
-        }
-        elseif ($property->type instanceof ScalarType)
+        } elseif ($property->type instanceof ScalarType)
         {
             $this->setScalarValue($property, $valueType, $value);
-        }
-        else
+        } else
         {
             $this->throwError($property, $valueType);
         }
@@ -218,8 +212,7 @@ 
                 $property->name,
                 $property->type->cast($value)
             );
-        }
-        elseif (is_object($value) && method_exists([$value, $method]))
+        } elseif (is_object($value) && method_exists([$value, $method]))
         {
             $this->setScalarValue
             (
@@ -227,8 +220,7 @@ 
                 $valueType,
                 $value->$method()
             );
-        }
-        else
+        } else
         {
             $this->throwError($property, $valueType);
         }