GenericTrait - Code Metrics - Inspection of "Feature/generics" - spaark/composite-utils - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Emily

created 2017-03-23 20:02 UTC

GenericTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

22.73%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	3
dl	0
loc	86
c	0
b	0
f	0
ccs	5
cts	22
cp	0.2273
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getObjectType()	10	2
A	getGenericContext()	13	2
A	setGenericContext()	15	2
A	getInstanceOfGeneric()	7	1

<?php
/**
 * This file is part of the Composite Utils package.
 *
 * (c) Emily Shepherd <[email protected]>
 *
 * For the full copyright and license information, please view the
 * LICENSE.md file that was distributed with this source code.
 *
 * @package spaark/composite-utils
 * @author Emily Shepherd <[email protected]>
 * @license MIT
 */

namespace Spaark\CompositeUtils\Traits;

use Spaark\CompositeUtils\Factory\Reflection\TypeParser;
use Spaark\CompositeUtils\Model\Generic\GenericContext;
use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;

/**
 * Classes using this trait can have generic properties
 *
 * All generated generics will automatically use this Generic, but you
 * may also use this in the root class itself as it provides helpers
 * for creating generic instances
 */
trait GenericTrait
{
    use HasReflectorTrait;

    /**
     * @var GenericContext
     */
    protected $genericContext;

    /**
     * @var ObjectType
     */
    protected $objectType;

    /**
     * Gets the object descriptor for this class
     *
     * @return ObjectType
     */
    public function getObjectType() : ObjectType
    {
        if (!$this->objectType)
        {
            $this->objectType =
                (new TypeParser())->parseFromType($this);
        }

        return $this->objectType;
    }

    /**
     * Gets the generic context for this class or creates one if it does
     * not exist
     *
     * @return GenericContext
     */
    public function getGenericContext() : GenericContext
    {
        if (!$this->genericContext)
        {
            $this->genericContext = new GenericContext
            (
                $this->getObjectType(),
                static::getReflectionComposite()
            );
        }

        return $this->genericContext;
    }

    /**
     * Sets the generic context for this class if one does not already
     * exist
     *
     * @param GenericContext $genericContext
     */
    public function setGenericContext(GenericContext $genericContext)
        : void
    {
        if ($this->genericContext)
        {
            throw new ImmutablePropertyException
            (
                (string)$this->getObjectType(),
                'genericContext'
            );
        }

        $this->genericContext = $genericContext;
        $this->objectType = $genericContext->object;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Gets an instance of a generic
     *
     * @param string $name
     * @return mixed
     */
    protected function getInstanceOfGeneric(string $name)
    {
        $class =
            (string)$this->getGenericContext()->getGenericType($name);

        return new $class();
    }
}


1		<?php
2		/**
3		* This file is part of the Composite Utils package.
4		*
5		* (c) Emily Shepherd <[email protected]>
6		*
7		* For the full copyright and license information, please view the
8		* LICENSE.md file that was distributed with this source code.
9		*
10		* @package spaark/composite-utils
11		* @author Emily Shepherd <[email protected]>
12		* @license MIT
13		*/
14
15		namespace Spaark\CompositeUtils\Traits;
16
17		use Spaark\CompositeUtils\Factory\Reflection\TypeParser;
18		use Spaark\CompositeUtils\Model\Generic\GenericContext;
19		use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
20
21		/**
22		* Classes using this trait can have generic properties
23		*
24		* All generated generics will automatically use this Generic, but you
25		* may also use this in the root class itself as it provides helpers
26		* for creating generic instances
27		*/
28		trait GenericTrait
29		{
30		use HasReflectorTrait;
31
32		/**
33		* @var GenericContext
34		*/
35		protected $genericContext;
36
37		/**
38		* @var ObjectType
39		*/
40		protected $objectType;
41
42		/**
43		* Gets the object descriptor for this class
44		*
45		* @return ObjectType
46		*/
47	2	public function getObjectType() : ObjectType
48		{
49	2	if (!$this->objectType)
50		{
51	2	$this->objectType =
52	2	(new TypeParser())->parseFromType($this);
53		}
54
55	2	return $this->objectType;
56		}
57
58		/**
59		* Gets the generic context for this class or creates one if it does
60		* not exist
61		*
62		* @return GenericContext
63		*/
64		public function getGenericContext() : GenericContext
65		{
66		if (!$this->genericContext)
67		{
68		$this->genericContext = new GenericContext
69		(
70		$this->getObjectType(),
71		static::getReflectionComposite()
72		);
73		}
74
75		return $this->genericContext;
76		}
77
78		/**
79		* Sets the generic context for this class if one does not already
80		* exist
81		*
82		* @param GenericContext $genericContext
83		*/
84		public function setGenericContext(GenericContext $genericContext)
85		: void
86		{
87		if ($this->genericContext)
88		{
89		throw new ImmutablePropertyException
90		(
91		(string)$this->getObjectType(),
92		'genericContext'
93		);
94		}
95
96		$this->genericContext = $genericContext;
97		$this->objectType = $genericContext->object;
		0 ignored issues – show Documentation introduced 2017-03-23 20:04 UTC by Report Bug Copy Issue Report The property `$object` is declared protected in `Spaark\CompositeUtils\Model\Generic\GenericContext`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
98		}
99
100		/**
101		* Gets an instance of a generic
102		*
103		* @param string $name
104		* @return mixed
105		*/
106		protected function getInstanceOfGeneric(string $name)
107		{
108		$class =
109		(string)$this->getGenericContext()->getGenericType($name);
110
111		return new $class();
112		}
113		}
114

spaark / composite-utils

Pull Request — master (#8)

GenericTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like