Completed
Push — master ( c39dfb...499778 )
by Emily
02:18
created
src/Service/PropertyAccessor.php 2 patches
Spacing   +11 added lines, -22 removed lines patch added patch discarded remove patch
@@ -65,8 +65,7 @@  discard block
 block discarded – undo
65 65
         {
66 66
             if (!isset($args[$i]))
67 67
             {
68
-                throw new MissingRequiredParameterException
69
-                (
68
+                throw new MissingRequiredParameterException(
70 69
                     get_class($this->object),
71 70
                     $property->name
72 71
                 );
@@ -144,14 +143,12 @@  discard block
 block discarded – undo
144 143
     {
145 144
         if (!$this->reflect->properties->containsKey($property))
146 145
         {
147
-            throw new CannotWritePropertyException
148
-            (
146
+            throw new CannotWritePropertyException(
149 147
                 get_class($this->object), $property
150 148
             );
151 149
         }
152 150
 
153
-        $this->setAnyValue
154
-        (
151
+        $this->setAnyValue(
155 152
             $this->reflect->properties[$property],
156 153
             $value
157 154
         );
@@ -198,8 +195,7 @@  discard block
 block discarded – undo
198 195
      * @param ReflectionProperty $property The property to set
199 196
      * @param mixed $value The value to set
200 197
      */
201
-    private function setNonNullValue
202
-    (
198
+    private function setNonNullValue(
203 199
         ReflectionProperty $property,
204 200
         $value
205 201
     )
@@ -248,8 +244,7 @@  discard block
 block discarded – undo
248 244
      * @param callable $cast Method to cast a value to the scalar data
249 245
      *     type
250 246
      */
251
-    private function setScalarValue
252
-    (
247
+    private function setScalarValue(
253 248
         ReflectionProperty $property,
254 249
         $value,
255 250
         string $name,
@@ -264,8 +259,7 @@  discard block
 block discarded – undo
264 259
         }
265 260
         elseif (is_object($value) && method_exists([$value, $method]))
266 261
         {
267
-            $this->setScalarValue
268
-            (
262
+            $this->setScalarValue(
269 263
                 $property,
270 264
                 $value->$method(),
271 265
                 $method,
@@ -284,8 +278,7 @@  discard block
 block discarded – undo
284 278
      * @param ReflectionProperty $property The property to set
285 279
      * @param mixed $value The value to set
286 280
      */
287
-    private function setObjectValue
288
-    (
281
+    private function setObjectValue(
289 282
         ReflectionProperty $property,
290 283
         $value
291 284
     )
@@ -296,8 +289,7 @@  discard block
 block discarded – undo
296 289
         }
297 290
         else
298 291
         {
299
-            $this->throwError
300
-            (
292
+            $this->throwError(
301 293
                 $property,
302 294
                 $property->type->classname,
303 295
                 $value
@@ -311,8 +303,7 @@  discard block
 block discarded – undo
311 303
      * @param ReflectionProperty $property The property to set
312 304
      * @param mixed The value to set
313 305
      */
314
-    private function setCollectionValue
315
-    (
306
+    private function setCollectionValue(
316 307
         ReflectionProperty $property,
317 308
         $value
318 309
     )
@@ -334,15 +325,13 @@  discard block
 block discarded – undo
334 325
      * @param string $expected The expected datatype
335 326
      * @param string $value The value being set
336 327
      */
337
-    private function throwError
338
-    (
328
+    private function throwError(
339 329
         ReflectionProperty $property,
340 330
         string $expected,
341 331
         $value
342 332
     )
343 333
     {
344
-        throw new IllegalPropertyTypeException
345
-        (
334
+        throw new IllegalPropertyTypeException(
346 335
             get_class($this->object),
347 336
             $property->name,
348 337
             $expected,
Please login to merge, or discard this patch.
Braces   +9 added lines, -18 removed lines patch added patch discarded remove patch
@@ -83,15 +83,13 @@  discard block
 block discarded – undo
83 83
             if ($building)
84 84
             {
85 85
                 $this->buildProperty($property);
86
-            }
87
-            else
86
+            } else
88 87
             {
89 88
                 if (isset($args[$i]))
90 89
                 {
91 90
                     $this->setAnyValue($property, $args[$i]);
92 91
                     $i++;
93
-                }
94
-                else
92
+                } else
95 93
                 {
96 94
                     $building = true;
97 95
                     $this->buildProperty($property);
@@ -115,8 +113,7 @@  discard block
 block discarded – undo
115 113
         if (!$property->type instanceof ObjectType)
116 114
         {
117 115
             $this->setAnyValue($property, 0);
118
-        }
119
-        elseif ($property->builtInConstructor)
116
+        } elseif ($property->builtInConstructor)
120 117
         {
121 118
             $class = (string)$property->type->classname;
122 119
             $this->setRawValue($property->name, new $class());
@@ -168,8 +165,7 @@  discard block
 block discarded – undo
168 165
         if (is_null($value))
169 166
         {
170 167
             $this->setNullValue($property);
171
-        }
172
-        else
168
+        } else
173 169
         {
174 170
             $this->setNonNullValue($property, $value);
175 171
         }
@@ -185,8 +181,7 @@  discard block
 block discarded – undo
185 181
         if ($property->type->nullable)
186 182
         {
187 183
             $this->setRawValue($property->name, null);
188
-        }
189
-        else
184
+        } else
190 185
         {
191 186
             $this->throwError($property, 'NonNull', null);
192 187
         }
@@ -261,8 +256,7 @@  discard block
 block discarded – undo
261 256
         if (is_scalar($value))
262 257
         {
263 258
             $this->setRawValue($property->name, $cast($value));
264
-        }
265
-        elseif (is_object($value) && method_exists([$value, $method]))
259
+        } elseif (is_object($value) && method_exists([$value, $method]))
266 260
         {
267 261
             $this->setScalarValue
268 262
             (
@@ -271,8 +265,7 @@  discard block
 block discarded – undo
271 265
                 $method,
272 266
                 $cast
273 267
             );
274
-        }
275
-        else
268
+        } else
276 269
         {
277 270
             $this->throwError($property, $name, $value);
278 271
         }
@@ -293,8 +286,7 @@  discard block
 block discarded – undo
293 286
         if (is_a($value, $property->type->classname))
294 287
         {
295 288
             $this->setRawValue($property->name, $value);
296
-        }
297
-        else
289
+        } else
298 290
         {
299 291
             $this->throwError
300 292
             (
@@ -320,8 +312,7 @@  discard block
 block discarded – undo
320 312
         if (is_a($value, \ArrayAccess::class) || is_array($value))
321 313
         {
322 314
             $this->setRawValue($property->name, $value);
323
-        }
324
-        else
315
+        } else
325 316
         {
326 317
             $this->throwError($property, 'Collection', $value);
327 318
         }
Please login to merge, or discard this patch.
src/Model/Collection/ArrayList.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,10 +45,9 @@
 block discarded – undo
45 45
     /**
46 46
      * {@inheritDoc}
47 47
      */
48
-    public function splice
49
-    (
48
+    public function splice(
50 49
         int $offset,
51
-        ?int $length = null,
50
+        ? int $length = null,
52 51
         array $replacement = []
53 52
     )
54 53
     {
Please login to merge, or discard this patch.
src/Model/Collection/ListInterface.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,10 +33,9 @@
 block discarded – undo
33 33
      * @param int $length The number of elements to remove
34 34
      * @param array $items Items to add
35 35
      */
36
-    public function splice
37
-    (
36
+    public function splice(
38 37
         int $offset,
39
-        ?int$length = null,
38
+        ? int$length = null,
40 39
         array $items = []
41 40
     );
42 41
 
Please login to merge, or discard this patch.
src/Model/Collection/HashMap.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@  discard block
 block discarded – undo
41 41
         return static::$defaultHashProducer;
42 42
     }
43 43
 
44
-    public static function setDefaultHashProducer
45
-    (
44
+    public static function setDefaultHashProducer(
46 45
         HashProducerInterface $hashProducer
47 46
     )
48 47
     : HashProducerInterface
@@ -60,9 +59,8 @@  discard block
 block discarded – undo
60 59
      */
61 60
     protected $hashProducer;
62 61
 
63
-    public function __construct
64
-    (
65
-        ?HashProducerInterface $hashProducer = null
62
+    public function __construct(
63
+        ? HashProducerInterface $hashProducer = null
66 64
     )
67 65
     {
68 66
         $this->hashProducer =
Please login to merge, or discard this patch.
src/Model/Collection/FixedList.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,10 +45,9 @@
 block discarded – undo
45 45
     /**
46 46
      * {@inheritDoc}
47 47
      */
48
-    public function splice
49
-    (
48
+    public function splice(
50 49
         int $offset,
51
-        ?int $length = null,
50
+        ? int $length = null,
52 51
         array $replacement = []
53 52
     )
54 53
     {
Please login to merge, or discard this patch.
src/Model/Collection/AbstractList.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,7 @@
 block discarded – undo
29 29
         if ($offset === null)
30 30
         {
31 31
             $this->add($value);
32
-        }
33
-        else
32
+        } else
34 33
         {
35 34
             $this->set($offset, $value);
36 35
         }
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionCompositeFactory.php 5 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
      *
131 131
      * @param string $name
132 132
      * @param bool $checkFile
133
-     * @param string $singular
133
+     * @param string $signular
134 134
      */
135 135
     protected function addItems
136 136
     (
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 
15 15
 namespace Spaark\CompositeUtils\Factory\Reflection;
16 16
 
17
-use Spaark\CompositeUtils\Factory\BaseFactory;
18 17
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
19 18
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
20 19
 use Spaark\CompositeUtils\Model\Reflection\ReflectionMethod;
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
             else
158 158
             {
159 159
                 $factory =
160
-                      '\Spaark\CompositeUtils\Factory\Reflection'
160
+                        '\Spaark\CompositeUtils\Factory\Reflection'
161 161
                     . '\Reflection' . $signular . 'Factory';
162 162
                 $item = $this->{'build' . $signular}
163 163
                 (
Please login to merge, or discard this patch.
Spacing   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -78,8 +78,7 @@  discard block
 block discarded – undo
78 78
      * @param PHPNativeReflectionClass $reflect
79 79
      * @param ReflectionCompositeProviderInterface $provider
80 80
      */
81
-    public function __construct
82
-    (
81
+    public function __construct(
83 82
         PHPNativeReflectionClass $reflect,
84 83
         ReflectionCompositeProviderInterface $provider
85 84
     )
@@ -112,8 +111,7 @@  discard block
 block discarded – undo
112 111
             $this->addInheritance('interfaces', $interface);
113 112
         }
114 113
 
115
-        $this->parseDocComment
116
-        ([
114
+        $this->parseDocComment([
117 115
             'generic' => 'addGeneric'
118 116
         ]);
119 117
 
@@ -122,13 +120,11 @@  discard block
 block discarded – undo
122 120
         $file = (new ReflectionFileFactory($fileName))->build();
123 121
         $this->accessor->setRawValue('file', $file);
124 122
 
125
-        $this->accessor->setRawValue
126
-        (
123
+        $this->accessor->setRawValue(
127 124
             'classname',
128 125
             $this->reflector->name
129 126
         );
130
-        $this->accessor->setRawValue
131
-        (
127
+        $this->accessor->setRawValue(
132 128
             'namespace',
133 129
             $file->namespaces[$this->reflector->getNamespaceName()]
134 130
         );
@@ -151,8 +147,7 @@  discard block
 block discarded – undo
151 147
             $size = count($this->reflector->{'get' . $name}());
152 148
             foreach ($prefixes as $prefix)
153 149
             {
154
-                $this->accessor->setRawValue
155
-                (
150
+                $this->accessor->setRawValue(
156 151
                     $prefix . $name,
157 152
                     new FixedList($size)
158 153
                 );
@@ -207,8 +202,7 @@  discard block
 block discarded – undo
207 202
      * @param bool $checkFile
208 203
      * @param string $singular
209 204
      */
210
-    protected function addItems
211
-    (
205
+    protected function addItems(
212 206
         string $name,
213 207
         bool $checkFile,
214 208
         string $signular
@@ -239,8 +233,7 @@  discard block
 block discarded – undo
239 233
                     new $factory($item),
240 234
                     $item
241 235
                 );
242
-                $this->accessor->rawAddToValue
243
-                (
236
+                $this->accessor->rawAddToValue(
244 237
                     'local' . ucfirst($name),
245 238
                     $item
246 239
                 );
@@ -257,8 +250,7 @@  discard block
 block discarded – undo
257 250
      * @param PHPNativeReflectionClass $reflect
258 251
      * @param string $method
259 252
      */
260
-    protected function addInheritance
261
-    (
253
+    protected function addInheritance(
262 254
         string $group,
263 255
         PHPNativeReflectionClass $reflect,
264 256
         string $method = 'rawAddToValue'
@@ -283,15 +275,13 @@  discard block
 block discarded – undo
283 275
      * @param ReflectionPropertyFactory $factory
284 276
      * @return ReflectionProperty
285 277
      */
286
-    protected function buildProperty
287
-    (
278
+    protected function buildProperty(
288 279
         ReflectionPropertyFactory $factory,
289 280
         PHPNativeReflectionProperty $reflect
290 281
     )
291 282
     : ReflectionProperty
292 283
     {
293
-        return $factory->build
294
-        (
284
+        return $factory->build(
295 285
             $this->object,
296 286
             $this->reflector
297 287
                 ->getDefaultProperties()[$reflect->getName()]
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -174,8 +174,7 @@
 block discarded – undo
174 174
         {
175 175
             $key = $value;
176 176
             $type = '';
177
-        }
178
-        else
177
+        } else
179 178
         {
180 179
             $key = substr($value, 0, $space);
181 180
             $type = substr($value, $space);
Please login to merge, or discard this patch.
src/Service/GenericNameProvider.php 5 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,8 +68,7 @@
 block discarded – undo
68 68
         if ($reflect->generics->empty())
69 69
         {
70 70
             return $reflect->classname;
71
-        }
72
-        else
71
+        } else
73 72
         {
74 73
             $items = [];
75 74
             foreach ($reflect->generics as $generic)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
21 21
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
22 22
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
23
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
24 23
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
25 24
 use Spaark\CompositeUtils\Model\Reflection\Type\GenericType;
26 25
 use Spaark\CompositeUtils\Model\Generic\GenericContext;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
      * Infers the serialized name of the given ObjectType
100 100
      *
101 101
      * @param ObjectType $reflect
102
-     * @return string
102
+     * @return ClassName
103 103
      */
104 104
     protected function inferObjectName(ObjectType $reflect)
105 105
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
 
118 118
             return new ClassName
119 119
             (
120
-                  self::BASE . $reflect->classname
120
+                    self::BASE . $reflect->classname
121 121
                 . '_g' . implode('_c', $items) . '_e'
122 122
             );
123 123
         }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -69,8 +69,7 @@  discard block
 block discarded – undo
69 69
                 return $this->inferGenericName($reflect);
70 70
         }
71 71
 
72
-        throw new \DomainException
73
-        (
72
+        throw new \DomainException(
74 73
             'Unknown type: ' . get_class($reflect)
75 74
         );
76 75
     }
@@ -89,8 +88,7 @@  discard block
 block discarded – undo
89 88
             throw new MissingContextException();
90 89
         }
91 90
 
92
-        return $this->inferName
93
-        (
91
+        return $this->inferName(
94 92
             $this->context->getGenericType($reflect->name)
95 93
         );
96 94
     }
@@ -115,8 +113,7 @@  discard block
 block discarded – undo
115 113
                 $items[] = $this->inferName($generic);
116 114
             }
117 115
 
118
-            return new ClassName
119
-            (
116
+            return new ClassName(
120 117
                   self::BASE . $reflect->classname
121 118
                 . '_g' . implode('_c', $items) . '_e'
122 119
             );
Please login to merge, or discard this patch.
src/Factory/Reflection/TypeParser.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
                     $item = $stack->pop();
101 101
                     if ($value{$i - 1} !== '>')
102 102
                     {
103
-                        $item->generics[] =$this->resolveName();
103
+                        $item->generics[] = $this->resolveName();
104 104
                     }
105 105
 
106 106
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         }
149 149
         elseif ($i + 2 !== strlen($value))
150 150
         {
151
-            if (!in_array($value{$i + 2}, ['>',',']))
151
+            if (!in_array($value{$i + 2}, ['>', ',']))
152 152
             {
153 153
                 throw new \Exception('Unexpected char after collection');
154 154
             }
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -113,8 +113,7 @@  discard block
 block discarded – undo
113 113
                     if ($stack->isEmpty())
114 114
                     {
115 115
                         return $item;
116
-                    }
117
-                    else
116
+                    } else
118 117
                     {
119 118
                         $stack->top()->generics[] = $item;
120 119
                     }
@@ -141,12 +140,10 @@  discard block
 block discarded – undo
141 140
         if ($i + 1 === strlen($value))
142 141
         {
143 142
             throw new \Exception('Unexpected EOF');
144
-        }
145
-        elseif ($value{$i + 1} !== ']')
143
+        } elseif ($value{$i + 1} !== ']')
146 144
         {
147 145
             throw new \Exception('[ must be followed by ]');
148
-        }
149
-        elseif ($i + 2 !== strlen($value))
146
+        } elseif ($i + 2 !== strlen($value))
150 147
         {
151 148
             if (!in_array($value{$i + 2}, ['>',',']))
152 149
             {
@@ -245,12 +242,10 @@  discard block
 block discarded – undo
245 242
         if ($useStatements->containsKey($this->currentValue))
246 243
         {
247 244
             return $useStatements[$this->currentValue]->classname;
248
-        }
249
-        elseif ($generics->containsKey($this->currentValue))
245
+        } elseif ($generics->containsKey($this->currentValue))
250 246
         {
251 247
             return new GenericType($this->currentValue);
252
-        }
253
-        else
248
+        } else
254 249
         {
255 250
             return $this->context->namespace->namespace
256 251
                 . '\\' . $this->currentValue;
Please login to merge, or discard this patch.