View GitHub Repository composite-utils

Schedule Inspection
Subscribe
Completed
Pull Request — master (#6)
by Emily
02:15
created
Status
Category
Toggle Patches
src/Factory/Reflection/GenericCompositeGenerator.php 1 patch
Unused Use Statements   -7 removed lines patch added patch discarded remove patch 
@@ -16,15 +16,8 @@
 
 block discarded – undo
16 16
17 17 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
18 18 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionMethod;
19 
-use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
20 
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
21 
-use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
22 
-use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
23 19 
 use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
24 
-use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
25 
-use Spaark\CompositeUtils\Model\Reflection\Type\GenericType;
26 20 
 use Spaark\CompositeUtils\Model\Generic\GenericContext;
27 
-use Spaark\CompositeUtils\Service\RawPropertyAccessor;
28 21 
 use Spaark\CompositeUtils\Service\GenericNameProvider;
29 22 
 use Spaark\CompositeUtils\Traits\AutoConstructTrait;
30 23
Please login to merge, or discard this patch.
src/Model/Generic/GenericContext.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -17,7 +17,6 @@
 
 block discarded – undo
17 17 
 use Spaark\CompositeUtils\Model\Reflection\Type\AbstractType;
18 18 
 use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
19 19 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
20 
-use Spaark\CompositeUtils\Traits\AllReadableTrait;
21 20 
 use Spaark\CompositeUtils\Traits\AutoConstructTrait;
22 21
23 22 
 /**
Please login to merge, or discard this patch.
src/Service/GenericNameProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -20,7 +20,6 @@
 
 block discarded – undo
20 20 
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
21 21 
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
22 22 
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
23 
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
24 23 
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
25 24 
 use Spaark\CompositeUtils\Model\Reflection\Type\GenericType;
26 25 
 use Spaark\CompositeUtils\Model\Generic\GenericContext;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -99,7 +99,7 @@
 
 block discarded – undo
99 99 
      * Infers the serialized name of the given ObjectType
100 100 
      *
101 101 
      * @param ObjectType $reflect
102 
-     * @return string
102 
+     * @return ClassName
103 103 
      */
104 104 
     protected function inferObjectName(ObjectType $reflect)
105 105 
     {
Please login to merge, or discard this patch.
src/Model/Reflection/Type/ObjectType.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@
 
 block discarded – undo
43 43 
     /**
44 44 
      * Creates this ObjectType with the given classname
45 45 
      *
46 
-     * @param mixed $class The name of the class this must be an
46 
+     * @param string $classname The name of the class this must be an
47 47 
      *     instance of
48 48 
      */
49 49 
     public function __construct($classname)
Please login to merge, or discard this patch.