ClassName::__construct() - Code Metrics - Inspection of "Feature/generic improvements" - spaark/composite-utils - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Emily

created 2017-03-11 15:46 UTC

ClassName::__construct() A

↳ Parent: ClassName

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
ccs	7
cts	7
cp	1
rs	9.4285
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php
/**
 * This file is part of the Composite Utils package.
 *
 * (c) Emily Shepherd <[email protected]>
 *
 * For the full copyright and license information, please view the
 * LICENSE.md file that was distributed with this source code.
 *
 * @package spaark/composite-utils
 * @author Emily Shepherd <[email protected]>
 * @license MIT
 */

namespace Spaark\CompositeUtils\Model;

use Spaark\CompositeUtils\Traits\AllReadableTrait;

/**
 * Models a classname which has both a namespace and a classname
 */
class ClassName
{
    use AllReadableTrait;

    /**
     * @var string
     */
    protected $namespace = '';

    /**
     * @var string
     */
    protected $classname;

    /**
     * Constructs the ClassName by taking a fully qualified classname
     * and splitting it into its namespace and classname sections
     *
     * @param string $classname
     */
    public function __construct(string $classname)
    {
        preg_match('/(.+)\\\\([a-z_A-Z0-9]+)/', $classname, $matches);

        if (!$matches)

        {
            $this->classname = $classname;
        }
        else
        {
            $this->classname = $matches[2];
            $this->namespace = $matches[1];
        }
    }

    /**
     * Returns the fully qualified classname
     *
     * @return string
     */
    public function __toString()
    {
        return
              ($this->namespace ? $this->namespace . '\\' : '')
            . $this->classname;
    }
}


1		<?php
2		/**
3		* This file is part of the Composite Utils package.
4		*
5		* (c) Emily Shepherd <[email protected]>
6		*
7		* For the full copyright and license information, please view the
8		* LICENSE.md file that was distributed with this source code.
9		*
10		* @package spaark/composite-utils
11		* @author Emily Shepherd <[email protected]>
12		* @license MIT
13		*/
14
15		namespace Spaark\CompositeUtils\Model;
16
17		use Spaark\CompositeUtils\Traits\AllReadableTrait;
18
19		/**
20		* Models a classname which has both a namespace and a classname
21		*/
22		class ClassName
23		{
24		use AllReadableTrait;
25
26		/**
27		* @var string
28		*/
29		protected $namespace = '';
30
31		/**
32		* @var string
33		*/
34		protected $classname;
35
36		/**
37		* Constructs the ClassName by taking a fully qualified classname
38		* and splitting it into its namespace and classname sections
39		*
40		* @param string $classname
41		*/
42	32	public function __construct(string $classname)
43		{
44	32	preg_match('/(.+)\\\\([a-z_A-Z0-9]+)/', $classname, $matches);
45
46	32	if (!$matches)
		0 ignored issues – show Bug Best Practice introduced 2017-03-11 15:48 UTC by Report Bug Copy Issue Report The expression `$matches` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
47		{
48	7	$this->classname = $classname;
49		}
50		else
51		{
52	27	$this->classname = $matches[2];
53	27	$this->namespace = $matches[1];
54		}
55	32	}
56
57		/**
58		* Returns the fully qualified classname
59		*
60		* @return string
61		*/
62	14	public function __toString()
63		{
64		return
65	14	($this->namespace ? $this->namespace . '\\' : '')
66	14	. $this->classname;
67		}
68		}
69

spaark / composite-utils

Pull Request — master (#6)

ClassName::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like