ReflectionPropertyFactory::build() - Code Metrics - Inspection of "Calculate property type based on use statements" - spaark/composite-utils - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01dc8d...fb21bc )

by Emily

created 2017-02-11 22:37 UTC

ReflectionPropertyFactory::build() A

↳ Parent: ReflectionPropertyFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	2
crap	1

<?php

namespace Spaark\CompositeUtils\Factory\Reflection;

use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
use \ReflectionProperty as PHPNativeReflectionProperty;

class ReflectionPropertyFactory extends ReflectorFactory
{
    const REFLECTION_OBJECT = ReflectionProperty::class;

    protected $acceptedParams =
    [
        'readable' => 'setBool',
        'writable' => 'setBool',
        'var' => 'setType'
    ];

    public static function fromName($class, $property)
    {
        return new static(new PHPNativeReflectionProperty
        (
            $class, $property
        ));
    }

    public function build(ReflectionComposite $parent, $default)
    {
        $this->accessor->setRawValue('owner', $parent);
        $this->accessor->setRawValue('defaultValue', $default);
        $this->accessor->setRawValue
        (
            'name',
            $this->reflector->getName()
        );

        $this->parseDocComment();

        return $this->object;
    }

    protected function setType($name, $value)

    {
        if ($value{0} !== '?')

        {
            $nullable = false;
        }
        else
        {
            $nullable = true;
            $value = substr($value, 1);
        }

        if (substr($value, -2) !== '[]')

        {
            $collection = false;
        }
        else
        {
            $collection = true;
            $value = substr($value, 0, -2);
        }

        switch ($value)
        {
            case 'string':
                $class = new StringType();
                break;
            case 'int':
            case 'integer':
                $class = new IntegerType();
                break;
            case 'bool':
            case 'boolean':
                $class = new BooleanType();
                break;
            case 'mixed':
            case '':
                $class = new MixedType();
                break;
            case 'null':
                $class = new NullType();
                break;
            default:
                $useStatements =
                    $this->object->owner->namespace->useStatements;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

                if ($useStatements->contains($value))
                {
                    $value = $useStatements[$value]->classname;
                }

                $class = new ObjectType($value);
        }

        if ($nullable)
        {
            (new RawPropertyAccessor($class))
                ->setRawValue('nullable', $value);
        }

        if ($collection)
        {
            $class = new CollectionType($class);
        }

        $this->accessor->setRawValue('type', $class);
    }
}



1			<?php
2
3			namespace Spaark\CompositeUtils\Factory\Reflection;
4
5			use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
6			use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
7			use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
8			use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
9			use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
10			use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
11			use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
12			use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
13			use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
14			use \ReflectionProperty as PHPNativeReflectionProperty;
15
16			class ReflectionPropertyFactory extends ReflectorFactory
17			{
18			const REFLECTION_OBJECT = ReflectionProperty::class;
19
20			protected $acceptedParams =
21			[
22			'readable' => 'setBool',
23			'writable' => 'setBool',
24			'var' => 'setType'
25			];
26
27			public static function fromName($class, $property)
28			{
29			return new static(new PHPNativeReflectionProperty
30			(
31			$class, $property
32			));
33			}
34
35	4		public function build(ReflectionComposite $parent, $default)
36			{
37	4		$this->accessor->setRawValue('owner', $parent);
38	4		$this->accessor->setRawValue('defaultValue', $default);
39	4		$this->accessor->setRawValue
40			(
41	4		'name',
42	4		$this->reflector->getName()
43			);
44
45	4		$this->parseDocComment();
46
47	4		return $this->object;
48			}
49
50	4		protected function setType($name, $value)
			0 ignored issues – show Unused Code introduced 2017-02-11 12:59 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51			{
52	4	View Code Duplication	if ($value{0} !== '?')
			0 ignored issues – show Duplication introduced 2017-02-11 12:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53			{
54	4		$nullable = false;
55			}
56			else
57			{
58			$nullable = true;
59			$value = substr($value, 1);
60			}
61
62	4	View Code Duplication	if (substr($value, -2) !== '[]')
			0 ignored issues – show Duplication introduced 2017-02-11 12:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63			{
64	4		$collection = false;
65			}
66			else
67			{
68			$collection = true;
69			$value = substr($value, 0, -2);
70			}
71
72			switch ($value)
73			{
74	4		case 'string':
75	4		$class = new StringType();
76	4		break;
77	4		case 'int':
78	4		case 'integer':
79	4		$class = new IntegerType();
80	4		break;
81	4		case 'bool':
82	4		case 'boolean':
83			$class = new BooleanType();
84			break;
85	4		case 'mixed':
86	4		case '':
87			$class = new MixedType();
88			break;
89	4		case 'null':
90			$class = new NullType();
91			break;
92			default:
93			$useStatements =
94	4		$this->object->owner->namespace->useStatements;
			0 ignored issues – show Documentation introduced 2017-02-11 22:39 UTC by Report Bug Copy Issue Report The property `owner` does not exist on `object<Spaark\CompositeU...l\Reflection\Reflector>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
95
96	4		if ($useStatements->contains($value))
97			{
98	4		$value = $useStatements[$value]->classname;
99			}
100
101	4		$class = new ObjectType($value);
102			}
103
104	4		if ($nullable)
105			{
106			(new RawPropertyAccessor($class))
107			->setRawValue('nullable', $value);
108			}
109
110	4		if ($collection)
111			{
112			$class = new CollectionType($class);
113			}
114
115	4		$this->accessor->setRawValue('type', $class);
116	4		}
117			}
118
119

spaark / composite-utils

Push — master ( 01dc8d...fb21bc )

ReflectionPropertyFactory::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like