spaark / composite-utils

src/Service/GenericNameProvider.php

Unused Use Statements -3 removed lines

@@ -20,10 +20,7 @@
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
-use Spaark\CompositeUtils\Exception\PropertyNotWritableException;
-use Spaark\CompositeUtils\Exception\PropertyNotReadableException;
 
 /**
  * Used to retrieve the classname for an AbstractType

Braces +1 added lines, -2 removed lines

@@ -68,8 +68,7 @@
         if ($reflect->generics->empty())
         {
             return $reflect->classname;
-        }
-        else
+        } else
         {
             $items = [];
             foreach ($reflect->generics as $generic)

src/Factory/Reflection/TypeParser.php

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
                     $item = $stack->pop();
                     if ($value{$i - 1} !== '>')
                     {
-                        $item->generics[] =$this->resolveName();
+                        $item->generics[] = $this->resolveName();
                     }
 
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -148,7 +148,7 @@ 
         }
         elseif ($i + 2 !== strlen($value))
         {
-            if (!in_array($value{$i + 2}, ['>',',']))
+            if (!in_array($value{$i + 2}, ['>', ',']))
             {
                 throw new \Exception('Unexpected char after collection');
             }

Braces +5 added lines, -10 removed lines

@@ -113,8 +113,7 @@ 
                     if ($stack->isEmpty())
                     {
                         return $item;
-                    }
-                    else
+                    } else
                     {
                         $stack->top()->generics[] = $item;
                     }
@@ -141,12 +140,10 @@ 
         if ($i + 1 === strlen($value))
         {
             throw new \Exception('Unexpected EOF');
-        }
-        elseif ($value{$i + 1} !== ']')
+        } elseif ($value{$i + 1} !== ']')
         {
             throw new \Exception('[ must be followed by ]');
-        }
-        elseif ($i + 2 !== strlen($value))
+        } elseif ($i + 2 !== strlen($value))
         {
             if (!in_array($value{$i + 2}, ['>',',']))
             {
@@ -245,12 +242,10 @@ 
         if ($useStatements->containsKey($this->currentValue))
         {
             return $useStatements[$this->currentValue]->classname;
-        }
-        elseif ($generics->containsKey($this->currentValue))
+        } elseif ($generics->containsKey($this->currentValue))
         {
             return new GenericType($this->currentValue);
-        }
-        else
+        } else
         {
             return $this->context->namespace->namespace
                 . '\\' . $this->currentValue;

src/Service/TypeComparator.php

Spacing +1 added lines, -2 removed lines

@@ -31,8 +31,7 @@
      * @param AbstractType $child
      * @return boolean
      */
-    public function compatible
-    (
+    public function compatible(
         AbstractType $parent,
         AbstractType $child
     )

Braces +2 added lines, -4 removed lines

@@ -41,12 +41,10 @@
         if ($parent instanceof MixedType)
         {
             return true;
-        }
-        elseif ($parent instanceof ScalarType)
+        } elseif ($parent instanceof ScalarType)
         {
             return get_class($parent) === get_class($child);
-        }
-        elseif ($parent instanceof ObjectType)
+        } elseif ($parent instanceof ObjectType)
         {
             return
                 $child instanceof ObjectType && 

src/Model/Collection/OrderedMap.php

Doc Comments -2 removed lines

@@ -37,8 +37,6 @@
     /**
      * Adds an element to the Map
      *
-     * @param KeyType $key The key to add
-     * @param ValueType $value The value to add
      */
     public function insert(Pair $pair)
     {

Spacing +1 added lines, -2 removed lines

@@ -44,8 +44,7 @@
     {
         if (!$pair instanceof OrderedPair)
         {
-            $pair = new OrderedPair
-            (
+            $pair = new OrderedPair(
                 $this->size(),
                 $pair->key,
                 $pair->value

src/Factory/Reflection/ReflectionMethodFactory.php

Indentation +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
         $this->initParams();
 
         $this->accessor->setRawValue('visibility',
-              ($this->reflector->isPublic() ? 'public'
+                ($this->reflector->isPublic() ? 'public'
             : ($this->reflector->isProtected() ? 'protected'
             : ($this->reflector->isPrivate() ? 'private'
             : (''))))

Spacing +6 added lines, -11 removed lines

@@ -63,8 +63,7 @@ 
      */
     public static function fromName(string $class, string $method)
     {
-        return new static(new PHPNativeReflectionMethod
-        (
+        return new static(new PHPNativeReflectionMethod(
             $class, $method
         ));
     }
@@ -84,12 +83,11 @@ 
      *     this method belongs to
      * @return ReflectionMethod
      */
-    public function build(?ReflectionComposite $parent = null)
+    public function build(? ReflectionComposite $parent = null)
     {
         $this->typeParser = new TypeParser($parent);
         $this->accessor->setRawValue('owner', $parent);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );
@@ -125,13 +123,11 @@ 
      */
     protected function initParams()
     {
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'parameters',
             new FixedList(count($this->reflector->getParameters()))
         );
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'nativeParameters',
             new FixedList(count($this->reflector->getParameters()))
         );
@@ -174,8 +170,7 @@ 
      *
      * @param PHPNativeReflectionParameter $reflect
      */
-    protected function addParameter
-    (
+    protected function addParameter(
         PHPNativeReflectionParameter $reflect
     )
     : void