Completed
Push — master ( fb21bc...46b7df )
by Emily
02:00
created
src/Factory/Reflection/ReflectorFactory.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,8 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
     protected function parseDocComment()
39 39
     {
40
-        preg_match_all
41
-        (
40
+        preg_match_all(
42 41
               '/^'
43 42
             .     '[ \t]*\*[ \t]*'
44 43
             .     '@([a-zA-Z]+)'
@@ -55,8 +54,7 @@  discard block
 block discarded – undo
55 54
 
56 55
             if (isset($this->acceptedParams[$name]))
57 56
             {
58
-                call_user_func
59
-                (
57
+                call_user_func(
60 58
                     array($this, $this->acceptedParams[$name]),
61 59
                     $name, $value
62 60
                 );
@@ -66,7 +64,7 @@  discard block
 block discarded – undo
66 64
 
67 65
     protected function setBool($name, $value)
68 66
     {
69
-        switch(strtolower($value))
67
+        switch (strtolower($value))
70 68
         {
71 69
             case '':
72 70
             case 'true':
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionPropertyFactory.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
     public static function fromName($class, $property)
28 28
     {
29
-        return new static(new PHPNativeReflectionProperty
30
-        (
29
+        return new static(new PHPNativeReflectionProperty(
31 30
             $class, $property
32 31
         ));
33 32
     }
@@ -36,8 +35,7 @@  discard block
 block discarded – undo
36 35
     {
37 36
         $this->accessor->setRawValue('owner', $parent);
38 37
         $this->accessor->setRawValue('defaultValue', $default);
39
-        $this->accessor->setRawValue
40
-        (
38
+        $this->accessor->setRawValue(
41 39
             'name',
42 40
             $this->reflector->getName()
43 41
         );
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionMethodFactory.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -13,17 +13,15 @@
 block discarded – undo
13 13
 
14 14
     public static function fromName($class, $method)
15 15
     {
16
-        return new static(new PHPNativeReflectionMethod
17
-        (
16
+        return new static(new PHPNativeReflectionMethod(
18 17
             $class, $method
19 18
         ));
20 19
     }
21 20
 
22
-    public function build(?ReflectionComposite $parent = null)
21
+    public function build(? ReflectionComposite $parent = null)
23 22
     {
24 23
         $this->accessor->setRawValue('owner', $parent);
25
-        $this->accessor->setRawValue
26
-        (
24
+        $this->accessor->setRawValue(
27 25
             'name',
28 26
             $this->reflector->getName()
29 27
         );
Please login to merge, or discard this patch.
src/Model/Collection/Set.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,8 @@
 block discarded – undo
28 28
     {
29 29
         return
30 30
               (is_object($value) ? spl_object_hash($value)
31
-            : (is_array($value)  ? implode($value)
32
-            : (                    (string)$value)));
31
+            : (is_array($value) ? implode($value)
32
+            : ((string)$value)));
33 33
     }
34 34
 
35 35
     /**
Please login to merge, or discard this patch.
src/Exception/NonExistentPropertyException.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,8 +8,7 @@
 block discarded – undo
8 8
 
9 9
     public function __construct($class, $property, $previous = null)
10 10
     {
11
-        parent::__construct
12
-        (
11
+        parent::__construct(
13 12
               'Cannot ' . static::ACCESS_TYPE . ' non existent '
14 13
             . 'property: ' . $class . '::$' . $property,
15 14
             0,
Please login to merge, or discard this patch.
src/Service/RawPropertyAccessor.php 2 patches
Spacing   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -48,8 +48,7 @@  discard block
 block discarded – undo
48 48
      */
49 49
     public function setRawValue($key, $value)
50 50
     {
51
-        $this->getPropertyOrFail
52
-        (
51
+        $this->getPropertyOrFail(
53 52
             $key,
54 53
             CannotWritePropertyException::class
55 54
         )
@@ -68,8 +67,7 @@  discard block
 block discarded – undo
68 67
     public function getRawValue($key)
69 68
     {
70 69
         return
71
-            $this->getPropertyOrFail
72
-            (
70
+            $this->getPropertyOrFail(
73 71
                 $key,
74 72
                 CannotReadPropertyException::class
75 73
             )
@@ -86,8 +84,7 @@  discard block
 block discarded – undo
86 84
      */ 
87 85
     public function rawAddToValue($key, $value)
88 86
     {
89
-        $property = $this->getPropertyOrFail
90
-        (
87
+        $property = $this->getPropertyOrFail(
91 88
             $key,
92 89
             CannotWritePropertyException::class
93 90
         );
@@ -113,8 +110,7 @@  discard block
 block discarded – undo
113 110
         }
114 111
         catch (ReflectionException $e)
115 112
         {
116
-            throw new $class
117
-            (
113
+            throw new $class(
118 114
                 get_class($this->object),
119 115
                 $key,
120 116
                 $e
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@  discard block
 block discarded – undo
29 29
 
30 30
     /**
31 31
      * @param object $object The object to access
32
-     * @param ReflectionModel|null $reflect A reflection entity
33 32
      */
34 33
     public function __construct($object)
35 34
     {
@@ -61,7 +60,7 @@  discard block
 block discarded – undo
61 60
      * permissions
62 61
      *
63 62
      * @param string $key The property to read
64
-     * @return mixed The property's value
63
+     * @return \Reflector The property's value
65 64
      * @throws CannotReadPropertyException In the event the property
66 65
      *     does not exist
67 66
      */
@@ -80,7 +79,7 @@  discard block
 block discarded – undo
80 79
      * Adds a value to a property, irrespective of access permissions
81 80
      *
82 81
      * @param string $key The property to write to
83
-     * @param mixed $value The value to add
82
+     * @param \Spaark\CompositeUtils\Model\Reflection\Reflector $value The value to add
84 83
      * @throws CannotWritePropertyException In the event the property
85 84
      *    does not exist
86 85
      */ 
Please login to merge, or discard this patch.
src/Model/Collection/HashMap.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,8 @@
 block discarded – undo
24 24
     {
25 25
         return
26 26
               (is_object($value) ? spl_object_hash($value)
27
-            : (is_array($value)  ? implode($value)
28
-            : (                    (string)$value)));
27
+            : (is_array($value) ? implode($value)
28
+            : ((string)$value)));
29 29
     }
30 30
 
31 31
     public function key()
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionFileFactory.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,8 +60,7 @@  discard block
 block discarded – undo
60 60
                     case T_NAMESPACE:
61 61
                         $ns = new NamespaceBlock($classname);
62 62
                         $currentNS = new RawPropertyAccessor($ns);
63
-                        $this->accessor->getRawValue
64
-                        (
63
+                        $this->accessor->getRawValue(
65 64
                             'namespaces'
66 65
                         )
67 66
                         ->add($classname, $ns);
@@ -76,8 +75,7 @@  discard block
 block discarded – undo
76 75
                             $as = end($as);
77 76
                         }
78 77
 
79
-                        $currentNS->getRawValue
80
-                        (
78
+                        $currentNS->getRawValue(
81 79
                             'useStatements'
82 80
                         )
83 81
                         ->add($as, new UseStatement($classname, $as));
Please login to merge, or discard this patch.
src/Service/PropertyAccessor.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -103,6 +103,10 @@
 block discarded – undo
103 103
         }
104 104
     }
105 105
 
106
+    /**
107
+     * @param string $name
108
+     * @param \Closure $cast
109
+     */
106 110
     private function setScalarValue($property, $value, $name, $cast)
107 111
     {
108 112
         $method = '__to' . $name;
Please login to merge, or discard this patch.
Spacing   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -36,8 +36,7 @@  discard block
 block discarded – undo
36 36
     {
37 37
         if (!$this->reflect->properties->contains($property))
38 38
         {
39
-            throw new CannotWritePropertyException
40
-            (
39
+            throw new CannotWritePropertyException(
41 40
                 get_class($this->object), $property
42 41
             );
43 42
         }
@@ -113,8 +112,7 @@  discard block
 block discarded – undo
113 112
         }
114 113
         elseif (is_object($value) && method_exists([$value, $method]))
115 114
         {
116
-            $this->setScalarValue
117
-            (
115
+            $this->setScalarValue(
118 116
                 $property,
119 117
                 $value->$method(),
120 118
                 $method,
@@ -153,8 +151,7 @@  discard block
 block discarded – undo
153 151
 
154 152
     private function throwError($property, $expected, $value)
155 153
     {
156
-        throw new IllegalPropertyTypeException
157
-        (
154
+        throw new IllegalPropertyTypeException(
158 155
             get_class($this->object),
159 156
             $property,
160 157
             $expected,
Please login to merge, or discard this patch.