Completed
Pull Request — master (#6)
by Emily
02:10
created
src/Service/TypeComparator.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,12 +41,10 @@
 block discarded – undo
41 41
         if ($parent instanceof MixedType)
42 42
         {
43 43
             return true;
44
-        }
45
-        elseif ($parent instanceof ScalarType)
44
+        } elseif ($parent instanceof ScalarType)
46 45
         {
47 46
             return get_class($parent) === get_class($child);
48
-        }
49
-        elseif ($parent instanceof ObjectType)
47
+        } elseif ($parent instanceof ObjectType)
50 48
         {
51 49
             return
52 50
                 $child instanceof ObjectType && 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,8 +31,7 @@  discard block
 block discarded – undo
31 31
      * @param AbstractType $child
32 32
      * @return boolean
33 33
      */
34
-    public function compatible
35
-    (
34
+    public function compatible(
36 35
         AbstractType $parent,
37 36
         AbstractType $child
38 37
     )
@@ -53,8 +52,7 @@  discard block
 block discarded – undo
53 52
                 is_a($child->classname, $parent->classname, true);
54 53
         }
55 54
 
56
-        throw new \DomainException
57
-        (
55
+        throw new \DomainException(
58 56
             'Unknown type: ' . get_class($parent)
59 57
         );
60 58
     }
Please login to merge, or discard this patch.
src/Model/Collection/OrderedMap.php 2 patches
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,7 @@
 block discarded – undo
44 44
     {
45 45
         if (!$pair instanceof OrderedPair)
46 46
         {
47
-            $pair = new OrderedPair
48
-            (
47
+            $pair = new OrderedPair(
49 48
                 $this->size(),
50 49
                 $pair->key,
51 50
                 $pair->value
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -37,8 +37,6 @@  discard block
 block discarded – undo
37 37
     /**
38 38
      * Adds an element to the Map
39 39
      *
40
-     * @param KeyType $key The key to add
41
-     * @param ValueType $value The value to add
42 40
      */
43 41
     public function insert(Pair $pair)
44 42
     {
@@ -59,7 +57,7 @@  discard block
 block discarded – undo
59 57
     /**
60 58
      * Checks if a key exists
61 59
      *
62
-     * @param KeyType $key The key to search for
60
+     * @param string $key The key to search for
63 61
      * @return boolean
64 62
      */
65 63
     public function containsKey($key) : bool
@@ -103,6 +101,9 @@  discard block
 block discarded – undo
103 101
         return $this->list->size();
104 102
     }
105 103
 
104
+    /**
105
+     * @param string $key
106
+     */
106 107
     public function indexOfKey($key)
107 108
     {
108 109
         return $this->getPair($key)->index;
Please login to merge, or discard this patch.
src/Traits/HasReflectorTrait.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@  discard block
 block discarded – undo
41 41
         if (!static::$reflectionComposite)
42 42
         {
43 43
             static::$reflectionComposite =
44
-                ReflectionCompositeFactory::fromClassName
45
-                (
44
+                ReflectionCompositeFactory::fromClassName(
46 45
                     get_called_class()
47 46
                 )
48 47
                 ->build();
@@ -54,8 +53,7 @@  discard block
 block discarded – undo
54 53
     /**
55 54
      * Set the default ReflectionComposite for this class
56 55
      */
57
-    protected static function setDefaultReflectionComposite
58
-    (
56
+    protected static function setDefaultReflectionComposite(
59 57
         ReflectionComposite $defaultReflectionComposite
60 58
     )
61 59
     {
Please login to merge, or discard this patch.
src/Factory/Reflection/GenericCompositeGenerator.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $i = 0;
66 66
 
67 67
         $code =
68
-              '<?php namespace ' . $namespace . ';'
68
+                '<?php namespace ' . $namespace . ';'
69 69
             . 'class ' . $baseClass . ' extends ' . $originalClass
70 70
             . '{';
71 71
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         }
108 108
 
109 109
         return
110
-              ($method->scope === 'static' ? 'static ' : '')
110
+                ($method->scope === 'static' ? 'static ' : '')
111 111
             . 'function ' . $method->name
112 112
             . '(' . implode(',', $params) . '){'
113 113
             . '__generic_' . $method->name
Please login to merge, or discard this patch.
Unused Use Statements   -7 removed lines patch added patch discarded remove patch
@@ -16,15 +16,8 @@
 block discarded – undo
16 16
 
17 17
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
18 18
 use Spaark\CompositeUtils\Model\Reflection\ReflectionMethod;
19
-use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
20
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
21
-use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
22
-use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
23 19
 use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
24
-use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
25
-use Spaark\CompositeUtils\Model\Reflection\Type\GenericType;
26 20
 use Spaark\CompositeUtils\Model\Generic\GenericContext;
27
-use Spaark\CompositeUtils\Service\RawPropertyAccessor;
28 21
 use Spaark\CompositeUtils\Service\GenericNameProvider;
29 22
 use Spaark\CompositeUtils\Traits\AutoConstructTrait;
30 23
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,7 @@
 block discarded – undo
73 73
     public function generateClassCode(...$generics) : string
74 74
     {
75 75
         $object = $this->createObject(...$generics);
76
-        $this->nameProvider = new GenericNameProvider
77
-        (
76
+        $this->nameProvider = new GenericNameProvider(
78 77
             new GenericContext($object, $this->reflect)
79 78
         );
80 79
         $class = $this->nameProvider->inferName($object);
Please login to merge, or discard this patch.
src/Model/Common/Equatable.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     /**
26 26
      * Checks if the given class is equal to this one
27 27
      *
28
-     * @param Type $oject
28
+     * @param Type $object
29 29
      * @return boolean
30 30
      */
31 31
     public function equals($object) : bool;
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionMethodFactory.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $this->initParams();
98 98
 
99 99
         $this->accessor->setRawValue('visibility',
100
-              ($this->reflector->isPublic() ? 'public'
100
+                ($this->reflector->isPublic() ? 'public'
101 101
             : ($this->reflector->isProtected() ? 'protected'
102 102
             : ($this->reflector->isPrivate() ? 'private'
103 103
             : (''))))
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         {
155 155
             throw new \Exception
156 156
             (
157
-                  'Tried to set param annotation for non existant '
157
+                    'Tried to set param annotation for non existant '
158 158
                 . 'parameter: ' . $param
159 159
             );
160 160
         }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -13 removed lines patch added patch discarded remove patch
@@ -63,8 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public static function fromName(string $class, string $method)
65 65
     {
66
-        return new static(new PHPNativeReflectionMethod
67
-        (
66
+        return new static(new PHPNativeReflectionMethod(
68 67
             $class, $method
69 68
         ));
70 69
     }
@@ -84,12 +83,11 @@  discard block
 block discarded – undo
84 83
      *     this method belongs to
85 84
      * @return ReflectionMethod
86 85
      */
87
-    public function build(?ReflectionComposite $parent = null)
86
+    public function build(? ReflectionComposite $parent = null)
88 87
     {
89 88
         $this->typeParser = new TypeParser($parent);
90 89
         $this->accessor->setRawValue('owner', $parent);
91
-        $this->accessor->setRawValue
92
-        (
90
+        $this->accessor->setRawValue(
93 91
             'name',
94 92
             $this->reflector->getName()
95 93
         );
@@ -125,13 +123,11 @@  discard block
 block discarded – undo
125 123
      */
126 124
     protected function initParams()
127 125
     {
128
-        $this->accessor->setRawValue
129
-        (
126
+        $this->accessor->setRawValue(
130 127
             'parameters',
131 128
             new FixedList(count($this->reflector->getParameters()))
132 129
         );
133
-        $this->accessor->setRawValue
134
-        (
130
+        $this->accessor->setRawValue(
135 131
             'nativeParameters',
136 132
             new FixedList(count($this->reflector->getParameters()))
137 133
         );
@@ -152,8 +148,7 @@  discard block
 block discarded – undo
152 148
 
153 149
         if (!$this->parameters->containsKey($param))
154 150
         {
155
-            throw new \Exception
156
-            (
151
+            throw new \Exception(
157 152
                   'Tried to set param annotation for non existant '
158 153
                 . 'parameter: ' . $param
159 154
             );
@@ -178,8 +173,7 @@  discard block
 block discarded – undo
178 173
      *
179 174
      * @param PHPNativeReflectionParameter $reflect
180 175
      */
181
-    protected function addParameter
182
-    (
176
+    protected function addParameter(
183 177
         PHPNativeReflectionParameter $reflect
184 178
     )
185 179
     : void
Please login to merge, or discard this patch.
src/Model/Generic/GenericContext.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Spaark\CompositeUtils\Model\Reflection\Type\AbstractType;
18 18
 use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
19 19
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
20
-use Spaark\CompositeUtils\Traits\AllReadableTrait;
21 20
 use Spaark\CompositeUtils\Traits\AutoConstructTrait;
22 21
 
23 22
 /**
Please login to merge, or discard this patch.
src/Exception/MissingContextException.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     {
36 36
         parent::__construct
37 37
         (
38
-              'Cannot serialize object containing generics without '
38
+                'Cannot serialize object containing generics without '
39 39
             . 'context',
40 40
             0,
41 41
             $previous
Please login to merge, or discard this patch.
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,13 +28,11 @@
 block discarded – undo
28 28
      *
29 29
      * @param Throwable $previous The exception which caused this
30 30
      */
31
-    public function __construct
32
-    (
31
+    public function __construct(
33 32
         Throwable $previous = null
34 33
     )
35 34
     {
36
-        parent::__construct
37
-        (
35
+        parent::__construct(
38 36
               'Cannot serialize object containing generics without '
39 37
             . 'context',
40 38
             0,
Please login to merge, or discard this patch.
src/Service/ReflectionCompositeProvider.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,8 +54,7 @@  discard block
 block discarded – undo
54 54
      *
55 55
      * @param ReflectionCompositeProviderInterface $default
56 56
      */
57
-    public static function setDefault
58
-    (
57
+    public static function setDefault(
59 58
         ReflectionCompositeProviderInterface $default
60 59
     )
61 60
     {
@@ -90,8 +89,7 @@  discard block
 block discarded – undo
90 89
         {
91 90
             $this->cache[$classname] =
92 91
                 (
93
-                    ReflectionCompositeFactory::fromClassName
94
-                    (
92
+                    ReflectionCompositeFactory::fromClassName(
95 93
                         $classname
96 94
                     )
97 95
                 )
Please login to merge, or discard this patch.