Completed
Pull Request — master (#4)
by Emily
02:20
created
src/Factory/Reflection/ReflectorFactory.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,8 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     protected function parseDocComment(array $acceptedParams)
65 65
     {
66
-        preg_match_all
67
-        (
66
+        preg_match_all(
68 67
               '/^'
69 68
             .     '[ \t]*\*[ \t]*'
70 69
             .     '@([a-zA-Z]+)'
@@ -81,8 +80,7 @@  discard block
 block discarded – undo
81 80
 
82 81
             if (isset($acceptedParams[$name]))
83 82
             {
84
-                call_user_func
85
-                (
83
+                call_user_func(
86 84
                     array($this, $acceptedParams[$name]),
87 85
                     $name, $value
88 86
                 );
@@ -98,7 +96,7 @@  discard block
 block discarded – undo
98 96
      */
99 97
     protected function setBool($name, $value)
100 98
     {
101
-        switch(strtolower($value))
99
+        switch (strtolower($value))
102 100
         {
103 101
             case '':
104 102
             case 'true':
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionPropertyFactory.php 1 patch
Spacing   +12 added lines, -24 removed lines patch added patch discarded remove patch
@@ -53,8 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public static function fromName($class, $property)
55 55
     {
56
-        return new static(new PHPNativeReflectionProperty
57
-        (
56
+        return new static(new PHPNativeReflectionProperty(
58 57
             $class, $property
59 58
         ));
60 59
     }
@@ -72,14 +71,12 @@  discard block
 block discarded – undo
72 71
     {
73 72
         $this->accessor->setRawValue('owner', $parent);
74 73
         $this->accessor->setRawValue('defaultValue', $default);
75
-        $this->accessor->setRawValue
76
-        (
74
+        $this->accessor->setRawValue(
77 75
             'name',
78 76
             $this->reflector->getName()
79 77
         );
80 78
 
81
-        $this->parseDocComment
82
-        ([
79
+        $this->parseDocComment([
83 80
             'readable' => 'setBool',
84 81
             'writable' => 'setBool',
85 82
             'var' => 'setType',
@@ -97,8 +94,7 @@  discard block
 block discarded – undo
97 94
      */
98 95
     protected function setType($name, $value)
99 96
     {
100
-        $this->accessor->setRawValue
101
-        (
97
+        $this->accessor->setRawValue(
102 98
             'type',
103 99
             (new TypeParser($this->object->owner))->parse($value)
104 100
         );
@@ -120,50 +116,42 @@  discard block
 block discarded – undo
120 116
         switch ($value[0])
121 117
         {
122 118
             case 'required':
123
-                $this->accessor->setRawValue
124
-                (
119
+                $this->accessor->setRawValue(
125 120
                     'passedToConstructor',
126 121
                     true
127 122
                 );
128
-                $this->accessor->setRawValue
129
-                (
123
+                $this->accessor->setRawValue(
130 124
                     'requiredInConstructor',
131 125
                     true
132 126
                 );
133
-                $compositeAccessor->rawAddToValue
134
-                (
127
+                $compositeAccessor->rawAddToValue(
135 128
                     'requiredProperties',
136 129
                     $this->object
137 130
                 );
138 131
                 break;
139 132
             case 'new':
140
-                $this->accessor->setRawValue
141
-                (
133
+                $this->accessor->setRawValue(
142 134
                     'builtInConstructor',
143 135
                     true
144 136
                 );
145
-                $compositeAccessor->rawAddToValue
146
-                (
137
+                $compositeAccessor->rawAddToValue(
147 138
                     'builtProperties',
148 139
                     $this->object
149 140
                 );
150 141
                 break;
151 142
             case 'optional':
152
-                $this->accessor->setRawValue
153
-                (
143
+                $this->accessor->setRawValue(
154 144
                     'passedToConstructor',
155 145
                     true
156 146
                 );
157
-                $compositeAccessor->rawAddToValue
158
-                (
147
+                $compositeAccessor->rawAddToValue(
159 148
                     'optionalProperties',
160 149
                     $this->object
161 150
                 );
162 151
 
163 152
                 if (isset($value[1]) && $value[1] === 'new')
164 153
                 {
165
-                    $this->accessor->setRawValue
166
-                    (
154
+                    $this->accessor->setRawValue(
167 155
                         'builtInConstructor',
168 156
                         true
169 157
                     );
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionCompositeFactory.php 1 patch
Spacing   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -78,8 +78,7 @@  discard block
 block discarded – undo
78 78
      * @param PHPNativeReflectionClass $reflect
79 79
      * @param ReflectionCompositeProviderInterface $provider
80 80
      */
81
-    public function __construct
82
-    (
81
+    public function __construct(
83 82
         PHPNativeReflectionClass $reflect,
84 83
         ReflectionCompositeProviderInterface $provider
85 84
     )
@@ -112,8 +111,7 @@  discard block
 block discarded – undo
112 111
             $this->addInheritance('interfaces', $interface);
113 112
         }
114 113
 
115
-        $this->parseDocComment
116
-        ([
114
+        $this->parseDocComment([
117 115
             'generic' => 'addGeneric'
118 116
         ]);
119 117
 
@@ -122,13 +120,11 @@  discard block
 block discarded – undo
122 120
         $file = (new ReflectionFileFactory($fileName))->build();
123 121
         $this->accessor->setRawValue('file', $file);
124 122
 
125
-        $this->accessor->setRawValue
126
-        (
123
+        $this->accessor->setRawValue(
127 124
             'classname',
128 125
             $this->reflector->name
129 126
         );
130
-        $this->accessor->setRawValue
131
-        (
127
+        $this->accessor->setRawValue(
132 128
             'namespace',
133 129
             $file->namespaces[$this->reflector->getNamespaceName()]
134 130
         );
@@ -151,8 +147,7 @@  discard block
 block discarded – undo
151 147
             $size = count($this->reflector->{'get' . $name}());
152 148
             foreach ($prefixes as $prefix)
153 149
             {
154
-                $this->accessor->setRawValue
155
-                (
150
+                $this->accessor->setRawValue(
156 151
                     $prefix . $name,
157 152
                     new FixedList($size)
158 153
                 );
@@ -207,8 +202,7 @@  discard block
 block discarded – undo
207 202
      * @param bool $checkFile
208 203
      * @param string $singular
209 204
      */
210
-    protected function addItems
211
-    (
205
+    protected function addItems(
212 206
         string $name,
213 207
         bool $checkFile,
214 208
         string $signular
@@ -239,8 +233,7 @@  discard block
 block discarded – undo
239 233
                     new $factory($item),
240 234
                     $item
241 235
                 );
242
-                $this->accessor->rawAddToValue
243
-                (
236
+                $this->accessor->rawAddToValue(
244 237
                     'local' . ucfirst($name),
245 238
                     $item
246 239
                 );
@@ -257,8 +250,7 @@  discard block
 block discarded – undo
257 250
      * @param PHPNativeReflectionClass $reflect
258 251
      * @param string $method
259 252
      */
260
-    protected function addInheritance
261
-    (
253
+    protected function addInheritance(
262 254
         string $group,
263 255
         PHPNativeReflectionClass $reflect,
264 256
         string $method = 'rawAddToValue'
@@ -283,15 +275,13 @@  discard block
 block discarded – undo
283 275
      * @param ReflectionPropertyFactory $factory
284 276
      * @return ReflectionProperty
285 277
      */
286
-    protected function buildProperty
287
-    (
278
+    protected function buildProperty(
288 279
         ReflectionPropertyFactory $factory,
289 280
         PHPNativeReflectionProperty $reflect
290 281
     )
291 282
     : ReflectionProperty
292 283
     {
293
-        return $factory->build
294
-        (
284
+        return $factory->build(
295 285
             $this->object,
296 286
             $this->reflector
297 287
                 ->getDefaultProperties()[$reflect->getName()]
Please login to merge, or discard this patch.
src/Factory/Reflection/TypeParser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
                     $item = $stack->pop();
101 101
                     if ($value{$i - 1} !== '>')
102 102
                     {
103
-                        $item->generics[] =$this->resolveName();
103
+                        $item->generics[] = $this->resolveName();
104 104
                     }
105 105
 
106 106
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         }
149 149
         elseif ($i + 2 !== strlen($value))
150 150
         {
151
-            if (!in_array($value{$i + 2}, ['>',',']))
151
+            if (!in_array($value{$i + 2}, ['>', ',']))
152 152
             {
153 153
                 throw new \Exception('Unexpected char after collection');
154 154
             }
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionMethodFactory.php 1 patch
Spacing   +6 added lines, -11 removed lines patch added patch discarded remove patch
@@ -63,8 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public static function fromName(string $class, string $method)
65 65
     {
66
-        return new static(new PHPNativeReflectionMethod
67
-        (
66
+        return new static(new PHPNativeReflectionMethod(
68 67
             $class, $method
69 68
         ));
70 69
     }
@@ -84,12 +83,11 @@  discard block
 block discarded – undo
84 83
      *     this method belongs to
85 84
      * @return ReflectionMethod
86 85
      */
87
-    public function build(?ReflectionComposite $parent = null)
86
+    public function build(? ReflectionComposite $parent = null)
88 87
     {
89 88
         $this->typeParser = new TypeParser($parent);
90 89
         $this->accessor->setRawValue('owner', $parent);
91
-        $this->accessor->setRawValue
92
-        (
90
+        $this->accessor->setRawValue(
93 91
             'name',
94 92
             $this->reflector->getName()
95 93
         );
@@ -112,8 +110,7 @@  discard block
 block discarded – undo
112 110
      */
113 111
     protected function initParams()
114 112
     {
115
-        $this->accessor->setRawValue
116
-        (
113
+        $this->accessor->setRawValue(
117 114
             'parameters',
118 115
             new FixedList(count($this->reflector->getParameters()))
119 116
         );
@@ -156,8 +153,7 @@  discard block
 block discarded – undo
156 153
      *
157 154
      * @param PHPNativeReflectionParameter $reflect
158 155
      */
159
-    protected function addParameter
160
-    (
156
+    protected function addParameter(
161 157
         PHPNativeReflectionParameter $reflect
162 158
     )
163 159
     : void
@@ -169,8 +165,7 @@  discard block
 block discarded – undo
169 165
 
170 166
         $accessor->setRawValue('owner', $this->object);
171 167
         $accessor->setRawValue('name', $reflect->getName());
172
-        $accessor->setRawValue
173
-        (
168
+        $accessor->setRawValue(
174 169
             'type',
175 170
             $this->typeParser->parse((string)$reflect->getType())
176 171
         );
Please login to merge, or discard this patch.
src/Service/TypeComparator.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,8 +31,7 @@
 block discarded – undo
31 31
      * @param AbstractType $child
32 32
      * @return boolean
33 33
      */
34
-    public function compatible
35
-    (
34
+    public function compatible(
36 35
         AbstractType $parent,
37 36
         AbstractType $child
38 37
     )
Please login to merge, or discard this patch.