Completed
Pull Request — master (#4)
by Emily
02:20
created
src/Service/GenericNameProvider.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -20,10 +20,7 @@
 block discarded – undo
20 20
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
21 21
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
22 22
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
23
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
24 23
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
25
-use Spaark\CompositeUtils\Exception\PropertyNotWritableException;
26
-use Spaark\CompositeUtils\Exception\PropertyNotReadableException;
27 24
 
28 25
 /**
29 26
  * Used to retrieve the classname for an AbstractType
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,8 +68,7 @@
 block discarded – undo
68 68
         if ($reflect->generics->empty())
69 69
         {
70 70
             return $reflect->classname;
71
-        }
72
-        else
71
+        } else
73 72
         {
74 73
             $items = [];
75 74
             foreach ($reflect->generics as $generic)
Please login to merge, or discard this patch.
src/Factory/Reflection/TypeParser.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
                     $item = $stack->pop();
101 101
                     if ($value{$i - 1} !== '>')
102 102
                     {
103
-                        $item->generics[] =$this->resolveName();
103
+                        $item->generics[] = $this->resolveName();
104 104
                     }
105 105
 
106 106
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         }
149 149
         elseif ($i + 2 !== strlen($value))
150 150
         {
151
-            if (!in_array($value{$i + 2}, ['>',',']))
151
+            if (!in_array($value{$i + 2}, ['>', ',']))
152 152
             {
153 153
                 throw new \Exception('Unexpected char after collection');
154 154
             }
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -113,8 +113,7 @@  discard block
 block discarded – undo
113 113
                     if ($stack->isEmpty())
114 114
                     {
115 115
                         return $item;
116
-                    }
117
-                    else
116
+                    } else
118 117
                     {
119 118
                         $stack->top()->generics[] = $item;
120 119
                     }
@@ -141,12 +140,10 @@  discard block
 block discarded – undo
141 140
         if ($i + 1 === strlen($value))
142 141
         {
143 142
             throw new \Exception('Unexpected EOF');
144
-        }
145
-        elseif ($value{$i + 1} !== ']')
143
+        } elseif ($value{$i + 1} !== ']')
146 144
         {
147 145
             throw new \Exception('[ must be followed by ]');
148
-        }
149
-        elseif ($i + 2 !== strlen($value))
146
+        } elseif ($i + 2 !== strlen($value))
150 147
         {
151 148
             if (!in_array($value{$i + 2}, ['>',',']))
152 149
             {
@@ -245,12 +242,10 @@  discard block
 block discarded – undo
245 242
         if ($useStatements->containsKey($this->currentValue))
246 243
         {
247 244
             return $useStatements[$this->currentValue]->classname;
248
-        }
249
-        elseif ($generics->containsKey($this->currentValue))
245
+        } elseif ($generics->containsKey($this->currentValue))
250 246
         {
251 247
             return new GenericType($this->currentValue);
252
-        }
253
-        else
248
+        } else
254 249
         {
255 250
             return $this->context->namespace->namespace
256 251
                 . '\\' . $this->currentValue;
Please login to merge, or discard this patch.
src/Factory/Reflection/ReflectionMethodFactory.php 1 patch
Spacing   +6 added lines, -11 removed lines patch added patch discarded remove patch
@@ -63,8 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public static function fromName(string $class, string $method)
65 65
     {
66
-        return new static(new PHPNativeReflectionMethod
67
-        (
66
+        return new static(new PHPNativeReflectionMethod(
68 67
             $class, $method
69 68
         ));
70 69
     }
@@ -84,12 +83,11 @@  discard block
 block discarded – undo
84 83
      *     this method belongs to
85 84
      * @return ReflectionMethod
86 85
      */
87
-    public function build(?ReflectionComposite $parent = null)
86
+    public function build(? ReflectionComposite $parent = null)
88 87
     {
89 88
         $this->typeParser = new TypeParser($parent);
90 89
         $this->accessor->setRawValue('owner', $parent);
91
-        $this->accessor->setRawValue
92
-        (
90
+        $this->accessor->setRawValue(
93 91
             'name',
94 92
             $this->reflector->getName()
95 93
         );
@@ -112,8 +110,7 @@  discard block
 block discarded – undo
112 110
      */
113 111
     protected function initParams()
114 112
     {
115
-        $this->accessor->setRawValue
116
-        (
113
+        $this->accessor->setRawValue(
117 114
             'parameters',
118 115
             new FixedList(count($this->reflector->getParameters()))
119 116
         );
@@ -156,8 +153,7 @@  discard block
 block discarded – undo
156 153
      *
157 154
      * @param PHPNativeReflectionParameter $reflect
158 155
      */
159
-    protected function addParameter
160
-    (
156
+    protected function addParameter(
161 157
         PHPNativeReflectionParameter $reflect
162 158
     )
163 159
     : void
@@ -169,8 +165,7 @@  discard block
 block discarded – undo
169 165
 
170 166
         $accessor->setRawValue('owner', $this->object);
171 167
         $accessor->setRawValue('name', $reflect->getName());
172
-        $accessor->setRawValue
173
-        (
168
+        $accessor->setRawValue(
174 169
             'type',
175 170
             $this->typeParser->parse((string)$reflect->getType())
176 171
         );
Please login to merge, or discard this patch.
src/Service/TypeComparator.php 2 patches
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,8 +31,7 @@
 block discarded – undo
31 31
      * @param AbstractType $child
32 32
      * @return boolean
33 33
      */
34
-    public function compatible
35
-    (
34
+    public function compatible(
36 35
         AbstractType $parent,
37 36
         AbstractType $child
38 37
     )
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,12 +41,10 @@
 block discarded – undo
41 41
         if ($parent instanceof MixedType)
42 42
         {
43 43
             return true;
44
-        }
45
-        elseif ($parent instanceof ScalarType)
44
+        } elseif ($parent instanceof ScalarType)
46 45
         {
47 46
             return get_class($parent) === get_class($child);
48
-        }
49
-        elseif ($parent instanceof ObjectType)
47
+        } elseif ($parent instanceof ObjectType)
50 48
         {
51 49
             return
52 50
                 $child instanceof ObjectType && 
Please login to merge, or discard this patch.