spaark / composite-utils

src/Factory/Reflection/ReflectionPropertyFactory.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
-use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
 use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
 use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
      * Builds the ReflectionProperty from the provided parameters,
      * linking to a parent ReflectionComposite
      *
-     * @param ReflectionCompostite $parent The reflector for the class
+     * @param ReflectionComposite $parent The reflector for the class
      *     this property belongs to
      * @param mixed $default This property's default value
      * @return ReflectionProperty

Spacing +10 added lines, -20 removed lines

@@ -64,8 +64,7 @@ 
      */
     public static function fromName($class, $property)
     {
-        return new static(new PHPNativeReflectionProperty
-        (
+        return new static(new PHPNativeReflectionProperty(
             $class, $property
         ));
     }
@@ -83,8 +82,7 @@ 
     {
         $this->accessor->setRawValue('owner', $parent);
         $this->accessor->setRawValue('defaultValue', $default);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );
@@ -189,50 +187,42 @@ 
         switch ($value[0])
         {
             case 'required':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'requiredInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'requiredProperties',
                     $this->object
                 );
                 break;
             case 'new':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'builtInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'builtProperties',
                     $this->object
                 );
                 break;
             case 'optional':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'optionalProperties',
                     $this->object
                 );
 
                 if (isset($value[1]) && $value[1] === 'new')
                 {
-                    $this->accessor->setRawValue
-                    (
+                    $this->accessor->setRawValue(
                         'builtInConstructor',
                         true
                     );

Braces +3 added lines, -6 removed lines

@@ -105,8 +105,7 @@ 
         if ($value{0} !== '?')
         {
             $nullable = false;
-        }
-        else
+        } else
         {
             $nullable = true;
             $value = substr($value, 1);
@@ -115,8 +114,7 @@ 
         if (substr($value, -2) !== '[]')
         {
             $collection = false;
-        }
-        else
+        } else
         {
             $collection = true;
             $value = substr($value, 0, -2);
@@ -149,8 +147,7 @@ 
                 if ($useStatements->containsKey($value))
                 {
                     $value = $useStatements[$value]->classname;
-                }
-                else
+                } else
                 {
                     $value = $this->object->owner->namespace->namespace
                         . '\\' . $value;

src/Factory/Reflection/ReflectorFactory.php

Indentation +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     {
         preg_match_all
         (
-              '/^'
+                '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
             .     '(.*)'

Spacing +3 added lines, -5 removed lines

@@ -71,8 +71,7 @@ 
      */
     protected function parseDocComment()
     {
-        preg_match_all
-        (
+        preg_match_all(
               '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
@@ -89,8 +88,7 @@ 
 
             if (isset($this->acceptedParams[$name]))
             {
-                call_user_func
-                (
+                call_user_func(
                     array($this, $this->acceptedParams[$name]),
                     $name, $value
                 );
@@ -106,7 +104,7 @@ 
      */
     protected function setBool($name, $value)
     {
-        switch(strtolower($value))
+        switch (strtolower($value))
         {
             case '':
             case 'true':

src/Model/Collection/Set.php

Indentation +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     private function getScalar($value)
     {
         return
-              (is_object($value) ? spl_object_hash($value)
+                (is_object($value) ? spl_object_hash($value)
             : (is_array($value)  ? implode($value)
             : (                    (string)$value)));
     }

Spacing +2 added lines, -2 removed lines

@@ -28,8 +28,8 @@
     {
         return
               (is_object($value) ? spl_object_hash($value)
-            : (is_array($value)  ? implode($value)
-            : (                    (string)$value)));
+            : (is_array($value) ? implode($value)
+            : ((string)$value)));
     }
 
     /**

src/Model/Collection/Stack.php

Braces +3 added lines, -1 removed lines

@@ -43,7 +43,9 @@
      */
     public function popMultiple($i = 1)
     {
-        if ($i < 1) return NULL;
+        if ($i < 1) {
+            return NULL;
+        }
 
         $ret = array_slice($this->data, -1 * $i);
         $this->data = array_slice($this->data, 0, -1 * $i);

src/Service/RawPropertyAccessor.php

Spacing +4 added lines, -8 removed lines

@@ -48,8 +48,7 @@ 
      */
     public function setRawValue($key, $value)
     {
-        $this->getPropertyOrFail
-        (
+        $this->getPropertyOrFail(
             $key,
             CannotWritePropertyException::class
         )
@@ -68,8 +67,7 @@ 
     public function getRawValue($key)
     {
         return
-            $this->getPropertyOrFail
-            (
+            $this->getPropertyOrFail(
                 $key,
                 CannotReadPropertyException::class
             )
@@ -86,8 +84,7 @@ 
      */ 
     public function rawAddToValue($key, $value)
     {
-        $property = $this->getPropertyOrFail
-        (
+        $property = $this->getPropertyOrFail(
             $key,
             CannotWritePropertyException::class
         );
@@ -113,8 +110,7 @@ 
         }
         catch (ReflectionException $e)
         {
-            throw new $class
-            (
+            throw new $class(
                 get_class($this->object),
                 $key,
                 $e

Braces +1 added lines, -2 removed lines

@@ -110,8 +110,7 @@
             $prop->setAccessible(true);
 
             return $prop;
-        }
-        catch (ReflectionException $e)
+        } catch (ReflectionException $e)
         {
             throw new $class
             (

src/Factory/Reflection/ReflectionFileFactory.php

Braces +2 added lines, -4 removed lines

@@ -93,8 +93,7 @@ 
                 {
                     $as .= $token[1];
                 }
-            }
-            elseif ($matching)
+            } elseif ($matching)
             {
                 switch ($token[0])
                 {
@@ -105,8 +104,7 @@ 
                     case T_AS:
                         $matching = T_AS;
                 }
-            }
-            else
+            } else
             {
                 switch ($token[0])
                 {

Spacing +2 added lines, -4 removed lines

@@ -60,8 +60,7 @@ 
                     case T_NAMESPACE:
                         $ns = new NamespaceBlock($classname);
                         $currentNS = new RawPropertyAccessor($ns);
-                        $this->accessor->getRawValue
-                        (
+                        $this->accessor->getRawValue(
                             'namespaces'
                         )
                         ->add($classname, $ns);
@@ -76,8 +75,7 @@ 
                             $as = end($as);
                         }
 
-                        $currentNS->getRawValue
-                        (
+                        $currentNS->getRawValue(
                             'useStatements'
                         )
                         ->add($as, new UseStatement($classname, $as));

src/Exception/IllegalPropertyTypeException.php

Indentation +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     {
         parent::__construct
         (
-              'Tried to set an illegal property type for '
+                'Tried to set an illegal property type for '
             . $class .'::$' . $property . '. Excpected ' . $expected
             . ', got ' . $got,
             0,

Spacing +3 added lines, -5 removed lines

@@ -32,8 +32,7 @@ 
      * @param string $got The type that was provided
      * @param Exception $previous The exception which caused this
      */
-    public function __construct
-    (
+    public function __construct(
         string $class,
         string $property,
         string $expected,
@@ -41,10 +40,9 @@ 
         Exception $previous = null
     )
     {
-        parent::__construct
-        (
+        parent::__construct(
               'Tried to set an illegal property type for '
-            . $class .'::$' . $property . '. Excpected ' . $expected
+            . $class . '::$' . $property . '. Excpected ' . $expected
             . ', got ' . $got,
             0,
             $previous

src/Service/ConditionalPropertyAccessor.php

Braces +2 added lines, -4 removed lines

@@ -12,8 +12,7 @@ 
         if ($property->writable)
         {
             parent::setAnyValue($property, $value);
-        }
-        else
+        } else
         {
             throw new PropertyNotWritableException
             (
@@ -32,8 +31,7 @@ 
                 get_class($this->object),
                 $property
             );
-        }
-        elseif (!$this->reflect->properties[$property]->readable)
+        } elseif (!$this->reflect->properties[$property]->readable)
         {
             throw new PropertyNotReadableException
             (

Spacing +3 added lines, -6 removed lines

@@ -35,8 +35,7 @@ 
         }
         else
         {
-            throw new PropertyNotWritableException
-            (
+            throw new PropertyNotWritableException(
                 get_class($this->object),
                 $property->name
             );
@@ -50,16 +49,14 @@ 
     {
         if (!$this->reflect->properties->containsKey($property))
         {
-            throw new CannotReadPropertyException
-            (
+            throw new CannotReadPropertyException(
                 get_class($this->object),
                 $property
             );
         }
         elseif (!$this->reflect->properties[$property]->readable)
         {
-            throw new PropertyNotReadableException
-            (
+            throw new PropertyNotReadableException(
                 get_class($this->object),
                 $property
             );

src/Traits/HasReflectorTrait.php

Spacing +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
         if (!static::$reflectionComposite)
         {
             static::$reflectionComposite =
-                ReflectionCompositeFactory::fromClassName
-                (
+                ReflectionCompositeFactory::fromClassName(
                     get_called_class()
                 )
                 ->build();