Url::normalize() - Code Metrics - Inspection of "normalize url method added #1" - soyFelixBarros/Scraper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7a79f...951203 )

by Felix

created 2018-02-05 01:28 UTC

Url::normalize() A

↳ Parent: Url

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
ccs	4
cts	5
cp	0.8
rs	9.4285
cc	2
eloc	5
nc	2
nop	1
crap	2.032

<?php

namespace Felix\Scraper;

class Url
{
    protected $url;
    protected $parts;

    public function __construct($url)
    {
        $this->url = $url;
        $this->parts = parse_url($url);
    }

    /**
     * Obtener una parte de la URL.
     * 
     * @param $part string Parte de la URL (Ej: host).
     * 
     * @return string|null
     */
    public function getPart($part)
    {
        return array_key_exists($part, $this->parts) ? $this->parts[$part] : null;
    }

    /**
     * Url tiene un esquema.
     * 
     * @return boolean true|false
     */
    public function hasScheme()
    {
        return $this->getPart('scheme') !== null;
    }

    /**
     * Url tiene un dominio.
     * 
     * @return boolean true|false
     */
    public function hasHost()
    {
        return $this->getPart('host') !== null;
    }

    /**
     * Dada una URL, normaliza esa URL.
     * 
     * @param $url string Url base (Ej. http://example.com)
     * 
     * @return string  
     */
    public function normalize($schemeAndHost)
    {
        $url = urldecode($this->url);

        if (! $this->hasScheme()) {
            $url = $schemeAndHost.$url;
        }

        return $url;
    }
}

1		<?php
2
3		namespace Felix\Scraper;
4
5		class Url
6		{
7		protected $url;
8		protected $parts;
9
10		public function __construct($url)
11		{
12		$this->url = $url;
13		$this->parts = parse_url($url);
14		}
15
16		/**
17		* Obtener una parte de la URL.
18		*
19		* @param $part string Parte de la URL (Ej: host).
20		*
21		* @return string\|null
22		*/
23	5	public function getPart($part)
24		{
25	5	return array_key_exists($part, $this->parts) ? $this->parts[$part] : null;
26		}
27
28		/**
29		* Url tiene un esquema.
30		*
31		* @return boolean true\|false
32		*/
33	2	public function hasScheme()
34		{
35	2	return $this->getPart('scheme') !== null;
36		}
37
38		/**
39		* Url tiene un dominio.
40		*
41		* @return boolean true\|false
42		*/
43	1	public function hasHost()
44		{
45	1	return $this->getPart('host') !== null;
46		}
47
48		/**
49		* Dada una URL, normaliza esa URL.
50		*
51		* @param $url string Url base (Ej. http://example.com)
52		*
53		* @return string
54		*/
55	1	public function normalize($schemeAndHost)
56		{
57	1	$url = urldecode($this->url);
58
59	1	if (! $this->hasScheme()) {
60		$url = $schemeAndHost.$url;
61		}
62
63	1	return $url;
64		}
65		}

soyFelixBarros / Scraper

Push — master ( f7a79f...951203 )

Url::normalize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like