Issues in cleverbot.php (master) - Issues in master - sovereignbot/citadel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (81)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Plugins/onMessage/cleverbot.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Sovereign\Plugins\onMessage;

use Discord\Discord;
use Discord\Parts\Channel\Message;
use Monolog\Logger;
use Sovereign\Lib\Config;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Sovereign\Lib\cURL;
use Sovereign\Lib\Db;
use Sovereign\Lib\Permissions;
use Sovereign\Lib\ServerConfig;
use Sovereign\Lib\Settings;
use Sovereign\Lib\Users;

/**
 * Class cleverBotMessage
 * @package Sovereign
 */
class cleverBotMessage extends \Threaded implements \Collectable
{
    /** @var Message $message */
    private $message;
    /** @var Discord $discord */
    private $discord;
    /**
     * @var Logger
     */
    private $log;
    /**
     * @var Config
     */
    private $config;
    /**
     * @var Db
     */
    private $db;
    /**
     * @var cURL
     */
    private $curl;
    /**
     * @var Settings
     */
    private $settings;
    /**
     * @var Permissions
     */
    private $permissions;
    /**
     * @var ServerConfig
     */
    private $serverConfig;
    /**
     * @var Users
     */
    private $users;

    /**
     * cleverBotMessage constructor.
     * @param $message
     * @param $discord
     * @param $log
     * @param $config
     * @param $db
     * @param $curl
     * @param $settings
     * @param $permissions
     * @param $serverConfig
     * @param $users
     */
    public function __construct($message, $discord, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users)

    {
        $this->message = $message;
        $this->discord = $discord;
        $this->log = $log;
        $this->config = $config;
        $this->db = $db;
        $this->curl = $curl;
        $this->settings = $settings;
        $this->permissions = $permissions;
        $this->serverConfig = $serverConfig;
        $this->users = $users;
    }

    /**
     *
     */
    public function run()
    {
        $guildID = $this->message->getFullChannelAttribute()->guild_id;

        $cleverBotNick = $this->db->queryField("SELECT nick FROM cleverbot WHERE serverID = :serverID", "nick", array(":serverID" => $guildID));

        // Simply remove the <id> part of the string, since it seems to make the responses from Cleverbot be less idiotic and terrible..
        $msg = str_replace("<@{$this->discord->getClient()->id}>", "", $this->message->content);
        $response = $this->curl->post("https://cleverbot.io/1.0/ask", array("user" => $this->config->get("user", "cleverbot"), "key" => $this->config->get("key", "cleverbot"), "nick" => $cleverBotNick, "text" => $msg));

        if ($response) {
            $resp = @json_decode($response);
            $reply = isset($resp->response) ? $resp->response : false;
            if ($reply) {
                $this->message->getChannelAttribute()->broadcastTyping();
                $this->message->reply($reply);
            }
        }
    }
}

1		<?php
2		namespace Sovereign\Plugins\onMessage;
3
4		use Discord\Discord;
5		use Discord\Parts\Channel\Message;
6		use Monolog\Logger;
7		use Sovereign\Lib\Config;
		0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Sovereign\Plugins\onMessage\Config`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8		use Sovereign\Lib\cURL;
9		use Sovereign\Lib\Db;
10		use Sovereign\Lib\Permissions;
11		use Sovereign\Lib\ServerConfig;
12		use Sovereign\Lib\Settings;
13		use Sovereign\Lib\Users;
14
15		/**
16		* Class cleverBotMessage
17		* @package Sovereign
18		*/
19		class cleverBotMessage extends \Threaded implements \Collectable
20		{
21		/** @var Message $message */
22		private $message;
23		/** @var Discord $discord */
24		private $discord;
25		/**
26		* @var Logger
27		*/
28		private $log;
29		/**
30		* @var Config
31		*/
32		private $config;
33		/**
34		* @var Db
35		*/
36		private $db;
37		/**
38		* @var cURL
39		*/
40		private $curl;
41		/**
42		* @var Settings
43		*/
44		private $settings;
45		/**
46		* @var Permissions
47		*/
48		private $permissions;
49		/**
50		* @var ServerConfig
51		*/
52		private $serverConfig;
53		/**
54		* @var Users
55		*/
56		private $users;
57
58		/**
59		* cleverBotMessage constructor.
60		* @param $message
61		* @param $discord
62		* @param $log
63		* @param $config
64		* @param $db
65		* @param $curl
66		* @param $settings
67		* @param $permissions
68		* @param $serverConfig
69		* @param $users
70		*/
71	View Code Duplication	public function __construct($message, $discord, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users)
		0 ignored issues – show Duplication introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		{
73		$this->message = $message;
74		$this->discord = $discord;
75		$this->log = $log;
76		$this->config = $config;
77		$this->db = $db;
78		$this->curl = $curl;
79		$this->settings = $settings;
80		$this->permissions = $permissions;
81		$this->serverConfig = $serverConfig;
82		$this->users = $users;
83		}
84
85		/**
86		*
87		*/
88		public function run()
89		{
90		$guildID = $this->message->getFullChannelAttribute()->guild_id;
91
92		$cleverBotNick = $this->db->queryField("SELECT nick FROM cleverbot WHERE serverID = :serverID", "nick", array(":serverID" => $guildID));
93
94		// Simply remove the <id> part of the string, since it seems to make the responses from Cleverbot be less idiotic and terrible..
95		$msg = str_replace("<@{$this->discord->getClient()->id}>", "", $this->message->content);
96		$response = $this->curl->post("https://cleverbot.io/1.0/ask", array("user" => $this->config->get("user", "cleverbot"), "key" => $this->config->get("key", "cleverbot"), "nick" => $cleverBotNick, "text" => $msg));
97
98		if ($response) {
99		$resp = @json_decode($response);
100		$reply = isset($resp->response) ? $resp->response : false;
101		if ($reply) {
102		$this->message->getChannelAttribute()->broadcastTyping();
103		$this->message->reply($reply);
104		}
105		}
106		}
107		}

sovereignbot / citadel

Issues (81)

Security Analysis no request data

src/Plugins/onMessage/cleverbot.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like