sovereignbot /
citadel
| Conditions | 8 |
| Paths | 4 |
| Total Lines | 79 |
| Code Lines | 60 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 8 | ||
| Bugs | 2 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | public function run() |
||
| 84 | { |
||
| 85 | $pornConfig = @$this->channelConfig->porn; |
||
| 86 | |||
| 87 | // This is one of those plugins that need to be allowed before it works |
||
| 88 | if (isset($pornConfig->allowedChannels) && in_array($this->message->channel_id, $pornConfig->allowedChannels)) { |
||
| 89 | $explode = explode(" ", $this->message->content); |
||
| 90 | unset($explode[0]); |
||
| 91 | $type = implode(" ", $explode); |
||
| 92 | $categoryNames = array(); |
||
| 93 | $url = ""; |
||
| 94 | |||
| 95 | $categories = array( |
||
| 96 | "redheads" => array( |
||
| 97 | "https://api.imgur.com/3/gallery/r/redheads/time/all/", |
||
| 98 | "https://api.imgur.com/3/gallery/r/ginger/time/all/", |
||
| 99 | "https://api.imgur.com/3/gallery/r/FireCrotch/time/all/" |
||
| 100 | ), |
||
| 101 | "blondes" => "https://api.imgur.com/3/gallery/r/blondes/time/all/", |
||
| 102 | "asians" => "https://api.imgur.com/3/gallery/r/AsiansGoneWild/time/all/", |
||
| 103 | "gonewild" => "https://api.imgur.com/3/gallery/r/gonewild/time/all/", |
||
| 104 | "realgirls" => "https://api.imgur.com/3/gallery/r/realgirls/time/all/", |
||
| 105 | "palegirls" => "https://api.imgur.com/3/gallery/r/palegirls/time/all/", |
||
| 106 | "gif" => "https://api.imgur.com/3/gallery/r/NSFW_GIF/time/all/", |
||
| 107 | "lesbians" => "https://api.imgur.com/3/gallery/r/lesbians/time/all/", |
||
| 108 | "tattoos" => "https://api.imgur.com/3/gallery/r/Hotchickswithtattoos/time/all/", |
||
| 109 | "mgw" => "https://api.imgur.com/3/gallery/r/MilitaryGoneWild/time/all/", |
||
| 110 | "amateur" => "https://api.imgur.com/3/gallery/r/AmateurArchives/time/all/", |
||
| 111 | "college" => "https://api.imgur.com/3/gallery/r/collegesluts/time/all/", |
||
| 112 | "bondage" => "https://api.imgur.com/3/gallery/r/bondage/time/all/", |
||
| 113 | "milf" => "https://api.imgur.com/3/gallery/r/milf/time/all/", |
||
| 114 | "freckles" => "https://api.imgur.com/3/gallery/r/FreckledGirls/time/all/", |
||
| 115 | "cosplay" => "https://api.imgur.com/3/gallery/r/cosplay/time/all/", |
||
| 116 | "tits" => "https://api.imgur.com/3/gallery/r/boobs/time/all/", |
||
| 117 | "ass" => "https://api.imgur.com/3/gallery/r/ass/time/all/", |
||
| 118 | "food" => "https://api.imgur.com/3/gallery/r/foodporn/time/all/", |
||
| 119 | "gifrecipes" => "https://api.imgur.com/3/gallery/r/gifrecipes/time/all/", |
||
| 120 | "bbw" => "https://api.imgur.com/3/gallery/r/bbw/time/all/", |
||
| 121 | "dongs" => "https://api.imgur.com/3/gallery/r/penis/time/all/", |
||
| 122 | "innie" => "https://api.imgur.com/3/gallery/r/innie/time/all/", |
||
| 123 | ); |
||
| 124 | |||
| 125 | foreach($categories as $catName => $catURL) { |
||
| 126 | $categoryNames[] = ucfirst($catName); |
||
| 127 | if(strtolower($type) == strtolower($catName)) { |
||
| 128 | if(is_array($catURL)) |
||
| 129 | $url = $catURL[array_rand($catURL)]; |
||
| 130 | else |
||
| 131 | $url = $catURL; |
||
| 132 | } |
||
| 133 | } |
||
| 134 | |||
| 135 | if (!empty($url)) { |
||
| 136 | // Select a random url |
||
| 137 | $clientID = $this->config->get("clientID", "imgur"); |
||
| 138 | $headers = array(); |
||
| 139 | $headers[] = "Content-type: application/json"; |
||
| 140 | $headers[] = "Authorization: Client-ID {$clientID}"; |
||
| 141 | $data = $this->curl->get($url, $headers); |
||
| 142 | |||
| 143 | if ($data) { |
||
| 144 | $json = json_decode($data, true)["data"]; |
||
| 145 | $img = $json[array_rand($json)]; |
||
| 146 | $imageURL = $img["link"]; // gifv doesn't embed properly in discord, yet.. |
||
| 147 | $msg = "**Title:** {$img["title"]} | **Section:** {$img["section"]} | **url:** {$imageURL}"; |
||
| 148 | $this->message->reply($msg); |
||
| 149 | } |
||
| 150 | } else { |
||
| 151 | $msg = "No endpoint selected. Currently available are: " . implode(", ", $categoryNames); |
||
| 152 | $this->message->reply($msg); |
||
| 153 | } |
||
| 154 | |||
| 155 | } else { |
||
| 156 | $this->message->reply("Sorry, this plugin is not allowed in this channel, speak to your admin to get it allowed (To enable, use {$this->channelConfig->prefix}config enablePorn)"); |
||
| 157 | } |
||
| 158 | |||
| 159 | // Mark this as garbage |
||
| 160 | $this->isGarbage(); |
||
| 161 | } |
||
| 162 | } |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: