guilds::__construct() - Code Metrics - sovereignbot/citadel - Measure and Improve Code Quality continuously with Scrutinizer

guilds::__construct() A
last analyzed 2016-06-02 11:44 UTC

↳ Parent: guilds

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	13

Duplication

Lines	15
Ratio	100 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
cc	1
eloc	13
c	3
b	1
f	0
nc	1
nop	12
dl	15
loc	15
rs	9.4285

How to fix Many Parameters

<?php

namespace Sovereign\Plugins\onMessage;

use Discord\Discord;
use Discord\Parts\Channel\Message;
use Discord\Parts\Guild\Guild;
use Monolog\Logger;
use Sovereign\Lib\Config;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Sovereign\Lib\cURL;
use Sovereign\Lib\Db;
use Sovereign\Lib\Permissions;
use Sovereign\Lib\ServerConfig;
use Sovereign\Lib\Settings;
use Sovereign\Lib\Users;

class guilds extends \Threaded implements \Collectable
{
    /**
     * @var Message
     */
    private $message;
    /**
     * @var Discord
     */
    private $discord;
    /**
     * @var Logger
     */
    private $log;
    /**
     * @var array
     */
    private $channelConfig;
    /**
     * @var Config
     */
    private $config;
    /**
     * @var Db
     */
    private $db;
    /**
     * @var cURL
     */
    private $curl;
    /**
     * @var Settings
     */
    private $settings;
    /**
     * @var Permissions
     */
    private $permissions;
    /**
     * @var ServerConfig
     */
    private $serverConfig;
    /**
     * @var Users
     */
    private $users;
    /**
     * @var array
     */
    private $extras;

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)

    {
        $this->message = $message;
        $this->discord = $discord;
        $this->channelConfig = $channelConfig;
        $this->log = $log;
        $this->config = $config;
        $this->db = $db;
        $this->curl = $curl;
        $this->settings = $settings;
        $this->permissions = $permissions;
        $this->serverConfig = $serverConfig;
        $this->users = $users;
        $this->extras = $extras;
    }

    public function run()
    {
        $guilds = $this->discord->guilds->all();
        $list = "";
        /** @var Guild $guild */
        foreach ($guilds as $guild) {
            $guildID = $guild->getAttribute("id");
            $memberCount = $this->extras["guild"]["memberCount"]["id{$guildID}"];
            $list .= "{$guild->getAttribute("name")} ({$memberCount}) | ";
        }

        $this->message->reply("I am on the following servers: " . rtrim($list, ", "));

        // Mark this as garbage
        $this->isGarbage();
    }
}

1		<?php
2
3		namespace Sovereign\Plugins\onMessage;
4
5		use Discord\Discord;
6		use Discord\Parts\Channel\Message;
7		use Discord\Parts\Guild\Guild;
8		use Monolog\Logger;
9		use Sovereign\Lib\Config;
		0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Sovereign\Plugins\onMessage\Config`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
10		use Sovereign\Lib\cURL;
11		use Sovereign\Lib\Db;
12		use Sovereign\Lib\Permissions;
13		use Sovereign\Lib\ServerConfig;
14		use Sovereign\Lib\Settings;
15		use Sovereign\Lib\Users;
16
17		class guilds extends \Threaded implements \Collectable
18		{
19		/**
20		* @var Message
21		*/
22		private $message;
23		/**
24		* @var Discord
25		*/
26		private $discord;
27		/**
28		* @var Logger
29		*/
30		private $log;
31		/**
32		* @var array
33		*/
34		private $channelConfig;
35		/**
36		* @var Config
37		*/
38		private $config;
39		/**
40		* @var Db
41		*/
42		private $db;
43		/**
44		* @var cURL
45		*/
46		private $curl;
47		/**
48		* @var Settings
49		*/
50		private $settings;
51		/**
52		* @var Permissions
53		*/
54		private $permissions;
55		/**
56		* @var ServerConfig
57		*/
58		private $serverConfig;
59		/**
60		* @var Users
61		*/
62		private $users;
63		/**
64		* @var array
65		*/
66		private $extras;
67
68	View Code Duplication	public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
		0 ignored issues – show Duplication introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		{
70		$this->message = $message;
71		$this->discord = $discord;
72		$this->channelConfig = $channelConfig;
73		$this->log = $log;
74		$this->config = $config;
75		$this->db = $db;
76		$this->curl = $curl;
77		$this->settings = $settings;
78		$this->permissions = $permissions;
79		$this->serverConfig = $serverConfig;
80		$this->users = $users;
81		$this->extras = $extras;
82		}
83
84		public function run()
85		{
86		$guilds = $this->discord->guilds->all();
87		$list = "";
88		/** @var Guild $guild */
89		foreach ($guilds as $guild) {
90		$guildID = $guild->getAttribute("id");
91		$memberCount = $this->extras["guild"]["memberCount"]["id{$guildID}"];
92		$list .= "{$guild->getAttribute("name")} ({$memberCount}) \| ";
93		}
94
95		$this->message->reply("I am on the following servers: " . rtrim($list, ", "));
96
97		// Mark this as garbage
98		$this->isGarbage();
99		}
100		}

sovereignbot / citadel

guilds::__construct() A last analyzed 2016-06-02 11:44 UTC

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

guilds::__construct() A
last analyzed 2016-06-02 11:44 UTC