sovereignbot /
citadel
| Conditions | 7 |
| Paths | 8 |
| Total Lines | 63 |
| Code Lines | 48 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 4 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | public function run() |
||
| 84 | { |
||
| 85 | $explode = explode(" ", $this->message->content); |
||
| 86 | unset($explode[0]); |
||
| 87 | $name = implode(" ", $explode); |
||
| 88 | |||
| 89 | $url = "https://evedata.xyz/api/search/corporation/" . urlencode($name) . "/"; |
||
| 90 | $data = @json_decode($this->curl->get($url), true)["corporation"]; |
||
| 91 | if (empty($data)) { |
||
| 92 | return $this->message->reply("**Error:** no results was returned."); |
||
| 93 | } |
||
| 94 | |||
| 95 | if (count($data) > 1) { |
||
| 96 | $results = array(); |
||
| 97 | foreach ($data as $corp) { |
||
| 98 | $results[] = $corp["corporationName"]; |
||
| 99 | } |
||
| 100 | return $this->message->reply("**Error:** more than one result was returned: " . implode(", ", $results)); |
||
| 101 | } |
||
| 102 | |||
| 103 | // Get stats |
||
| 104 | $corporationID = $data[0]["corporationID"]; |
||
| 105 | $statsURL = "https://beta.eve-kill.net/api/corpInfo/corporationID/" . urlencode($corporationID) . "/"; |
||
| 106 | $stats = json_decode($this->curl->get($statsURL), true); |
||
| 107 | if (empty($stats)) { |
||
| 108 | return $this->message->reply("**Error:** no data available"); |
||
| 109 | } |
||
| 110 | |||
| 111 | $corporationName = @$stats["corporationName"]; |
||
| 112 | $allianceName = isset($stats["allianceName"]) ? $stats["allianceName"] : "None"; |
||
| 113 | $factionName = isset($stats["factionName"]) ? $stats["factionName"] : "None"; |
||
| 114 | $ceoName = @$stats["ceoName"]; |
||
| 115 | $homeStation = @$stats["stationName"]; |
||
| 116 | $taxRate = @$stats["taxRate"]; |
||
| 117 | $corporationActiveArea = @$stats["corporationActiveArea"]; |
||
| 118 | $allianceActiveArea = @$stats["allianceActiveArea"]; |
||
| 119 | $lifeTimeKills = @$stats["lifeTimeKills"]; |
||
| 120 | $lifeTimeLosses = @$stats["lifeTimeLosses"]; |
||
| 121 | $memberCount = @$stats["memberArrayCount"]; |
||
| 122 | $superCaps = @count($stats["superCaps"]); |
||
| 123 | $ePeenSize = @$stats["ePeenSize"]; |
||
| 124 | $url = "https://beta.eve-kill.net/corporation/" . @$stats["corporationID"] . "/"; |
||
| 125 | $msg = "```corporationName: {$corporationName} |
||
| 126 | allianceName: {$allianceName} |
||
| 127 | factionName: {$factionName} |
||
| 128 | ceoName: {$ceoName} |
||
| 129 | homeStation: {$homeStation} |
||
| 130 | taxRate: {$taxRate} |
||
| 131 | corporationActiveArea: {$corporationActiveArea} |
||
| 132 | allianceActiveArea: {$allianceActiveArea} |
||
| 133 | lifeTimeKills: {$lifeTimeKills} |
||
| 134 | lifeTimeLosses: {$lifeTimeLosses} |
||
| 135 | memberCount: {$memberCount} |
||
| 136 | superCaps: {$superCaps} |
||
| 137 | ePeenSize: {$ePeenSize} |
||
| 138 | ``` |
||
| 139 | For more info, visit: $url"; |
||
| 140 | |||
| 141 | $this->message->reply($msg); |
||
| 142 | |||
| 143 | // Mark this as garbage |
||
| 144 | $this->isGarbage(); |
||
| 145 | } |
||
| 146 | } |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: