user - Code Metrics - sovereignbot/citadel - Measure and Improve Code Quality continuously with Scrutinizer

user A
last analyzed 2016-06-02 11:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	94
Duplicated Lines	15.96 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
c	4
b	2
f	0
dl	15
loc	94
rs	10
wmc	7
lcom	1
cbo	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	15	15	1
B	run()	0	26	6

How to fix Duplicated Code

<?php

namespace Sovereign\Plugins\onMessage;

use Discord\Discord;
use Discord\Parts\Channel\Message;
use Monolog\Logger;
use Sovereign\Lib\Config;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Sovereign\Lib\cURL;
use Sovereign\Lib\Db;
use Sovereign\Lib\Permissions;
use Sovereign\Lib\ServerConfig;
use Sovereign\Lib\Settings;
use Sovereign\Lib\Users;

class user extends \Threaded implements \Collectable
{
    /**
     * @var Message
     */
    private $message;
    /**
     * @var Discord
     */
    private $discord;
    /**
     * @var Logger
     */
    private $log;
    /**
     * @var array
     */
    private $channelConfig;
    /**
     * @var Config
     */
    private $config;
    /**
     * @var Db
     */
    private $db;
    /**
     * @var cURL
     */
    private $curl;
    /**
     * @var Settings
     */
    private $settings;
    /**
     * @var Permissions
     */
    private $permissions;
    /**
     * @var ServerConfig
     */
    private $serverConfig;
    /**
     * @var Users
     */
    private $users;
    /**
     * @var array
     */
    private $extras;

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)

    {
        $this->message = $message;
        $this->discord = $discord;
        $this->channelConfig = $channelConfig;
        $this->log = $log;
        $this->config = $config;
        $this->db = $db;
        $this->curl = $curl;
        $this->settings = $settings;
        $this->permissions = $permissions;
        $this->serverConfig = $serverConfig;
        $this->users = $users;
        $this->extras = $extras;
    }

    public function run()
    {
        $explode = explode(" ", $this->message->content);
        unset($explode[0]);
        $name = implode(" ", $explode);
        $name = stristr($name, "@") ? str_replace("<@", "", str_replace(">", "", $name)) : $name;

        if ($name) {
            $data = $this->db->queryRow("SELECT * FROM users WHERE (nickName = :name OR discordID = :name)", array(":name" => $name));
            if ($data) {

                // Is the person admin?
                $isAdmin = "no";
                foreach ($this->config->get("admins", "permissions") as $admins) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    $isAdmin = $admins == $data["discordID"] ? "yes" : "no";
                }

                $msg = "```ID: {$data["discordID"]}\nName: {$data["nickName"]}\nAdmin: {$isAdmin}\nLast Seen: {$data["lastSeen"]}\nLast Spoken: {$data["lastSpoke"]}\nLast Status: {$data["lastStatus"]}\nPlayed Last: {$data["game"]}```";
                $this->message->reply($msg);
            } else {
                $this->message->reply("Error, no such user has been seen..");
            }
        }

        // Mark this as garbage
        $this->isGarbage();
    }
}

1		<?php
2
3		namespace Sovereign\Plugins\onMessage;
4
5		use Discord\Discord;
6		use Discord\Parts\Channel\Message;
7		use Monolog\Logger;
8		use Sovereign\Lib\Config;
		0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Sovereign\Plugins\onMessage\Config`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9		use Sovereign\Lib\cURL;
10		use Sovereign\Lib\Db;
11		use Sovereign\Lib\Permissions;
12		use Sovereign\Lib\ServerConfig;
13		use Sovereign\Lib\Settings;
14		use Sovereign\Lib\Users;
15
16		class user extends \Threaded implements \Collectable
17		{
18		/**
19		* @var Message
20		*/
21		private $message;
22		/**
23		* @var Discord
24		*/
25		private $discord;
26		/**
27		* @var Logger
28		*/
29		private $log;
30		/**
31		* @var array
32		*/
33		private $channelConfig;
34		/**
35		* @var Config
36		*/
37		private $config;
38		/**
39		* @var Db
40		*/
41		private $db;
42		/**
43		* @var cURL
44		*/
45		private $curl;
46		/**
47		* @var Settings
48		*/
49		private $settings;
50		/**
51		* @var Permissions
52		*/
53		private $permissions;
54		/**
55		* @var ServerConfig
56		*/
57		private $serverConfig;
58		/**
59		* @var Users
60		*/
61		private $users;
62		/**
63		* @var array
64		*/
65		private $extras;
66
67	View Code Duplication	public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
		0 ignored issues – show Duplication introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		$this->message = $message;
70		$this->discord = $discord;
71		$this->channelConfig = $channelConfig;
72		$this->log = $log;
73		$this->config = $config;
74		$this->db = $db;
75		$this->curl = $curl;
76		$this->settings = $settings;
77		$this->permissions = $permissions;
78		$this->serverConfig = $serverConfig;
79		$this->users = $users;
80		$this->extras = $extras;
81		}
82
83		public function run()
84		{
85		$explode = explode(" ", $this->message->content);
86		unset($explode[0]);
87		$name = implode(" ", $explode);
88		$name = stristr($name, "@") ? str_replace("<@", "", str_replace(">", "", $name)) : $name;
89
90		if ($name) {
91		$data = $this->db->queryRow("SELECT * FROM users WHERE (nickName = :name OR discordID = :name)", array(":name" => $name));
92		if ($data) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report The expression `$data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
93		// Is the person admin?
94		$isAdmin = "no";
95		foreach ($this->config->get("admins", "permissions") as $admins) {
		0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report The expression `$this->config->get('admins', 'permissions')` of type `null\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
96		$isAdmin = $admins == $data["discordID"] ? "yes" : "no";
97		}
98
99		$msg = "```ID: {$data["discordID"]}\nName: {$data["nickName"]}\nAdmin: {$isAdmin}\nLast Seen: {$data["lastSeen"]}\nLast Spoken: {$data["lastSpoke"]}\nLast Status: {$data["lastStatus"]}\nPlayed Last: {$data["game"]}```";
100		$this->message->reply($msg);
101		} else {
102		$this->message->reply("Error, no such user has been seen..");
103		}
104		}
105
106		// Mark this as garbage
107		$this->isGarbage();
108		}
109		}

sovereignbot / citadel

user A last analyzed 2016-06-02 11:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

user A
last analyzed 2016-06-02 11:44 UTC