GeoService::getTopArtists() - Code Metrics - Inspection of "Sending commits for first release" - sourceout/lastfm-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

by Pulkit

created 2018-07-02 20:19 UTC

GeoService::getTopArtists() A

↳ Parent: GeoService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
ccs	5
cts	5
cp	1
rs	9.9332
cc	1
nc	1
nop	3
crap	1

<?php
namespace Sourceout\LastFm\Services;

class GeoService extends AbstractService
{
    /**
     * Get the most popular artists by country
     *
     * @param string $country
     * @param integer $page
     * @param integer $limit
     */
    public function getTopArtists(
        string $country,
        int $page = 1,
        int $limit = 50
    )
    {

        return $this->provider
            ->getResource($this->http)
            ->geo()
            ->getTopArtists($country, $page, $limit);
    }

    /**
     * Get the most popular tracks by country
     *
     * @param string $country
     * @param string $location
     * @param integer $limit
     * @param integer $page
     * @return \Tightenco\Collect\Support\Collection
     */
    public function getTopTracks(
        string $country,
        string $location = null,
        int $limit = 50,
        int $page = 1
    ) {
        return $this->provider
            ->getResource($this->http)
            ->geo()
            ->getTopTracks($country, $location, $limit, $page);
    }
}

1		<?php
2		namespace Sourceout\LastFm\Services;
3
4		class GeoService extends AbstractService
5		{
6		/**
7		* Get the most popular artists by country
8		*
9		* @param string $country
10		* @param integer $page
11		* @param integer $limit
12		*/
13	1	public function getTopArtists(
14		string $country,
15		int $page = 1,
16		int $limit = 50
17		)
18		{
		0 ignored issues – show Coding Style introduced 2018-06-29 16:17 UTC by Report Bug Copy Issue Report The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Loading history...
19	1	return $this->provider
20	1	->getResource($this->http)
21	1	->geo()
22	1	->getTopArtists($country, $page, $limit);
23		}
24
25		/**
26		* Get the most popular tracks by country
27		*
28		* @param string $country
29		* @param string $location
30		* @param integer $limit
31		* @param integer $page
32		* @return \Tightenco\Collect\Support\Collection
33		*/
34	1	public function getTopTracks(
35		string $country,
36		string $location = null,
37		int $limit = 50,
38		int $page = 1
39		) {
40	1	return $this->provider
41	1	->getResource($this->http)
42	1	->geo()
43	1	->getTopTracks($country, $location, $limit, $page);
44		}
45		}

sourceout / lastfm-php-sdk

Pull Request — master (#5)

GeoService::getTopArtists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like