SQL::find() - Code Metrics - Inspection of "find method refined" - soupmix/sql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32f78f...b3dc95 )

by Mehmet

created 2016-06-27 08:12 UTC

SQL::find() C

↳ Parent: SQL

Complexity

Conditions	15
Paths	12

Size

Total Lines	69
Code Lines	52

Duplication

Lines	22
Ratio	31.88 %

Code Coverage

Tests	45
CRAP Score	19.0604

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	22
loc	69
ccs	45
cts	61
cp	0.7377
rs	5.6693
cc	15
eloc	52
nc	12
nop	7
crap	19.0604

How to fix Long Method Complexity

<?php

namespace Soupmix;
/*
SQL Adapter
*/

use Doctrine\DBAL\DriverManager;

class SQL implements Base
{
    public $conn = null;
    private $defaults = [
        'db_name'   => 'default',
        'user_name' => '',
        'password'  => '',
        'host'      => '127.0.0.1',
        'port'      => 3306,
        'charset'   => 'utf8',
        'driver'    => 'pdo_mysql',
    ];

    public function __construct($config)
    {
        $config = array_merge($this->defaults, $config);
        $this->connect($config);
    }

    public function connect($config)
    {
        $connectionParams = array(
            'dbname' => $config['db_name'],
            'user' => $config['user_name'],
            'password' => $config['password'],
            'host' => $config['host'],
            'port' => $config['port'],
            'charset' => $config['charset'],
            'driver' => $config['driver'],
        );
        $this->conn = DriverManager::getConnection($connectionParams);
    }

    public function create($collection)
    {
    }

    public function drop($collection)
    {

    }

    public function truncate($collection)
    {
    }

    public function createIndexes($collection, $indexes)
    {
    }

    public function insert($collection, $values)
    {
        $insertion = $this->conn->insert($collection, $values);
        if($insertion !== 0) {
            return $this->conn->lastInsertId();
        }
        return null;
    }

    public function update($collection, $filter, $values)
    {
        return $this->conn->update($collection, $values, $filter);
    }

    public function delete($collection, $filter)
    {
        $numberOfDeletedItems = $this->conn->delete($collection, $filter);
        if ($numberOfDeletedItems>0) {
            return 1;
        }
        return 0;
    }

    public function get($collection, $docId)
    {
        return $this->conn->fetchAssoc('SELECT * FROM '.$collection.' WHERE id = ?', array($docId));
    }

    public function find($collection, $filters, $fields = null, $sort = null, $start = 0, $limit = 25, $debug = false)
    {
        $result = null;
        $queryBuilder = $this->conn->createQueryBuilder();
        $queryBuilder->from($collection);
        if ($filters !== null) {
            foreach ($filters as $key => $value) {
                 if (strpos($key, '__') === false && is_array($value)) {
                    foreach ($value as $orValue) {
                        $subKey = array_keys($orValue)[0];
                        $subValue = $orValue[$subKey];
                        if (strpos($subKey, '__')!==false) {
                            $sqlOptions = self::buildFilter([$subKey=>$subValue]);
                            if(in_array($sqlOptions['method'], ['in','notIn',''])){

                                $queryBuilder->orWhere(
                                    $queryBuilder->expr()->{$sqlOptions['method']}( $sqlOptions['key'], $sqlOptions['value'])
                                );
                            }
                            else{
                                $queryBuilder->orWhere(
                                    $sqlOptions['key']
                                    . ' ' . $sqlOptions['operand']
                                    . ' ' . $queryBuilder->createNamedParameter($sqlOptions['value']));
                            }
                        } else {
                            $queryBuilder->orWhere($subKey . '=' . $queryBuilder->createNamedParameter($subValue));
                        }
                    }
                } else {
                    $sqlOptions = self::buildFilter([$key=>$value]);
                    if(in_array($sqlOptions['method'], ['in', 'notIn', ''])){

                        $queryBuilder->andWhere(
                            $queryBuilder->expr()->{$sqlOptions['method']}( $sqlOptions['key'], $sqlOptions['value'])
                        );
                    }
                    else{
                        $queryBuilder->andWhere(
                            $sqlOptions['key']
                            . ' ' . $sqlOptions['operand']
                            . ' ' . $queryBuilder->createNamedParameter($sqlOptions['value']));
                    }
                }
            }
        }
        if ($sort !== null) {
            $params['sort'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            foreach ($sort as $sort_key => $sort_dir) {
                if ($params['sort']!='') {
                    $params['sort'] .= ',';
                }
                $queryBuilder->addOrderBy($sort_key, $sort_dir);
            }
        }
        $queryBuilderCount = clone $queryBuilder;
        $queryBuilderCount->select(" COUNT(*) AS total ");
        $stmt = $this->conn->executeQuery($queryBuilderCount->getSql(), $queryBuilderCount->getParameters());
        $count = $stmt->fetchAll(\PDO::FETCH_ASSOC);
        $numberOfSet = 0;
        if (isset($count[0]['total']) && ($count[0]['total']>0)) {
            $numberOfSet = $count[0]['total'];
            $fields = ($fields === null) ? "*" : $fields;
            $queryBuilder->select($fields)
                ->setFirstResult($start)
                ->setMaxResults($limit);
            $stmt = $this->conn->executeQuery($queryBuilder->getSql(), $queryBuilder->getParameters());
            $result = $stmt->fetchAll(\PDO::FETCH_ASSOC);
        }
        return ['total' => $numberOfSet, 'data' => $result];
    }

    public function query($query)
    {
        // reserved
    }

    public static function buildFilter($filter)
    {
        $key = array_keys($filter)[0];
        $value = $filter[$key];
        $operator = ' = ';
        $method = 'eq';

        $methods = [
            'gte'   => 'gte',
            'gt'    => 'gt',
            'lte'   => 'lte',
            'lt'    => 'lt',
            'in'    => 'in',
            '!in'   => 'notIn',
            'not'   => 'not',
            'wildchard' => 'like',
            'prefix' => 'like',
        ];
        $operands = [
            'gte'   => ' >= ',
            'gt'    => ' > ',
            'lte'   => ' <= ',
            'lt'    => ' < ',
            'in'    => ' IN ',
            '!in'   => ' NOT IN',
            'not'   => ' NOT',
            'wildchard' => ' LIKE ',
            'prefix' => ' LIKE ',
        ];

        if (strpos($key, '__')!==false) {
            preg_match('/__(.*?)$/i', $key, $matches);
            $key        = str_replace($matches[0], '', $key);
            $operator   = $matches[1];
            $method     = $methods[$operator];
            $operator   = $operands[$operator];
            switch ($operator) {
                case 'wildcard':
                    $value = str_replace(array('?', '*'), array('_', '%'), $value);
                    break;
                case 'prefix':
                    $value = $value.'%';
                    break;
            }
        }
        return [
            'key'       => $key,
            'operand'   => $operator,
            'method'    => $method,
            'value'     => $value
        ];

    }


}


1			<?php
2
3			namespace Soupmix;
4			/*
5			SQL Adapter
6			*/
7
8			use Doctrine\DBAL\DriverManager;
9
10			class SQL implements Base
11			{
12			public $conn = null;
13			private $defaults = [
14			'db_name' => 'default',
15			'user_name' => '',
16			'password' => '',
17			'host' => '127.0.0.1',
18			'port' => 3306,
19			'charset' => 'utf8',
20			'driver' => 'pdo_mysql',
21			];
22
23	2		public function __construct($config)
24			{
25	2		$config = array_merge($this->defaults, $config);
26	2		$this->connect($config);
27	2		}
28
29	2		public function connect($config)
30			{
31			$connectionParams = array(
32	2		'dbname' => $config['db_name'],
33	2		'user' => $config['user_name'],
34	2		'password' => $config['password'],
35	2		'host' => $config['host'],
36	2		'port' => $config['port'],
37	2		'charset' => $config['charset'],
38	2		'driver' => $config['driver'],
39	2		);
40	2		$this->conn = DriverManager::getConnection($connectionParams);
41	2		}
42
43			public function create($collection)
44			{
45			}
46
47			public function drop($collection)
48			{
49
50			}
51
52			public function truncate($collection)
53			{
54			}
55
56			public function createIndexes($collection, $indexes)
57			{
58			}
59
60	2		public function insert($collection, $values)
61			{
62	2		$insertion = $this->conn->insert($collection, $values);
63	2		if($insertion !== 0) {
64	2		return $this->conn->lastInsertId();
65			}
66			return null;
67			}
68
69			public function update($collection, $filter, $values)
70			{
71			return $this->conn->update($collection, $values, $filter);
72			}
73
74	2		public function delete($collection, $filter)
75			{
76	2		$numberOfDeletedItems = $this->conn->delete($collection, $filter);
77	2		if ($numberOfDeletedItems>0) {
78	2		return 1;
79			}
80			return 0;
81			}
82
83	1		public function get($collection, $docId)
84			{
85	1		return $this->conn->fetchAssoc('SELECT * FROM '.$collection.' WHERE id = ?', array($docId));
86			}
87
88	2		public function find($collection, $filters, $fields = null, $sort = null, $start = 0, $limit = 25, $debug = false)
89			{
90	1		$result = null;
91	1		$queryBuilder = $this->conn->createQueryBuilder();
92	1		$queryBuilder->from($collection);
93	1		if ($filters !== null) {
94	1		foreach ($filters as $key => $value) {
95	1		if (strpos($key, '__') === false && is_array($value)) {
96	1		foreach ($value as $orValue) {
97	1		$subKey = array_keys($orValue)[0];
98	1		$subValue = $orValue[$subKey];
99	1		if (strpos($subKey, '__')!==false) {
100	1		$sqlOptions = self::buildFilter([$subKey=>$subValue]);
101	1	View Code Duplication	if(in_array($sqlOptions['method'], ['in','notIn',''])){
			0 ignored issues – show Duplication introduced 2016-06-27 08:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102			$queryBuilder->orWhere(
103			$queryBuilder->expr()->{$sqlOptions['method']}( $sqlOptions['key'], $sqlOptions['value'])
104			);
105			}
106			else{
107	1		$queryBuilder->orWhere(
108	1		$sqlOptions['key']
109	1		. ' ' . $sqlOptions['operand']
110	1		. ' ' . $queryBuilder->createNamedParameter($sqlOptions['value']));
111			}
112	1		} else {
113			$queryBuilder->orWhere($subKey . '=' . $queryBuilder->createNamedParameter($subValue));
114			}
115	1		}
116	1		} else {
117	1		$sqlOptions = self::buildFilter([$key=>$value]);
118	1	View Code Duplication	if(in_array($sqlOptions['method'], ['in', 'notIn', ''])){
			0 ignored issues – show Duplication introduced 2016-06-27 07:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119			$queryBuilder->andWhere(
120			$queryBuilder->expr()->{$sqlOptions['method']}( $sqlOptions['key'], $sqlOptions['value'])
121			);
122			}
123			else{
124	1		$queryBuilder->andWhere(
125	1		$sqlOptions['key']
126	1		. ' ' . $sqlOptions['operand']
127	1		. ' ' . $queryBuilder->createNamedParameter($sqlOptions['value']));
128			}
129			}
130	1		}
131	1		}
132	1		if ($sort !== null) {
133			$params['sort'] = '';
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-23 17:43 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
134			foreach ($sort as $sort_key => $sort_dir) {
135			if ($params['sort']!='') {
136			$params['sort'] .= ',';
137			}
138	1		$queryBuilder->addOrderBy($sort_key, $sort_dir);
139			}
140			}
141	2		$queryBuilderCount = clone $queryBuilder;
142	1		$queryBuilderCount->select(" COUNT(*) AS total ");
143	1		$stmt = $this->conn->executeQuery($queryBuilderCount->getSql(), $queryBuilderCount->getParameters());
144	1		$count = $stmt->fetchAll(\PDO::FETCH_ASSOC);
145	1		$numberOfSet = 0;
146	1		if (isset($count[0]['total']) && ($count[0]['total']>0)) {
147	1		$numberOfSet = $count[0]['total'];
148	1		$fields = ($fields === null) ? "*" : $fields;
149	1		$queryBuilder->select($fields)
150	1		->setFirstResult($start)
151	1		->setMaxResults($limit);
152	1		$stmt = $this->conn->executeQuery($queryBuilder->getSql(), $queryBuilder->getParameters());
153	1		$result = $stmt->fetchAll(\PDO::FETCH_ASSOC);
154	1		}
155	1		return ['total' => $numberOfSet, 'data' => $result];
156			}
157
158	1		public function query($query)
159			{
160			// reserved
161	1		}
162
163	2		public static function buildFilter($filter)
164			{
165	1		$key = array_keys($filter)[0];
166	1		$value = $filter[$key];
167	1		$operator = ' = ';
168	1		$method = 'eq';
169
170			$methods = [
171	1		'gte' => 'gte',
172	2		'gt' => 'gt',
173	1		'lte' => 'lte',
174	1		'lt' => 'lt',
175	1		'in' => 'in',
176	1		'!in' => 'notIn',
177	1		'not' => 'not',
178	1		'wildchard' => 'like',
179	1		'prefix' => 'like',
180	1		];
181			$operands = [
182	1		'gte' => ' >= ',
183	1		'gt' => ' > ',
184	1		'lte' => ' <= ',
185	1		'lt' => ' < ',
186	1		'in' => ' IN ',
187	1		'!in' => ' NOT IN',
188	1		'not' => ' NOT',
189	1		'wildchard' => ' LIKE ',
190	1		'prefix' => ' LIKE ',
191	1		];
192
193	1		if (strpos($key, '__')!==false) {
194	1		preg_match('/__(.*?)$/i', $key, $matches);
195	1		$key = str_replace($matches[0], '', $key);
196	1		$operator = $matches[1];
197	1		$method = $methods[$operator];
198	1		$operator = $operands[$operator];
199			switch ($operator) {
200	1		case 'wildcard':
201			$value = str_replace(array('?', '*'), array('_', '%'), $value);
202			break;
203	1		case 'prefix':
204			$value = $value.'%';
205			break;
206			}
207	1		}
208			return [
209	1		'key' => $key,
210	1		'operand' => $operator,
211	1		'method' => $method,
212			'value' => $value
213	1		];
214
215			}
216
217
218			}
219

soupmix / sql

Push — master ( 32f78f...b3dc95 )

SQL::find() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like