Soupmix\Cache\APCUCache

Complexity

Total Complexity

7

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	6	2
A	delete()	0	5	1
A	has()	0	5	1
A	set()	0	8	2
A	clear()	0	3	1

<?php

declare(strict_types=1);

namespace Soupmix\Cache;

use DateInterval;
use DateTime;
use Psr\SimpleCache\CacheInterface;

use function apcu_clear_cache;
use function apcu_delete;
use function apcu_exists;
use function apcu_fetch;
use function apcu_store;
use function time;

class APCUCache extends Common implements CacheInterface
{
    /**
     * {@inheritDoc}
     */
    public function get($key, $default = null)
    {
        $this->checkReservedCharacters($key);
        $value = apcu_fetch($key);

        return $value ?: $default;
    }

    /**
     * {@inheritDoc}
     */
    public function set($key, $value, $ttl = null): bool
    {
        $this->checkReservedCharacters($key);
        if ($ttl instanceof DateInterval) {
            $ttl = (new DateTime('now'))->add($ttl)->getTimeStamp() - time();
        }

        return apcu_store($key, $value, (int) $ttl);

The expression return apcu_store($key, $value, (int)$ttl) could return the type array which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritDoc}
     */
    public function delete($key): bool
    {
        $this->checkReservedCharacters($key);

        return (bool) apcu_delete($key);
    }

    public function clear(): bool
    {
        return apcu_clear_cache();
    }

    /**
     * {@inheritDoc}
     */
    public function has($key)
    {
        $this->checkReservedCharacters($key);

        return apcu_exists($key);

The expression return apcu_exists($key) also could return the type string[] which is incompatible with the return type mandated by Psr\SimpleCache\CacheInterface::has() of boolean.

    }
}