Soupmix\Cache\MemcachedCache

Complexity

Total Complexity

23

Size/Duplication

Total Lines	140
Duplicated Lines	13.57 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

86.27%

Importance

Changes	4
Bugs	0	Features	2

12 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	7	2
A	delete()	0	6	1
A	clear()	0	4	1
A	increment()	0	4	1
A	decrement()	0	4	1
A	__construct()	0	7	3
A	set()	9	9	2
A	getMultiple()	0	8	2
A	setMultiple()	10	10	3
A	deleteMultiple()	0	7	2
A	has()	0	6	1
A	checkReservedCharacters()	0	13	4

<?php

namespace Soupmix\Cache;

use Soupmix\Cache\Exceptions\InvalidArgumentException;
use Psr\SimpleCache\CacheInterface;
use Memcached;

class MemcachedCache implements CacheInterface
{

    const PSR16_RESERVED_CHARACTERS = ['{','}','(',')','/','@',':'];

    public $handler;

    /**
     * Connect to Memcached service
     *
     * @param Memcached $handler Memcached handler object
     *
     */
    public function __construct(Memcached $handler)
    {
        $this->handler = $handler;
        if (defined('Memcached::HAVE_IGBINARY') && extension_loaded('igbinary')) {
            ini_set('memcached.serializer', 'igbinary');
        }
    }

    /**
     * {@inheritDoc}
     */
    public function get($key, $default = null)
    {

        $this->checkReservedCharacters($key);
        $value = $this->handler->get($key);
        return $value ?: $default;
    }

    /**
     * {@inheritDoc}
     */
    public function set($key, $value, $ttl = null)

This method seems to be duplicated in your project.

    {

        $this->checkReservedCharacters($key);
        if ($ttl instanceof DateInterval) {

The class Soupmix\Cache\DateInterval does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $ttl = (new DateTime('now'))->add($ttl)->getTimeStamp() - time();
        }
        return $this->handler->set($key, $value, (int) $ttl);
    }

    /**
     * {@inheritDoc}
     */
    public function delete($key)
    {

        $this->checkReservedCharacters($key);
        return (bool) $this->handler->delete($key);
    }

    /**
     * {@inheritDoc}
     */
    public function clear()
    {
        return $this->handler->flush();
    }

    /**
     * {@inheritDoc}
     */
    public function getMultiple($keys, $default = null)
    {
        $defaults = array_fill(0, count($keys), $default);
        foreach ($keys as $key) {
            $this->checkReservedCharacters($key);
        }
        return array_merge($this->handler->getMulti($keys), $defaults);

The return type of return array_merge($this->handler->getMulti($keys), $defaults); (array) is incompatible with the return type declared by the interface Psr\SimpleCache\CacheInterface::getMultiple of type Psr\SimpleCache\iterable.

    }

    /**
     * {@inheritDoc}
     */
    public function setMultiple($values, $ttl = null)

This method seems to be duplicated in your project.

    {
        foreach ($values as $key => $value) {
            $this->checkReservedCharacters($key);
        }
        if ($ttl instanceof DateInterval) {

The class Soupmix\Cache\DateInterval does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $ttl = (new DateTime('now'))->add($ttl)->getTimeStamp() - time();
        }
        return $this->handler->setMulti($values, (int) $ttl);
    }

    /**
     * {@inheritDoc}
     */
    public function deleteMultiple($keys)
    {
        foreach ($keys as $key) {
            $this->checkReservedCharacters($key);
        }
        return $this->handler->deleteMulti($keys);

The method deleteMulti() does not exist on Memcached. Did you maybe mean delete()?

    }

    /**
     * {@inheritDoc}
     */
    public function increment($key, $step = 1)
    {
        return $this->handler->increment($key, $step);
    }

    /**
     * {@inheritDoc}
     */
    public function decrement($key, $step = 1)
    {
        return $this->handler->decrement($key, $step);
    }

    /**
     * {@inheritDoc}
     */
    public function has($key)
    {
        $this->checkReservedCharacters($key);
        $value = $this->handler->get($key);

$value is not used, you could remove the assignment.

        return Memcached::RES_NOTFOUND !== $this->handler->getResultCode();
    }

    private function checkReservedCharacters($key)
    {
        if (!is_string($key)) {
            $message = sprintf('key %s is not a string.', $key);
            throw new InvalidArgumentException($message);
        }
        foreach (self::PSR16_RESERVED_CHARACTERS as $needle) {
            if (strpos($key, $needle) !== false) {
                $message = sprintf('%s string is not a legal value.', $key);
                throw new InvalidArgumentException($message);
            }
        }
    }
}