sop / x509

lib/X509/Certificate/Extension/SubjectDirectoryAttributesExtension.php

Doc Comments +1 added lines

@@ -23,6 +23,7 @@
 	 *
 	 * @param bool $critical
 	 * @param Attribute ...$attribs One or more Attribute objects
+	 * @param Attribute[] $attribs
 	 */
 	public function __construct($critical, Attribute ...$attribs) {
 		parent::__construct(self::OID_SUBJECT_DIRECTORY_ATTRIBUTES, $critical);

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$attribs = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return Attribute::fromASN1(
 					$el->expectType(Element::TYPE_SEQUENCE));
 			}, Sequence::fromDER($data)->elements());
@@ -47,7 +47,7 @@ 
 			throw new \LogicException("No attributes");
 		}
 		$elements = array_map(
-			function (Attribute $attr) {
+			function(Attribute $attr) {
 				return $attr->toASN1();
 			}, array_values($this->_attributes));
 		return new Sequence(...$elements);

lib/X509/Certificate/Extension/Target/Targets.php

Doc Comments +1 added lines

@@ -24,6 +24,7 @@
 	 * Constructor
 	 *
 	 * @param Target ...$targets
+	 * @param Target[] $targets
 	 */
 	public function __construct(Target ...$targets) {
 		$this->_targets = $targets;

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 	 */
 	public static function fromASN1(Sequence $seq) {
 		$targets = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return Target::fromASN1($el->expectTagged());
 			}, $seq->elements());
 		return new self(...$targets);
@@ -59,7 +59,7 @@ 
 	 */
 	public function toASN1() {
 		$elements = array_map(
-			function (Target $target) {
+			function(Target $target) {
 				return $target->toASN1();
 			}, $this->_targets);
 		return new Sequence(...$elements);

lib/X509/Certificate/Extension/TargetInformationExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 	 * Constructor
 	 *
 	 * @param bool $critical
-	 * @param Targets ...$targets
+	 * @param Targets Targets[]
 	 */
 	public function __construct($critical, Targets ...$targets) {
 		parent::__construct(self::OID_TARGET_INFORMATION, $critical);

Spacing +4 added lines, -4 removed lines

@@ -47,7 +47,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$targets = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return Targets::fromASN1(
 					$el->expectType(Element::TYPE_SEQUENCE));
 			}, Sequence::fromDER($data)->elements());
@@ -77,7 +77,7 @@ 
 	 */
 	public function names() {
 		$targets = array_filter($this->targets(), 
-			function (Target $target) {
+			function(Target $target) {
 				return $target->type() == Target::TYPE_NAME;
 			});
 		return array_values($targets);
@@ -90,7 +90,7 @@ 
 	 */
 	public function groups() {
 		$targets = array_filter($this->targets(), 
-			function (Target $target) {
+			function(Target $target) {
 				return $target->type() == Target::TYPE_GROUP;
 			});
 		return array_values($targets);
@@ -98,7 +98,7 @@ 
 	
 	protected function _valueASN1() {
 		$elements = array_map(
-			function (Targets $targets) {
+			function(Targets $targets) {
 				return $targets->toASN1();
 			}, $this->_targets);
 		return new Sequence(...$elements);

lib/X509/Certificate/Extensions.php

Doc Comments +1 added lines

@@ -40,6 +40,7 @@
 	 * Constructor
 	 *
 	 * @param Extension ...$extensions Extension objects
+	 * @param Extension[] $extensions
 	 */
 	public function __construct(Extension ...$extensions) {
 		$this->_extensions = array();

Spacing +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
 	 */
 	public static function fromASN1(Sequence $seq) {
 		$extensions = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return Extension::fromASN1(
 					$el->expectType(Element::TYPE_SEQUENCE));
 			}, $seq->elements());
@@ -70,7 +70,7 @@ 
 	 */
 	public function toASN1() {
 		$elements = array_values(
-			array_map(function ($ext) {
+			array_map(function($ext) {
 				return $ext->toASN1();
 			}, $this->_extensions));
 		return new Sequence(...$elements);

lib/X509/Certificate/TBSCertificate.php

Doc Comments +2 added lines, -1 removed lines

@@ -356,6 +356,7 @@ 
 	 * Get self with extensions added.
 	 *
 	 * @param Extension ...$exts One or more Extension objects
+	 * @param Extension[] $exts
 	 * @return self
 	 */
 	public function withAdditionalExtensions(Extension ...$exts) {
@@ -397,7 +398,7 @@ 
 	/**
 	 * Get serial number.
 	 *
-	 * @return int|string Base 10 integer
+	 * @return integer Base 10 integer
 	 */
 	public function serialNumber() {
 		if (!$this->hasSerialNumber()) {

lib/X509/CertificationPath/PathValidation/PathValidator.php

Doc Comments +1 added lines

@@ -50,6 +50,7 @@
 	 * @param Crypto $crypto
 	 * @param PathValidationConfig $config
 	 * @param Certificate ...$certificates
+	 * @param Certificate[] $certificates
 	 */
 	public function __construct(Crypto $crypto, PathValidationConfig $config, 
 			Certificate ...$certificates) {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use CryptoUtil\Crypto\Crypto;
 use X509\Certificate\Certificate;
-use X509\Certificate\Extension\Extension;
 use X509\Certificate\TBSCertificate;
 use X509\CertificationPath\Exception\PathValidationException;
 

lib/X509/CertificationRequest/Attributes.php

Doc Comments +2 added lines

@@ -38,6 +38,7 @@ 
 	 * Constructor
 	 *
 	 * @param Attribute ...$attribs Attribute objects
+	 * @param Attribute[] $attribs
 	 */
 	public function __construct(Attribute ...$attribs) {
 		$this->_attributes = $attribs;
@@ -47,6 +48,7 @@ 
 	 * Initialize from attribute values.
 	 *
 	 * @param AttributeValue ...$values
+	 * @param AttributeValue[] $values
 	 * @return self
 	 */
 	public static function fromAttributeValues(AttributeValue ...$values) {

Spacing +4 added lines, -4 removed lines

@@ -51,7 +51,7 @@ 
 	 */
 	public static function fromAttributeValues(AttributeValue ...$values) {
 		$attribs = array_map(
-			function (AttributeValue $value) {
+			function(AttributeValue $value) {
 				return $value->toAttribute();
 			}, $values);
 		return new self(...$attribs);
@@ -65,13 +65,13 @@ 
 	 */
 	public static function fromASN1(Set $set) {
 		$attribs = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return Attribute::fromASN1(
 					$el->expectType(Element::TYPE_SEQUENCE));
 			}, $set->elements());
 		// cast attributes
 		$attribs = array_map(
-			function (Attribute $attr) {
+			function(Attribute $attr) {
 				$oid = $attr->oid();
 				if (array_key_exists($oid, self::MAP_OID_TO_CLASS)) {
 					$cls = self::MAP_OID_TO_CLASS[$oid];
@@ -111,7 +111,7 @@ 
 	 */
 	public function toASN1() {
 		$elements = array_map(
-			function (Attribute $attr) {
+			function(Attribute $attr) {
 				return $attr->toASN1();
 			}, array_values($this->_attributes));
 		$set = new Set(...$elements);

lib/X509/CertificationRequest/CertificationRequestInfo.php

Doc Comments -1 removed lines

@@ -197,7 +197,6 @@
 	 *
 	 * @param Crypto $crypto Crypto engine
 	 * @param SignatureAlgorithmIdentifier $algo Algorithm used for signing
-	 * @param PrivateKey $private_key Private key used for signing
 	 * @return CertificationRequest
 	 */
 	public function sign(Crypto $crypto, SignatureAlgorithmIdentifier $algo, 

lib/X509/GeneralName/GeneralNames.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	 * Constructor
 	 *
 	 * @param GeneralName ...$names One or more GeneralName objects
+	 * @param GeneralName[] $names
 	 */
 	public function __construct(GeneralName ...$names) {
 		$this->_names = $names;

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$names = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return GeneralName::fromASN1($el->expectTagged());
 			}, $seq->elements());
 		return new self(...$names);
@@ -100,7 +100,7 @@ 
 	 */
 	public function allOf($tag) {
 		$names = array_filter($this->_names, 
-			function (GeneralName $name) use ($tag) {
+			function(GeneralName $name) use ($tag) {
 				return $name->tag() == $tag;
 			});
 		return array_values($names);
@@ -144,7 +144,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$elements = array_map(
-			function (GeneralName $name) {
+			function(GeneralName $name) {
 				return $name->toASN1();
 			}, $this->_names);
 		return new Sequence(...$elements);