X509\Certificate\Extension\CertificatePolicy\UserNoticeQualifier

Complexity

Total Complexity

13

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	_qualifierASN1()	0	10	3
A	__construct()	0	6	1
A	hasExplicitText()	0	3	1
A	explicitText()	0	6	2
A	noticeRef()	0	6	2
A	fromQualifierASN1()	0	13	3
A	hasNoticeRef()	0	3	1

<?php

declare(strict_types = 1);

namespace Sop\X509\Certificate\Extension\CertificatePolicy;

use Sop\ASN1\Element;
use Sop\ASN1\Type\Constructed\Sequence;
use Sop\ASN1\Type\UnspecifiedType;

/**
 * Implements <i>UserNotice</i> ASN.1 type used by
 * 'Certificate Policies' certificate extension.
 *
 * @see https://tools.ietf.org/html/rfc5280#section-4.2.1.4
 */
class UserNoticeQualifier extends PolicyQualifierInfo
{
    /**
     * Explicit notice text.
     *
     * @var null|DisplayText
     */
    protected $_text;

    /**
     * Notice reference.
     *
     * @var null|NoticeReference
     */
    protected $_ref;

    /**
     * Constructor.
     *
     * @param null|DisplayText     $text
     * @param null|NoticeReference $ref
     */
    public function __construct(?DisplayText $text = null,
        ?NoticeReference $ref = null)
    {
        $this->_oid = self::OID_UNOTICE;
        $this->_text = $text;
        $this->_ref = $ref;
    }

    /**
     * {@inheritdoc}
     *
     * @return self
     */
    public static function fromQualifierASN1(UnspecifiedType $el): PolicyQualifierInfo
    {
        $seq = $el->asSequence();
        $ref = null;
        $text = null;
        $idx = 0;
        if ($seq->has($idx, Element::TYPE_SEQUENCE)) {
            $ref = NoticeReference::fromASN1($seq->at($idx++)->asSequence());
        }
        if ($seq->has($idx, Element::TYPE_STRING)) {
            $text = DisplayText::fromASN1($seq->at($idx)->asString());
        }
        return new self($text, $ref);
    }

    /**
     * Whether explicit text is present.
     *
     * @return bool
     */
    public function hasExplicitText(): bool
    {
        return isset($this->_text);
    }

    /**
     * Get explicit text.
     *
     * @throws \LogicException If not set
     *
     * @return DisplayText
     */
    public function explicitText(): DisplayText
    {
        if (!$this->hasExplicitText()) {
            throw new \LogicException('explicitText not set.');
        }
        return $this->_text;

The expression return $this->_text could return the type null which is incompatible with the type-hinted return Sop\X509\Certificate\Extension\CertificatePolicy\DisplayText. Consider adding an additional type-check to rule them out.

    }

    /**
     * Whether notice reference is present.
     *
     * @return bool
     */
    public function hasNoticeRef(): bool
    {
        return isset($this->_ref);
    }

    /**
     * Get notice reference.
     *
     * @throws \LogicException If not set
     *
     * @return NoticeReference
     */
    public function noticeRef(): NoticeReference
    {
        if (!$this->hasNoticeRef()) {
            throw new \LogicException('noticeRef not set.');
        }
        return $this->_ref;

The expression return $this->_ref could return the type null which is incompatible with the type-hinted return Sop\X509\Certificate\Extension\CertificatePolicy\NoticeReference. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritdoc}
     */
    protected function _qualifierASN1(): Element
    {
        $elements = [];
        if (isset($this->_ref)) {
            $elements[] = $this->_ref->toASN1();

The method toASN1() does not exist on null.

        }
        if (isset($this->_text)) {
            $elements[] = $this->_text->toASN1();

The method toASN1() does not exist on null.

        }
        return new Sequence(...$elements);
    }
}