X509\AttributeCertificate\Attribute\SvceAuthInfo

Complexity

Total Complexity

14

Size/Duplication

Total Lines	155
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	toASN1()	0	7	2
A	ident()	0	3	1
A	service()	0	3	1
A	equalityMatchingRule()	0	3	1
A	hasAuthInfo()	0	3	1
A	__construct()	0	6	1
A	_transcodedString()	0	3	1
A	authInfo()	0	6	2
A	rfc2253String()	0	3	1
A	fromASN1()	0	10	2
A	stringValue()	0	3	1

<?php

declare(strict_types = 1);

namespace Sop\X509\AttributeCertificate\Attribute;

use Sop\ASN1\Element;
use Sop\ASN1\Type\Constructed\Sequence;
use Sop\ASN1\Type\Primitive\OctetString;
use Sop\ASN1\Type\UnspecifiedType;
use Sop\X501\ASN1\AttributeValue\AttributeValue;
use Sop\X501\MatchingRule\BinaryMatch;
use Sop\X501\MatchingRule\MatchingRule;
use Sop\X509\GeneralName\GeneralName;

/**
 * Base class implementing <i>SvceAuthInfo</i> ASN.1 type used by
 * attribute certificate attribute values.
 *
 * @see https://tools.ietf.org/html/rfc5755#section-4.4.1
 */
abstract class SvceAuthInfo extends AttributeValue
{
    /**
     * Service.
     *
     * @var GeneralName
     */
    protected $_service;

    /**
     * Ident.
     *
     * @var GeneralName
     */
    protected $_ident;

    /**
     * Auth info.
     *
     * @var null|string
     */
    protected $_authInfo;

    /**
     * Constructor.
     *
     * @param GeneralName $service
     * @param GeneralName $ident
     * @param null|string $auth_info
     */
    public function __construct(GeneralName $service, GeneralName $ident,
        ?string $auth_info = null)
    {
        $this->_service = $service;
        $this->_ident = $ident;
        $this->_authInfo = $auth_info;
    }

    /**
     * {@inheritdoc}
     *
     * @return self
     */
    public static function fromASN1(UnspecifiedType $el): AttributeValue
    {
        $seq = $el->asSequence();
        $service = GeneralName::fromASN1($seq->at(0)->asTagged());
        $ident = GeneralName::fromASN1($seq->at(1)->asTagged());
        $auth_info = null;
        if ($seq->has(2, Element::TYPE_OCTET_STRING)) {
            $auth_info = $seq->at(2)->asString()->string();
        }
        return new static($service, $ident, $auth_info);
    }

    /**
     * Get service name.
     *
     * @return GeneralName
     */
    public function service(): GeneralName
    {
        return $this->_service;
    }

    /**
     * Get ident.
     *
     * @return GeneralName
     */
    public function ident(): GeneralName
    {
        return $this->_ident;
    }

    /**
     * Check whether authentication info is present.
     *
     * @return bool
     */
    public function hasAuthInfo(): bool
    {
        return isset($this->_authInfo);
    }

    /**
     * Get authentication info.
     *
     * @throws \LogicException If not set
     *
     * @return string
     */
    public function authInfo(): string
    {
        if (!$this->hasAuthInfo()) {
            throw new \LogicException('authInfo not set.');
        }
        return $this->_authInfo;

The expression return $this->_authInfo could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritdoc}
     */
    public function toASN1(): Element
    {
        $elements = [$this->_service->toASN1(), $this->_ident->toASN1()];
        if (isset($this->_authInfo)) {
            $elements[] = new OctetString($this->_authInfo);

It seems like $this->_authInfo can also be of type null; however, parameter $string of Sop\ASN1\Type\Primitive\OctetString::__construct() does only seem to accept string, maybe add an additional type check?

        }
        return new Sequence(...$elements);
    }

    /**
     * {@inheritdoc}
     */
    public function stringValue(): string
    {
        return '#' . bin2hex($this->toASN1()->toDER());
    }

    /**
     * {@inheritdoc}
     */
    public function equalityMatchingRule(): MatchingRule
    {
        return new BinaryMatch();
    }

    /**
     * {@inheritdoc}
     */
    public function rfc2253String(): string
    {
        return $this->stringValue();
    }

    /**
     * {@inheritdoc}
     */
    protected function _transcodedString(): string
    {
        return $this->stringValue();
    }
}