CRLDistributionPointsExtension::__construct() - Code Metrics - Inspection of "Update to work with development asn1 branch" - sop/x509 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eb5c8e...f4ded9 )

by Joni

created 2016-06-06 10:40 UTC

CRLDistributionPointsExtension::__construct() A

↳ Parent: CRLDistributionPointsExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1.008

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
ccs	4
cts	5
cp	0.8
rs	9.4285
nc	1
cc	1
eloc	4
nop	2
crap	1.008

<?php

namespace X509\Certificate\Extension;

use ASN1\Type\Constructed\Sequence;
use ASN1\Type\UnspecifiedType;
use X509\Certificate\Extension\DistributionPoint\DistributionPoint;


/**
 * Implements 'CRL Distribution Points' certificate extension.
 *
 * @link https://tools.ietf.org/html/rfc5280#section-4.2.1.13
 */
class CRLDistributionPointsExtension extends Extension implements \Countable, 

	\IteratorAggregate

{
	/**
	 * Distribution points.
	 *
	 * @var DistributionPoint[] $_distributionPoints
	 */
	protected $_distributionPoints;
	
	/**
	 * Constructor
	 *
	 * @param bool $critical
	 * @param DistributionPoint ...$distribution_points
	 */
	public function __construct($critical, 
			DistributionPoint ...$distribution_points) {
		parent::__construct(self::OID_CRL_DISTRIBUTION_POINTS, $critical);
		$this->_distributionPoints = $distribution_points;
	}
	
	protected static function _fromDER($data, $critical) {

		$dps = array_map(
			function (UnspecifiedType $el) {
				return DistributionPoint::fromASN1($el->asSequence());
			}, Sequence::fromDER($data)->elements());
		if (!count($dps)) {
			throw new \UnexpectedValueException(
				"CRLDistributionPoints must have" .
					 " at least one DistributionPoint.");
		}
		// late static bound, extended by Freshest CRL extension
		return new static($critical, ...$dps);
	}
	
	protected function _valueASN1() {

		if (!count($this->_distributionPoints)) {
			throw new \LogicException("No distribution points.");
		}
		$elements = array_map(
			function (DistributionPoint $dp) {
				return $dp->toASN1();
			}, $this->_distributionPoints);
		return new Sequence(...$elements);
	}
	
	/**
	 * Get distribution points.
	 *
	 * @return DistributionPoint[]
	 */
	public function distributionPoints() {
		return $this->_distributionPoints;
	}
	
	/**
	 * Get the number of distribution points.
	 *
	 * @see Countable::count()
	 * @return int
	 */
	public function count() {
		return count($this->_distributionPoints);
	}
	
	/**
	 * Get iterator for distribution points.
	 *
	 * @see IteratorAggregate::getIterator()
	 * @return \ArrayIterator
	 */
	public function getIterator() {
		return new \ArrayIterator($this->_distributionPoints);
	}
}


1			<?php
2
3			namespace X509\Certificate\Extension;
4
5			use ASN1\Type\Constructed\Sequence;
6			use ASN1\Type\UnspecifiedType;
7			use X509\Certificate\Extension\DistributionPoint\DistributionPoint;
8
9
10			/**
11			* Implements 'CRL Distribution Points' certificate extension.
12			*
13			* @link https://tools.ietf.org/html/rfc5280#section-4.2.1.13
14			*/
15			class CRLDistributionPointsExtension extends Extension implements \Countable,
			0 ignored issues – show Coding Style introduced 2016-06-01 09:53 UTC by Report Bug Copy Issue Report The first item in a multi-line implements list must be on the line following the implements keyword Loading history...
16			\IteratorAggregate
			0 ignored issues – show Coding Style introduced 2016-06-01 09:53 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 1 found Loading history...
17			{
18			/**
19			* Distribution points.
20			*
21			* @var DistributionPoint[] $_distributionPoints
22			*/
23			protected $_distributionPoints;
24
25			/**
26			* Constructor
27			*
28			* @param bool $critical
29			* @param DistributionPoint ...$distribution_points
30			*/
31	7		public function __construct($critical,
32			DistributionPoint ...$distribution_points) {
33	7		parent::__construct(self::OID_CRL_DISTRIBUTION_POINTS, $critical);
34	7		$this->_distributionPoints = $distribution_points;
35	7		}
36
37	7	View Code Duplication	protected static function _fromDER($data, $critical) {
			0 ignored issues – show Duplication introduced 2016-06-01 09:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38	7		$dps = array_map(
39			function (UnspecifiedType $el) {
40	6		return DistributionPoint::fromASN1($el->asSequence());
41	7		}, Sequence::fromDER($data)->elements());
42	7		if (!count($dps)) {
43	1		throw new \UnexpectedValueException(
44			"CRLDistributionPoints must have" .
45	1		" at least one DistributionPoint.");
46			}
47			// late static bound, extended by Freshest CRL extension
48	6		return new static($critical, ...$dps);
49			}
50
51	4	View Code Duplication	protected function _valueASN1() {
			0 ignored issues – show Duplication introduced 2016-06-01 09:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52	4		if (!count($this->_distributionPoints)) {
53	1		throw new \LogicException("No distribution points.");
54			}
55	3		$elements = array_map(
56	3		function (DistributionPoint $dp) {
57	3		return $dp->toASN1();
58	3		}, $this->_distributionPoints);
59	3		return new Sequence(...$elements);
60			}
61
62			/**
63			* Get distribution points.
64			*
65			* @return DistributionPoint[]
66			*/
67	1		public function distributionPoints() {
68	1		return $this->_distributionPoints;
69			}
70
71			/**
72			* Get the number of distribution points.
73			*
74			* @see Countable::count()
75			* @return int
76			*/
77	1		public function count() {
78	1		return count($this->_distributionPoints);
79			}
80
81			/**
82			* Get iterator for distribution points.
83			*
84			* @see IteratorAggregate::getIterator()
85			* @return \ArrayIterator
86			*/
87	3		public function getIterator() {
88	3		return new \ArrayIterator($this->_distributionPoints);
89			}
90			}
91

sop / x509

GitHub Access Token became invalid

Push — master ( eb5c8e...f4ded9 )

CRLDistributionPointsExtension::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like