sop / x509

examples/create-csr.php

Indentation +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 
 // load EC private key from PEM
 $private_key_info = PrivateKeyInfo::fromPEM(
-    PEM::fromFile(dirname(__DIR__) . '/test/assets/ec/private_key.pem'));
+	PEM::fromFile(dirname(__DIR__) . '/test/assets/ec/private_key.pem'));
 // extract public key from private key
 $public_key_info = $private_key_info->publicKeyInfo();
 // DN of the subject
@@ -27,6 +27,6 @@ 
 $cri = new CertificationRequestInfo($subject, $public_key_info);
 // sign certificate request with private key
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $private_key_info->algorithmIdentifier(), new SHA256AlgorithmIdentifier());
+	$private_key_info->algorithmIdentifier(), new SHA256AlgorithmIdentifier());
 $csr = $cri->sign($algo, $private_key_info);
 echo $csr;

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * php create-csr.php
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Sop\CryptoEncoding\PEM;
 use Sop\CryptoTypes\AlgorithmIdentifier\Hash\SHA256AlgorithmIdentifier;

examples/ac-example.php

Indentation +68 added lines, -68 removed lines

@@ -38,106 +38,106 @@ 
 
 // CA private key
 openssl_pkey_export(
-    openssl_pkey_new(
-        ['private_key_type' => OPENSSL_KEYTYPE_RSA,
-            'private_key_bits' => 2048, ]), $pkey);
+	openssl_pkey_new(
+		['private_key_type' => OPENSSL_KEYTYPE_RSA,
+			'private_key_bits' => 2048, ]), $pkey);
 $ca_private_key = PrivateKeyInfo::fromPEM(PEM::fromString($pkey));
 // Issuer private key
 openssl_pkey_export(
-    openssl_pkey_new(
-        ['private_key_type' => OPENSSL_KEYTYPE_RSA,
-            'private_key_bits' => 2048, ]), $pkey);
+	openssl_pkey_new(
+		['private_key_type' => OPENSSL_KEYTYPE_RSA,
+			'private_key_bits' => 2048, ]), $pkey);
 $issuer_private_key = PrivateKeyInfo::fromPEM(PEM::fromString($pkey));
 // Holder private key
 openssl_pkey_export(
-    openssl_pkey_new(
-        ['private_key_type' => OPENSSL_KEYTYPE_RSA,
-            'private_key_bits' => 2048, ]), $pkey);
+	openssl_pkey_new(
+		['private_key_type' => OPENSSL_KEYTYPE_RSA,
+			'private_key_bits' => 2048, ]), $pkey);
 $holder_private_key = PrivateKeyInfo::fromPEM(PEM::fromString($pkey));
 
 // create trust anchor certificate (self signed)
 $tbs_cert = new TBSCertificate(
-    Name::fromString('cn=CA'),
-    $ca_private_key->publicKeyInfo(),
-    Name::fromString('cn=CA'),
-    Validity::fromStrings('now', 'now + 1 year'));
+	Name::fromString('cn=CA'),
+	$ca_private_key->publicKeyInfo(),
+	Name::fromString('cn=CA'),
+	Validity::fromStrings('now', 'now + 1 year'));
 $tbs_cert = $tbs_cert->withRandomSerialNumber()
-    ->withAdditionalExtensions(
-        new BasicConstraintsExtension(true, true),
-        new SubjectKeyIdentifierExtension(false,
-            $ca_private_key->publicKeyInfo()->keyIdentifier()),
-        new KeyUsageExtension(true,
-            KeyUsageExtension::DIGITAL_SIGNATURE |
-            KeyUsageExtension::KEY_CERT_SIGN));
+	->withAdditionalExtensions(
+		new BasicConstraintsExtension(true, true),
+		new SubjectKeyIdentifierExtension(false,
+			$ca_private_key->publicKeyInfo()->keyIdentifier()),
+		new KeyUsageExtension(true,
+			KeyUsageExtension::DIGITAL_SIGNATURE |
+			KeyUsageExtension::KEY_CERT_SIGN));
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $ca_private_key->algorithmIdentifier(),
-    new SHA256AlgorithmIdentifier());
+	$ca_private_key->algorithmIdentifier(),
+	new SHA256AlgorithmIdentifier());
 $ca_cert = $tbs_cert->sign($algo, $ca_private_key);
 
 // create AC issuer certificate
 $tbs_cert = new TBSCertificate(
-    Name::fromString('cn=Issuer'),
-    $issuer_private_key->publicKeyInfo(),
-    new Name(),
-    Validity::fromStrings('now', 'now + 6 months'));
+	Name::fromString('cn=Issuer'),
+	$issuer_private_key->publicKeyInfo(),
+	new Name(),
+	Validity::fromStrings('now', 'now + 6 months'));
 $tbs_cert = $tbs_cert->withIssuerCertificate($ca_cert)
-    ->withRandomSerialNumber()
-    ->withAdditionalExtensions(
-        // issuer must not be a CA
-        new BasicConstraintsExtension(true, false),
-        new KeyUsageExtension(true,
-            KeyUsageExtension::DIGITAL_SIGNATURE |
-             KeyUsageExtension::KEY_ENCIPHERMENT));
+	->withRandomSerialNumber()
+	->withAdditionalExtensions(
+		// issuer must not be a CA
+		new BasicConstraintsExtension(true, false),
+		new KeyUsageExtension(true,
+			KeyUsageExtension::DIGITAL_SIGNATURE |
+			 KeyUsageExtension::KEY_ENCIPHERMENT));
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $ca_private_key->algorithmIdentifier(),
-    new SHA256AlgorithmIdentifier());
+	$ca_private_key->algorithmIdentifier(),
+	new SHA256AlgorithmIdentifier());
 $issuer_cert = $tbs_cert->sign($algo, $ca_private_key);
 
 // create AC holder certificate
 $tbs_cert = new TBSCertificate(
-    Name::fromString('cn=Holder, gn=John, sn=Doe'),
-    $holder_private_key->publicKeyInfo(),
-    new Name(),
-    Validity::fromStrings('now', 'now + 6 months'));
+	Name::fromString('cn=Holder, gn=John, sn=Doe'),
+	$holder_private_key->publicKeyInfo(),
+	new Name(),
+	Validity::fromStrings('now', 'now + 6 months'));
 $tbs_cert = $tbs_cert->withIssuerCertificate($ca_cert)
-    ->withRandomSerialNumber()
-    ->withAdditionalExtensions(
-        new BasicConstraintsExtension(true, false),
-        new KeyUsageExtension(true,
-            KeyUsageExtension::DIGITAL_SIGNATURE |
-             KeyUsageExtension::KEY_ENCIPHERMENT));
+	->withRandomSerialNumber()
+	->withAdditionalExtensions(
+		new BasicConstraintsExtension(true, false),
+		new KeyUsageExtension(true,
+			KeyUsageExtension::DIGITAL_SIGNATURE |
+			 KeyUsageExtension::KEY_ENCIPHERMENT));
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $ca_private_key->algorithmIdentifier(),
-    new SHA256AlgorithmIdentifier());
+	$ca_private_key->algorithmIdentifier(),
+	new SHA256AlgorithmIdentifier());
 $holder_cert = $tbs_cert->sign($algo, $ca_private_key);
 
 // named authority that grants the attributes
 $authority = new GeneralNames(
-    new UniformResourceIdentifier('uri:trusted_authority'));
+	new UniformResourceIdentifier('uri:trusted_authority'));
 // role attribute
 $attribs = new Attributes(
-    Attribute::fromAttributeValues(
-        RoleAttributeValue::fromString('role-name', $authority)));
+	Attribute::fromAttributeValues(
+		RoleAttributeValue::fromString('role-name', $authority)));
 $aci = new AttributeCertificateInfo(
-    // holder is identified by the holder's public key certificate
-    new Holder(IssuerSerial::fromPKC($holder_cert)),
-    AttCertIssuer::fromPKC($issuer_cert),
-    AttCertValidityPeriod::fromStrings('now - 1 hour', 'now + 3 months'),
-    $attribs);
+	// holder is identified by the holder's public key certificate
+	new Holder(IssuerSerial::fromPKC($holder_cert)),
+	AttCertIssuer::fromPKC($issuer_cert),
+	AttCertValidityPeriod::fromStrings('now - 1 hour', 'now + 3 months'),
+	$attribs);
 $aci = $aci->withRandomSerialNumber()
-    ->withAdditionalExtensions(
-        // named target identifier
-        TargetInformationExtension::fromTargets(
-            new TargetName(
-                new UniformResourceIdentifier('uri:target_identifier'))),
-        // key identifier of the AC issuer
-        new AuthorityKeyIdentifierExtension(false,
-            $issuer_cert->tbsCertificate()
-                ->subjectPublicKeyInfo()
-                ->keyIdentifier()));
+	->withAdditionalExtensions(
+		// named target identifier
+		TargetInformationExtension::fromTargets(
+			new TargetName(
+				new UniformResourceIdentifier('uri:target_identifier'))),
+		// key identifier of the AC issuer
+		new AuthorityKeyIdentifierExtension(false,
+			$issuer_cert->tbsCertificate()
+				->subjectPublicKeyInfo()
+				->keyIdentifier()));
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $issuer_private_key->algorithmIdentifier(),
-    new SHA256AlgorithmIdentifier());
+	$issuer_private_key->algorithmIdentifier(),
+	new SHA256AlgorithmIdentifier());
 $ac = $aci->sign($algo, $issuer_private_key);
 
 // validate AC
@@ -149,7 +149,7 @@ 
 $validator_config = $validator_config->withTargets($target);
 $validator = new ACValidator($ac, $validator_config);
 if ($validator->validate()) {
-    fprintf(STDERR, "AC validation succeeded.\n");
+	fprintf(STDERR, "AC validation succeeded.\n");
 }
 
 fprintf(STDERR, "Root certificate:\n");

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * php ac-example.php
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Sop\CryptoEncoding\PEM;
 use Sop\CryptoTypes\AlgorithmIdentifier\Hash\SHA256AlgorithmIdentifier;

examples/issue-cert.php

Indentation +9 added lines, -9 removed lines

@@ -27,27 +27,27 @@
 $csr = CertificationRequest::fromPEM(PEM::fromFile($argv[2]));
 // verify CSR
 if (!$csr->verify()) {
-    echo "Failed to verify certification request signature.\n";
-    exit(1);
+	echo "Failed to verify certification request signature.\n";
+	exit(1);
 }
 // load CA's private key from PEM
 $private_key_info = PrivateKeyInfo::fromPEM(
-    PEM::fromFile(dirname(__DIR__) . '/test/assets/rsa/private_key.pem'));
+	PEM::fromFile(dirname(__DIR__) . '/test/assets/rsa/private_key.pem'));
 // initialize certificate from CSR and issuer's certificate
 $tbs_cert = TBSCertificate::fromCSR($csr)->withIssuerCertificate($issuer_cert);
 // set random serial number
 $tbs_cert = $tbs_cert->withRandomSerialNumber();
 // set validity period
 $tbs_cert = $tbs_cert->withValidity(
-    Validity::fromStrings('now', 'now + 3 months'));
+	Validity::fromStrings('now', 'now + 3 months'));
 // add extensions
 $tbs_cert = $tbs_cert->withAdditionalExtensions(
-    new KeyUsageExtension(true,
-        KeyUsageExtension::DIGITAL_SIGNATURE |
-             KeyUsageExtension::KEY_ENCIPHERMENT),
-    new BasicConstraintsExtension(true, false));
+	new KeyUsageExtension(true,
+		KeyUsageExtension::DIGITAL_SIGNATURE |
+			 KeyUsageExtension::KEY_ENCIPHERMENT),
+	new BasicConstraintsExtension(true, false));
 // sign certificate with issuer's private key
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $private_key_info->algorithmIdentifier(), new SHA512AlgorithmIdentifier());
+	$private_key_info->algorithmIdentifier(), new SHA512AlgorithmIdentifier());
 $cert = $tbs_cert->sign($algo, $private_key_info);
 echo $cert;

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * php issue-cert.php <(php create-ca-cert.php) <(php create-csr.php)
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Sop\CryptoEncoding\PEM;
 use Sop\CryptoTypes\AlgorithmIdentifier\Hash\SHA512AlgorithmIdentifier;

examples/create-ca-cert.php

Indentation +6 added lines, -6 removed lines

@@ -22,7 +22,7 @@ 
 
 // load RSA private key from PEM
 $private_key_info = PrivateKeyInfo::fromPEM(
-    PEM::fromFile(dirname(__DIR__) . '/test/assets/rsa/private_key.pem'));
+	PEM::fromFile(dirname(__DIR__) . '/test/assets/rsa/private_key.pem'));
 // extract public key from private key
 $public_key_info = $private_key_info->publicKeyInfo();
 // DN of the certification authority
@@ -32,12 +32,12 @@ 
 // create "to be signed" certificate object with extensions
 $tbs_cert = new TBSCertificate($name, $public_key_info, $name, $validity);
 $tbs_cert = $tbs_cert->withRandomSerialNumber()->withAdditionalExtensions(
-    new BasicConstraintsExtension(true, true),
-    new SubjectKeyIdentifierExtension(false, $public_key_info->keyIdentifier()),
-    new KeyUsageExtension(true,
-        KeyUsageExtension::DIGITAL_SIGNATURE | KeyUsageExtension::KEY_CERT_SIGN));
+	new BasicConstraintsExtension(true, true),
+	new SubjectKeyIdentifierExtension(false, $public_key_info->keyIdentifier()),
+	new KeyUsageExtension(true,
+		KeyUsageExtension::DIGITAL_SIGNATURE | KeyUsageExtension::KEY_CERT_SIGN));
 // sign certificate with private key
 $algo = SignatureAlgorithmIdentifierFactory::algoForAsymmetricCrypto(
-    $private_key_info->algorithmIdentifier(), new SHA256AlgorithmIdentifier());
+	$private_key_info->algorithmIdentifier(), new SHA256AlgorithmIdentifier());
 $cert = $tbs_cert->sign($algo, $private_key_info);
 echo $cert;

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * php create-ca-cert.php
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Sop\CryptoEncoding\PEM;
 use Sop\CryptoTypes\AlgorithmIdentifier\Hash\SHA256AlgorithmIdentifier;

lib/X509/Certificate/Extension/AuthorityKeyIdentifierExtension.php

Indentation +181 added lines, -181 removed lines

@@ -20,185 +20,185 @@
  */
 class AuthorityKeyIdentifierExtension extends Extension
 {
-    /**
-     * Key identifier.
-     *
-     * @var null|string
-     */
-    protected $_keyIdentifier;
-
-    /**
-     * Issuer name.
-     *
-     * @var null|GeneralNames
-     */
-    protected $_authorityCertIssuer;
-
-    /**
-     * Issuer serial number as a base 10 integer.
-     *
-     * @var null|string
-     */
-    protected $_authorityCertSerialNumber;
-
-    /**
-     * Constructor.
-     *
-     * @param bool              $critical      Conforming CA's must mark as non-critical (false)
-     * @param null|string       $keyIdentifier Key identifier
-     * @param null|GeneralNames $issuer        Issuer name
-     * @param null|int|string   $serial        Issuer serial number as a base 10 integer
-     */
-    public function __construct(bool $critical, ?string $keyIdentifier,
-        ?GeneralNames $issuer = null, $serial = null)
-    {
-        parent::__construct(self::OID_AUTHORITY_KEY_IDENTIFIER, $critical);
-        $this->_keyIdentifier = $keyIdentifier;
-        $this->_authorityCertIssuer = $issuer;
-        $this->_authorityCertSerialNumber = isset($serial) ? strval($serial) : null;
-    }
-
-    /**
-     * Create from public key info.
-     *
-     * @param PublicKeyInfo $pki
-     *
-     * @return AuthorityKeyIdentifierExtension
-     */
-    public static function fromPublicKeyInfo(PublicKeyInfo $pki): self
-    {
-        return new self(false, $pki->keyIdentifier());
-    }
-
-    /**
-     * Whether key identifier is present.
-     *
-     * @return bool
-     */
-    public function hasKeyIdentifier(): bool
-    {
-        return isset($this->_keyIdentifier);
-    }
-
-    /**
-     * Get key identifier.
-     *
-     * @throws \LogicException If not set
-     *
-     * @return string
-     */
-    public function keyIdentifier(): string
-    {
-        if (!$this->hasKeyIdentifier()) {
-            throw new \LogicException('keyIdentifier not set.');
-        }
-        return $this->_keyIdentifier;
-    }
-
-    /**
-     * Whether issuer is present.
-     *
-     * @return bool
-     */
-    public function hasIssuer(): bool
-    {
-        return isset($this->_authorityCertIssuer);
-    }
-
-    /**
-     * Get issuer.
-     *
-     * @throws \LogicException If not set
-     *
-     * @return GeneralNames
-     */
-    public function issuer(): GeneralNames
-    {
-        if (!$this->hasIssuer()) {
-            throw new \LogicException('authorityCertIssuer not set.');
-        }
-        return $this->_authorityCertIssuer;
-    }
-
-    /**
-     * Whether serial is present.
-     *
-     * @return bool
-     */
-    public function hasSerial(): bool
-    {
-        return isset($this->_authorityCertSerialNumber);
-    }
-
-    /**
-     * Get serial number.
-     *
-     * @throws \LogicException If not set
-     *
-     * @return string Base 10 integer string
-     */
-    public function serial(): string
-    {
-        if (!$this->hasSerial()) {
-            throw new \LogicException('authorityCertSerialNumber not set.');
-        }
-        return $this->_authorityCertSerialNumber;
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    protected static function _fromDER(string $data, bool $critical): Extension
-    {
-        $seq = UnspecifiedType::fromDER($data)->asSequence();
-        $keyIdentifier = null;
-        $issuer = null;
-        $serial = null;
-        if ($seq->hasTagged(0)) {
-            $keyIdentifier = $seq->getTagged(0)
-                ->asImplicit(Element::TYPE_OCTET_STRING)
-                ->asOctetString()->string();
-        }
-        if ($seq->hasTagged(1) || $seq->hasTagged(2)) {
-            if (!$seq->hasTagged(1) || !$seq->hasTagged(2)) {
-                throw new \UnexpectedValueException(
-                    'AuthorityKeyIdentifier must have both' .
-                        ' authorityCertIssuer and authorityCertSerialNumber' .
-                        ' present or both absent.');
-            }
-            $issuer = GeneralNames::fromASN1($seq->getTagged(1)
-                ->asImplicit(Element::TYPE_SEQUENCE)->asSequence());
-            $serial = $seq->getTagged(2)->asImplicit(Element::TYPE_INTEGER)
-                ->asInteger()->number();
-        }
-        return new self($critical, $keyIdentifier, $issuer, $serial);
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    protected function _valueASN1(): Element
-    {
-        $elements = [];
-        if (isset($this->_keyIdentifier)) {
-            $elements[] = new ImplicitlyTaggedType(0,
-                new OctetString($this->_keyIdentifier));
-        }
-        // if either issuer or serial is set, both must be set
-        if (isset($this->_authorityCertIssuer) ||
-             isset($this->_authorityCertSerialNumber)) {
-            if (!isset($this->_authorityCertIssuer,
-                $this->_authorityCertSerialNumber)) {
-                throw new \LogicException(
-                    'AuthorityKeyIdentifier must have both' .
-                        ' authorityCertIssuer and authorityCertSerialNumber' .
-                        ' present or both absent.');
-            }
-            $elements[] = new ImplicitlyTaggedType(1,
-                $this->_authorityCertIssuer->toASN1());
-            $elements[] = new ImplicitlyTaggedType(2,
-                new Integer($this->_authorityCertSerialNumber));
-        }
-        return new Sequence(...$elements);
-    }
+	/**
+	 * Key identifier.
+	 *
+	 * @var null|string
+	 */
+	protected $_keyIdentifier;
+
+	/**
+	 * Issuer name.
+	 *
+	 * @var null|GeneralNames
+	 */
+	protected $_authorityCertIssuer;
+
+	/**
+	 * Issuer serial number as a base 10 integer.
+	 *
+	 * @var null|string
+	 */
+	protected $_authorityCertSerialNumber;
+
+	/**
+	 * Constructor.
+	 *
+	 * @param bool              $critical      Conforming CA's must mark as non-critical (false)
+	 * @param null|string       $keyIdentifier Key identifier
+	 * @param null|GeneralNames $issuer        Issuer name
+	 * @param null|int|string   $serial        Issuer serial number as a base 10 integer
+	 */
+	public function __construct(bool $critical, ?string $keyIdentifier,
+		?GeneralNames $issuer = null, $serial = null)
+	{
+		parent::__construct(self::OID_AUTHORITY_KEY_IDENTIFIER, $critical);
+		$this->_keyIdentifier = $keyIdentifier;
+		$this->_authorityCertIssuer = $issuer;
+		$this->_authorityCertSerialNumber = isset($serial) ? strval($serial) : null;
+	}
+
+	/**
+	 * Create from public key info.
+	 *
+	 * @param PublicKeyInfo $pki
+	 *
+	 * @return AuthorityKeyIdentifierExtension
+	 */
+	public static function fromPublicKeyInfo(PublicKeyInfo $pki): self
+	{
+		return new self(false, $pki->keyIdentifier());
+	}
+
+	/**
+	 * Whether key identifier is present.
+	 *
+	 * @return bool
+	 */
+	public function hasKeyIdentifier(): bool
+	{
+		return isset($this->_keyIdentifier);
+	}
+
+	/**
+	 * Get key identifier.
+	 *
+	 * @throws \LogicException If not set
+	 *
+	 * @return string
+	 */
+	public function keyIdentifier(): string
+	{
+		if (!$this->hasKeyIdentifier()) {
+			throw new \LogicException('keyIdentifier not set.');
+		}
+		return $this->_keyIdentifier;
+	}
+
+	/**
+	 * Whether issuer is present.
+	 *
+	 * @return bool
+	 */
+	public function hasIssuer(): bool
+	{
+		return isset($this->_authorityCertIssuer);
+	}
+
+	/**
+	 * Get issuer.
+	 *
+	 * @throws \LogicException If not set
+	 *
+	 * @return GeneralNames
+	 */
+	public function issuer(): GeneralNames
+	{
+		if (!$this->hasIssuer()) {
+			throw new \LogicException('authorityCertIssuer not set.');
+		}
+		return $this->_authorityCertIssuer;
+	}
+
+	/**
+	 * Whether serial is present.
+	 *
+	 * @return bool
+	 */
+	public function hasSerial(): bool
+	{
+		return isset($this->_authorityCertSerialNumber);
+	}
+
+	/**
+	 * Get serial number.
+	 *
+	 * @throws \LogicException If not set
+	 *
+	 * @return string Base 10 integer string
+	 */
+	public function serial(): string
+	{
+		if (!$this->hasSerial()) {
+			throw new \LogicException('authorityCertSerialNumber not set.');
+		}
+		return $this->_authorityCertSerialNumber;
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	protected static function _fromDER(string $data, bool $critical): Extension
+	{
+		$seq = UnspecifiedType::fromDER($data)->asSequence();
+		$keyIdentifier = null;
+		$issuer = null;
+		$serial = null;
+		if ($seq->hasTagged(0)) {
+			$keyIdentifier = $seq->getTagged(0)
+				->asImplicit(Element::TYPE_OCTET_STRING)
+				->asOctetString()->string();
+		}
+		if ($seq->hasTagged(1) || $seq->hasTagged(2)) {
+			if (!$seq->hasTagged(1) || !$seq->hasTagged(2)) {
+				throw new \UnexpectedValueException(
+					'AuthorityKeyIdentifier must have both' .
+						' authorityCertIssuer and authorityCertSerialNumber' .
+						' present or both absent.');
+			}
+			$issuer = GeneralNames::fromASN1($seq->getTagged(1)
+				->asImplicit(Element::TYPE_SEQUENCE)->asSequence());
+			$serial = $seq->getTagged(2)->asImplicit(Element::TYPE_INTEGER)
+				->asInteger()->number();
+		}
+		return new self($critical, $keyIdentifier, $issuer, $serial);
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	protected function _valueASN1(): Element
+	{
+		$elements = [];
+		if (isset($this->_keyIdentifier)) {
+			$elements[] = new ImplicitlyTaggedType(0,
+				new OctetString($this->_keyIdentifier));
+		}
+		// if either issuer or serial is set, both must be set
+		if (isset($this->_authorityCertIssuer) ||
+			 isset($this->_authorityCertSerialNumber)) {
+			if (!isset($this->_authorityCertIssuer,
+				$this->_authorityCertSerialNumber)) {
+				throw new \LogicException(
+					'AuthorityKeyIdentifier must have both' .
+						' authorityCertIssuer and authorityCertSerialNumber' .
+						' present or both absent.');
+			}
+			$elements[] = new ImplicitlyTaggedType(1,
+				$this->_authorityCertIssuer->toASN1());
+			$elements[] = new ImplicitlyTaggedType(2,
+				new Integer($this->_authorityCertSerialNumber));
+		}
+		return new Sequence(...$elements);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X509\Certificate\Extension;
 

lib/X509/CertificationPath/Exception/PathValidationException.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X509\CertificationPath\Exception;