UnknownExtension::fromRawString() - Code Metrics - Inspection of "Add support for extensions with non-DER value" - sop/x509 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 035734...405cf3 )

by Joni

created 2018-11-05 08:24 UTC

UnknownExtension::fromRawString() A

↳ Parent: UnknownExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php
declare(strict_types = 1);

namespace X509\Certificate\Extension;

use ASN1\Element;
use ASN1\Type\Primitive\OctetString;

/**
 * Class to park payload of an unknown extension.
 */
class UnknownExtension extends Extension
{
    /**
     * Decoded extension value.
     *
     * @var Element|null
     */
    protected $_element;
    
    /**
     * Raw extension value.
     *
     * @var string
     */
    protected $_data;
    
    /**
     * Constructor.
     *
     * @param string $oid
     * @param bool $critical
     * @param Element $element
     */
    public function __construct(string $oid, bool $critical, Element $element)
    {
        parent::__construct($oid, $critical);
        $this->_element = $element;
        $this->_data = $element->toDER();
    }
    
    /**
     * Create instance from a raw encoded extension value.
     *
     * @param string $oid
     * @param bool $critical
     * @param string $data
     * @return self
     */
    public static function fromRawString(string $oid, bool $critical,
        string $data): self
    {
        $obj = new self($oid, $critical, new OctetString(''));
        $obj->_element = null;
        $obj->_data = $data;
        return $obj;
    }
    
    /**
     * Get the encoded extension value.
     *
     * @return string
     */
    public function extensionValue(): string
    {
        return $this->_data;
    }
    
    /**
     *
     * {@inheritdoc}
     */
    protected function _extnValue(): OctetString
    {
        return new OctetString($this->_data);
    }
    
    /**
     *
     * {@inheritdoc}
     */
    protected function _valueASN1(): Element
    {
        if (!isset($this->_element)) {
            throw new \RuntimeException('Extension value is not DER encoded.');
        }
        return $this->_element;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace X509\Certificate\Extension;
5
6		use ASN1\Element;
7		use ASN1\Type\Primitive\OctetString;
8
9		/**
10		* Class to park payload of an unknown extension.
11		*/
12		class UnknownExtension extends Extension
13		{
14		/**
15		* Decoded extension value.
16		*
17		* @var Element\|null
18		*/
19		protected $_element;
20
21		/**
22		* Raw extension value.
23		*
24		* @var string
25		*/
26		protected $_data;
27
28		/**
29		* Constructor.
30		*
31		* @param string $oid
32		* @param bool $critical
33		* @param Element $element
34		*/
35	7	public function __construct(string $oid, bool $critical, Element $element)
36		{
37	7	parent::__construct($oid, $critical);
38	7	$this->_element = $element;
39	7	$this->_data = $element->toDER();
40	7	}
41
42		/**
43		* Create instance from a raw encoded extension value.
44		*
45		* @param string $oid
46		* @param bool $critical
47		* @param string $data
48		* @return self
49		*/
50	2	public static function fromRawString(string $oid, bool $critical,
51		string $data): self
52		{
53	2	$obj = new self($oid, $critical, new OctetString(''));
54	2	$obj->_element = null;
55	2	$obj->_data = $data;
56	2	return $obj;
57		}
58
59		/**
60		* Get the encoded extension value.
61		*
62		* @return string
63		*/
64	2	public function extensionValue(): string
65		{
66	2	return $this->_data;
67		}
68
69		/**
70		*
71		* {@inheritdoc}
72		*/
73	2	protected function _extnValue(): OctetString
74		{
75	2	return new OctetString($this->_data);
76		}
77
78		/**
79		*
80		* {@inheritdoc}
81		*/
82	2	protected function _valueASN1(): Element
83		{
84	2	if (!isset($this->_element)) {
85	1	throw new \RuntimeException('Extension value is not DER encoded.');
86		}
87	1	return $this->_element;
88		}
89		}
90

sop / x509

GitHub Access Token became invalid

Push — master ( 035734...405cf3 )

UnknownExtension::fromRawString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like