X509\Certificate\Extension\CRLDistributionPointsExtension

Complexity

Total Complexity

8

Size/Duplication

Total Lines	76
Duplicated Lines	30.26 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	_valueASN1()	10	10	2
A	distributionPoints()	0	3	1
A	count()	0	3	1
A	getIterator()	0	3	1
A	_fromDER()	13	13	2
A	__construct()	0	5	1

<?php

namespace X509\Certificate\Extension;

use ASN1\Type\Constructed\Sequence;
use ASN1\Type\UnspecifiedType;
use X509\Certificate\Extension\DistributionPoint\DistributionPoint;


/**
 * Implements 'CRL Distribution Points' certificate extension.
 *
 * @link https://tools.ietf.org/html/rfc5280#section-4.2.1.13
 */
class CRLDistributionPointsExtension extends Extension implements \Countable, 

The first item in a multi-line implements list must be on the line following the implements keyword

	\IteratorAggregate

Expected 4 spaces before interface name; 1 found

{
	/**
	 * Distribution points.
	 *
	 * @var DistributionPoint[] $_distributionPoints
	 */
	protected $_distributionPoints;
	
	/**
	 * Constructor
	 *
	 * @param bool $critical
	 * @param DistributionPoint ...$distribution_points
	 */
	public function __construct($critical, 
			DistributionPoint ...$distribution_points) {
		parent::__construct(self::OID_CRL_DISTRIBUTION_POINTS, $critical);
		$this->_distributionPoints = $distribution_points;
	}
	
	protected static function _fromDER($data, $critical) {

This method seems to be duplicated in your project.

		$dps = array_map(
			function (UnspecifiedType $el) {
				return DistributionPoint::fromASN1($el->asSequence());
			}, Sequence::fromDER($data)->elements());
		if (!count($dps)) {
			throw new \UnexpectedValueException(
				"CRLDistributionPoints must have" .
					 " at least one DistributionPoint.");
		}
		// late static bound, extended by Freshest CRL extension
		return new static($critical, ...$dps);
	}
	
	protected function _valueASN1() {

This method seems to be duplicated in your project.

		if (!count($this->_distributionPoints)) {
			throw new \LogicException("No distribution points.");
		}
		$elements = array_map(
			function (DistributionPoint $dp) {
				return $dp->toASN1();
			}, $this->_distributionPoints);
		return new Sequence(...$elements);
	}
	
	/**
	 * Get distribution points.
	 *
	 * @return DistributionPoint[]
	 */
	public function distributionPoints() {
		return $this->_distributionPoints;
	}
	
	/**
	 * Get the number of distribution points.
	 *
	 * @see Countable::count()
	 * @return int
	 */
	public function count() {
		return count($this->_distributionPoints);
	}
	
	/**
	 * Get iterator for distribution points.
	 *
	 * @see IteratorAggregate::getIterator()
	 * @return \ArrayIterator
	 */
	public function getIterator() {
		return new \ArrayIterator($this->_distributionPoints);
	}
}