sop / x509

lib/X509/Certificate/CertificateChain.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
 	 */
 	public static function fromPEMs(PEM ...$pems) {
 		$certs = array_map(
-			function (PEM $pem) {
+			function(PEM $pem) {
 				return Certificate::fromPEM($pem);
 			}, $pems);
 		return new self(...$certs);
@@ -106,7 +106,7 @@ 
 	public function toPEMString() {
 		return implode("\n", 
 			array_map(
-				function (Certificate $cert) {
+				function(Certificate $cert) {
 					return $cert->toPEM()->string();
 				}, $this->_certs));
 	}

lib/X509/CertificationPath/PathValidation/PathValidationResult.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 	/**
 	 * Constructor
 	 *
-	 * @param array $certificates
+	 * @param Certificate[] $certificates
 	 * @param PolicyTree|null $policy_tree
 	 * @param PublicKeyInfo $pubkey_info
 	 * @param AlgorithmIdentifierType $algo

lib/X509/CertificationPath/Policy/PolicyTree.php

Doc Comments +3 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
 	 * Calculate policy intersection as specified in Wrap-Up Procedure 6.1.5.g.
 	 *
 	 * @param ValidatorState $state
-	 * @param array $policies
+	 * @param string[] $policies
 	 * @return ValidatorState
 	 */
 	public function calculateIntersection(ValidatorState $state, array $policies) {
@@ -260,7 +260,7 @@ 
 	 * @param Certificate $cert
 	 * @param ValidatorState $state
 	 * @param string $idp OID of the issuer domain policy
-	 * @param array $sdps Array of subject domain policy OIDs
+	 * @param string[] $sdps Array of subject domain policy OIDs
 	 */
 	protected function _applyAnyPolicyMapping(Certificate $cert, 
 			ValidatorState $state, $idp, array $sdps) {
@@ -392,6 +392,7 @@ 
 	 * Gather all children of given nodes to a flattened array.
 	 *
 	 * @param PolicyNode ...$nodes
+	 * @param PolicyNode[] $nodes
 	 * @return PolicyNode[]
 	 */
 	private static function _gatherChildren(PolicyNode ...$nodes) {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use X509\Certificate\Certificate;
 use X509\Certificate\Extension\CertificatePolicy\PolicyInformation;
-use X509\Certificate\Extension\PolicyMappings\PolicyMapping;
 use X509\CertificationPath\PathValidation\ValidatorState;
 
 

Spacing +3 added lines, -3 removed lines

@@ -90,7 +90,7 @@ 
 		// is not in the user-initial-policy-set and is not anyPolicy,
 		// delete this node and all its children.
 		$valid_policy_node_set = array_filter($valid_policy_node_set, 
-			function (PolicyNode $node) use ($policies) {
+			function(PolicyNode $node) use ($policies) {
 				if ($node->isAnyPolicy()) {
 					return true;
 				}
@@ -102,7 +102,7 @@ 
 			});
 		// array of valid policy OIDs
 		$valid_policy_set = array_map(
-			function (PolicyNode $node) {
+			function(PolicyNode $node) {
 				return $node->validPolicy();
 			}, $valid_policy_node_set);
 		// 3. If the valid_policy_tree includes a node of depth n with
@@ -372,7 +372,7 @@ 
 		}
 		// for each node in a tree
 		$this->_root->walkNodes(
-			function (PolicyNode $node) use (&$set) {
+			function(PolicyNode $node) use (&$set) {
 				$parents = $node->parents();
 				// node has parents
 				if (count($parents)) {

lib/X509/Certificate/Extension/PolicyMappingsExtension.php

Spacing +3 added lines, -3 removed lines

@@ -37,7 +37,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$mappings = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return PolicyMapping::fromASN1($el->asSequence());
 			}, Sequence::fromDER($data)->elements());
 		if (!count($mappings)) {
@@ -52,7 +52,7 @@ 
 			throw new \LogicException("No mappings.");
 		}
 		$elements = array_map(
-			function (PolicyMapping $mapping) {
+			function(PolicyMapping $mapping) {
 				return $mapping->toASN1();
 			}, $this->_mappings);
 		return new Sequence(...$elements);
@@ -113,7 +113,7 @@ 
 	 */
 	public function issuerDomainPolicies() {
 		$idps = array_map(
-			function (PolicyMapping $mapping) {
+			function(PolicyMapping $mapping) {
 				return $mapping->issuerDomainPolicy();
 			}, $this->_mappings);
 		return array_values(array_unique($idps));