sop / x501

lib/X501/StringPrep/StringPreparer.php

Indentation +68 added lines, -68 removed lines

@@ -11,77 +11,77 @@
  */
 class StringPreparer
 {
-    const STEP_TRANSCODE = 1;
-    const STEP_MAP = 2;
-    const STEP_NORMALIZE = 3;
-    const STEP_PROHIBIT = 4;
-    const STEP_CHECK_BIDI = 5;
-    const STEP_INSIGNIFICANT_CHARS = 6;
+	const STEP_TRANSCODE = 1;
+	const STEP_MAP = 2;
+	const STEP_NORMALIZE = 3;
+	const STEP_PROHIBIT = 4;
+	const STEP_CHECK_BIDI = 5;
+	const STEP_INSIGNIFICANT_CHARS = 6;
 
-    /**
-     * Preparation steps.
-     *
-     * @var PrepareStep[]
-     */
-    protected $_steps;
+	/**
+	 * Preparation steps.
+	 *
+	 * @var PrepareStep[]
+	 */
+	protected $_steps;
 
-    /**
-     * Constructor.
-     *
-     * @param PrepareStep[] $steps Preparation steps to apply
-     */
-    protected function __construct(array $steps)
-    {
-        $this->_steps = $steps;
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param PrepareStep[] $steps Preparation steps to apply
+	 */
+	protected function __construct(array $steps)
+	{
+		$this->_steps = $steps;
+	}
 
-    /**
-     * Get default instance for given string type.
-     *
-     * @param int $string_type ASN.1 string type tag.
-     *
-     * @return self
-     */
-    public static function forStringType(int $string_type): self
-    {
-        $steps = [
-            self::STEP_TRANSCODE => new TranscodeStep($string_type),
-            self::STEP_MAP => new MapStep(),
-            self::STEP_NORMALIZE => new NormalizeStep(),
-            self::STEP_PROHIBIT => new ProhibitStep(),
-            self::STEP_CHECK_BIDI => new CheckBidiStep(),
-            // @todo Vary by string type
-            self::STEP_INSIGNIFICANT_CHARS => new InsignificantNonSubstringSpaceStep(),
-        ];
-        return new self($steps);
-    }
+	/**
+	 * Get default instance for given string type.
+	 *
+	 * @param int $string_type ASN.1 string type tag.
+	 *
+	 * @return self
+	 */
+	public static function forStringType(int $string_type): self
+	{
+		$steps = [
+			self::STEP_TRANSCODE => new TranscodeStep($string_type),
+			self::STEP_MAP => new MapStep(),
+			self::STEP_NORMALIZE => new NormalizeStep(),
+			self::STEP_PROHIBIT => new ProhibitStep(),
+			self::STEP_CHECK_BIDI => new CheckBidiStep(),
+			// @todo Vary by string type
+			self::STEP_INSIGNIFICANT_CHARS => new InsignificantNonSubstringSpaceStep(),
+		];
+		return new self($steps);
+	}
 
-    /**
-     * Get self with case folding set.
-     *
-     * @param bool $fold True to apply case folding
-     *
-     * @return self
-     */
-    public function withCaseFolding(bool $fold): self
-    {
-        $obj = clone $this;
-        $obj->_steps[self::STEP_MAP] = new MapStep($fold);
-        return $obj;
-    }
+	/**
+	 * Get self with case folding set.
+	 *
+	 * @param bool $fold True to apply case folding
+	 *
+	 * @return self
+	 */
+	public function withCaseFolding(bool $fold): self
+	{
+		$obj = clone $this;
+		$obj->_steps[self::STEP_MAP] = new MapStep($fold);
+		return $obj;
+	}
 
-    /**
-     * Prepare string.
-     *
-     * @param string $string
-     *
-     * @return string
-     */
-    public function prepare(string $string): string
-    {
-        foreach ($this->_steps as $step) {
-            $string = $step->apply($string);
-        }
-        return $string;
-    }
+	/**
+	 * Prepare string.
+	 *
+	 * @param string $string
+	 *
+	 * @return string
+	 */
+	public function prepare(string $string): string
+	{
+		foreach ($this->_steps as $step) {
+			$string = $step->apply($string);
+		}
+		return $string;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\StringPrep;
 

lib/X501/StringPrep/CheckBidiStep.php

Indentation +10 added lines, -10 removed lines

@@ -12,14 +12,14 @@
  */
 class CheckBidiStep implements PrepareStep
 {
-    /**
-     * @param string $string UTF-8 encoded string
-     *
-     * @return string
-     */
-    public function apply(string $string): string
-    {
-        // @todo Implement
-        return $string;
-    }
+	/**
+	 * @param string $string UTF-8 encoded string
+	 *
+	 * @return string
+	 */
+	public function apply(string $string): string
+	{
+		// @todo Implement
+		return $string;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\StringPrep;
 

lib/X501/StringPrep/InsignificantNonSubstringSpaceStep.php

Indentation +18 added lines, -18 removed lines

@@ -14,22 +14,22 @@
  */
 class InsignificantNonSubstringSpaceStep implements PrepareStep
 {
-    /**
-     * @param string $string UTF-8 encoded string
-     *
-     * @return string
-     */
-    public function apply(string $string): string
-    {
-        // if value contains no non-space characters
-        if (preg_match('/^\p{Zs}*$/u', $string)) {
-            return '  ';
-        }
-        // trim leading and trailing spaces
-        $string = preg_replace('/^\p{Zs}+/u', '', $string);
-        $string = preg_replace('/\p{Zs}+$/u', '', $string);
-        // convert inner space sequences to two U+0020 characters
-        $string = preg_replace('/\p{Zs}+/u', '  ', $string);
-        return " {$string} ";
-    }
+	/**
+	 * @param string $string UTF-8 encoded string
+	 *
+	 * @return string
+	 */
+	public function apply(string $string): string
+	{
+		// if value contains no non-space characters
+		if (preg_match('/^\p{Zs}*$/u', $string)) {
+			return '  ';
+		}
+		// trim leading and trailing spaces
+		$string = preg_replace('/^\p{Zs}+/u', '', $string);
+		$string = preg_replace('/\p{Zs}+$/u', '', $string);
+		// convert inner space sequences to two U+0020 characters
+		$string = preg_replace('/\p{Zs}+/u', '  ', $string);
+		return " {$string} ";
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\StringPrep;
 

lib/X501/ASN1/Attribute.php

Indentation +149 added lines, -149 removed lines

@@ -17,163 +17,163 @@
  */
 class Attribute implements \Countable, \IteratorAggregate
 {
-    use TypedAttribute;
+	use TypedAttribute;
 
-    /**
-     * Attribute values.
-     *
-     * @var AttributeValue[]
-     */
-    protected $_values;
+	/**
+	 * Attribute values.
+	 *
+	 * @var AttributeValue[]
+	 */
+	protected $_values;
 
-    /**
-     * Constructor.
-     *
-     * @param AttributeType  $type      Attribute type
-     * @param AttributeValue ...$values Attribute values
-     */
-    public function __construct(AttributeType $type, AttributeValue ...$values)
-    {
-        // check that attribute values have correct oid
-        array_walk($values,
-            function (AttributeValue $value) use ($type) {
-                if ($value->oid() != $type->oid()) {
-                    throw new \LogicException('Attribute OID mismatch.');
-                }
-            });
-        $this->_type = $type;
-        $this->_values = $values;
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param AttributeType  $type      Attribute type
+	 * @param AttributeValue ...$values Attribute values
+	 */
+	public function __construct(AttributeType $type, AttributeValue ...$values)
+	{
+		// check that attribute values have correct oid
+		array_walk($values,
+			function (AttributeValue $value) use ($type) {
+				if ($value->oid() != $type->oid()) {
+					throw new \LogicException('Attribute OID mismatch.');
+				}
+			});
+		$this->_type = $type;
+		$this->_values = $values;
+	}
 
-    /**
-     * Initialize from ASN.1.
-     *
-     * @param Sequence $seq
-     *
-     * @return self
-     */
-    public static function fromASN1(Sequence $seq): self
-    {
-        $type = AttributeType::fromASN1($seq->at(0)->asObjectIdentifier());
-        $values = array_map(
-            function (UnspecifiedType $el) use ($type) {
-                return AttributeValue::fromASN1ByOID($type->oid(), $el);
-            }, $seq->at(1)
-                ->asSet()
-                ->elements());
-        return new self($type, ...$values);
-    }
+	/**
+	 * Initialize from ASN.1.
+	 *
+	 * @param Sequence $seq
+	 *
+	 * @return self
+	 */
+	public static function fromASN1(Sequence $seq): self
+	{
+		$type = AttributeType::fromASN1($seq->at(0)->asObjectIdentifier());
+		$values = array_map(
+			function (UnspecifiedType $el) use ($type) {
+				return AttributeValue::fromASN1ByOID($type->oid(), $el);
+			}, $seq->at(1)
+				->asSet()
+				->elements());
+		return new self($type, ...$values);
+	}
 
-    /**
-     * Convenience method to initialize from attribute values.
-     *
-     * @param AttributeValue ...$values One or more values
-     *
-     * @throws \LogicException
-     *
-     * @return self
-     */
-    public static function fromAttributeValues(AttributeValue ...$values): self
-    {
-        // we need at least one value to determine OID
-        if (!count($values)) {
-            throw new \LogicException('No values.');
-        }
-        $oid = reset($values)->oid();
-        return new self(new AttributeType($oid), ...$values);
-    }
+	/**
+	 * Convenience method to initialize from attribute values.
+	 *
+	 * @param AttributeValue ...$values One or more values
+	 *
+	 * @throws \LogicException
+	 *
+	 * @return self
+	 */
+	public static function fromAttributeValues(AttributeValue ...$values): self
+	{
+		// we need at least one value to determine OID
+		if (!count($values)) {
+			throw new \LogicException('No values.');
+		}
+		$oid = reset($values)->oid();
+		return new self(new AttributeType($oid), ...$values);
+	}
 
-    /**
-     * Get first value of the attribute.
-     *
-     * @throws \LogicException
-     *
-     * @return AttributeValue
-     */
-    public function first(): AttributeValue
-    {
-        if (!count($this->_values)) {
-            throw new \LogicException('Attribute contains no values.');
-        }
-        return $this->_values[0];
-    }
+	/**
+	 * Get first value of the attribute.
+	 *
+	 * @throws \LogicException
+	 *
+	 * @return AttributeValue
+	 */
+	public function first(): AttributeValue
+	{
+		if (!count($this->_values)) {
+			throw new \LogicException('Attribute contains no values.');
+		}
+		return $this->_values[0];
+	}
 
-    /**
-     * Get all values.
-     *
-     * @return AttributeValue[]
-     */
-    public function values(): array
-    {
-        return $this->_values;
-    }
+	/**
+	 * Get all values.
+	 *
+	 * @return AttributeValue[]
+	 */
+	public function values(): array
+	{
+		return $this->_values;
+	}
 
-    /**
-     * Generate ASN.1 structure.
-     *
-     * @return Sequence
-     */
-    public function toASN1(): Sequence
-    {
-        $values = array_map(
-            function (AttributeValue $value) {
-                return $value->toASN1();
-            }, $this->_values);
-        $valueset = new Set(...$values);
-        return new Sequence($this->_type->toASN1(), $valueset->sortedSetOf());
-    }
+	/**
+	 * Generate ASN.1 structure.
+	 *
+	 * @return Sequence
+	 */
+	public function toASN1(): Sequence
+	{
+		$values = array_map(
+			function (AttributeValue $value) {
+				return $value->toASN1();
+			}, $this->_values);
+		$valueset = new Set(...$values);
+		return new Sequence($this->_type->toASN1(), $valueset->sortedSetOf());
+	}
 
-    /**
-     * Cast attribute values to another AttributeValue class.
-     *
-     * This method is generally used to cast UnknownAttributeValue values
-     * to specific objects when class is declared outside this package.
-     *
-     * The new class must be derived from AttributeValue and have the same OID
-     * as current attribute values.
-     *
-     * @param string $cls AttributeValue class name
-     *
-     * @throws \LogicException
-     *
-     * @return self
-     */
-    public function castValues(string $cls): self
-    {
-        $refl = new \ReflectionClass($cls);
-        if (!$refl->isSubclassOf(AttributeValue::class)) {
-            throw new \LogicException(
-                "{$cls} must be derived from " . AttributeValue::class . '.');
-        }
-        $oid = $this->oid();
-        $values = array_map(
-            function (AttributeValue $value) use ($cls, $oid) {
-                $value = $cls::fromSelf($value);
-                if ($value->oid() != $oid) {
-                    throw new \LogicException('Attribute OID mismatch.');
-                }
-                return $value;
-            }, $this->_values);
-        return self::fromAttributeValues(...$values);
-    }
+	/**
+	 * Cast attribute values to another AttributeValue class.
+	 *
+	 * This method is generally used to cast UnknownAttributeValue values
+	 * to specific objects when class is declared outside this package.
+	 *
+	 * The new class must be derived from AttributeValue and have the same OID
+	 * as current attribute values.
+	 *
+	 * @param string $cls AttributeValue class name
+	 *
+	 * @throws \LogicException
+	 *
+	 * @return self
+	 */
+	public function castValues(string $cls): self
+	{
+		$refl = new \ReflectionClass($cls);
+		if (!$refl->isSubclassOf(AttributeValue::class)) {
+			throw new \LogicException(
+				"{$cls} must be derived from " . AttributeValue::class . '.');
+		}
+		$oid = $this->oid();
+		$values = array_map(
+			function (AttributeValue $value) use ($cls, $oid) {
+				$value = $cls::fromSelf($value);
+				if ($value->oid() != $oid) {
+					throw new \LogicException('Attribute OID mismatch.');
+				}
+				return $value;
+			}, $this->_values);
+		return self::fromAttributeValues(...$values);
+	}
 
-    /**
-     * @see \Countable::count()
-     *
-     * @return int
-     */
-    public function count(): int
-    {
-        return count($this->_values);
-    }
+	/**
+	 * @see \Countable::count()
+	 *
+	 * @return int
+	 */
+	public function count(): int
+	{
+		return count($this->_values);
+	}
 
-    /**
-     * @see \IteratorAggregate::getIterator()
-     *
-     * @return \ArrayIterator
-     */
-    public function getIterator(): \ArrayIterator
-    {
-        return new \ArrayIterator($this->_values);
-    }
+	/**
+	 * @see \IteratorAggregate::getIterator()
+	 *
+	 * @return \ArrayIterator
+	 */
+	public function getIterator(): \ArrayIterator
+	{
+		return new \ArrayIterator($this->_values);
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1;
 
@@ -36,7 +36,7 @@ 
     {
         // check that attribute values have correct oid
         array_walk($values,
-            function (AttributeValue $value) use ($type) {
+            function(AttributeValue $value) use ($type) {
                 if ($value->oid() != $type->oid()) {
                     throw new \LogicException('Attribute OID mismatch.');
                 }
@@ -56,7 +56,7 @@ 
     {
         $type = AttributeType::fromASN1($seq->at(0)->asObjectIdentifier());
         $values = array_map(
-            function (UnspecifiedType $el) use ($type) {
+            function(UnspecifiedType $el) use ($type) {
                 return AttributeValue::fromASN1ByOID($type->oid(), $el);
             }, $seq->at(1)
                 ->asSet()
@@ -116,7 +116,7 @@ 
     public function toASN1(): Sequence
     {
         $values = array_map(
-            function (AttributeValue $value) {
+            function(AttributeValue $value) {
                 return $value->toASN1();
             }, $this->_values);
         $valueset = new Set(...$values);
@@ -147,7 +147,7 @@ 
         }
         $oid = $this->oid();
         $values = array_map(
-            function (AttributeValue $value) use ($cls, $oid) {
+            function(AttributeValue $value) use ($cls, $oid) {
                 $value = $cls::fromSelf($value);
                 if ($value->oid() != $oid) {
                     throw new \LogicException('Attribute OID mismatch.');

lib/X501/ASN1/AttributeTypeAndValue.php

Indentation +101 added lines, -101 removed lines

@@ -15,114 +15,114 @@
  */
 class AttributeTypeAndValue
 {
-    use TypedAttribute;
+	use TypedAttribute;
 
-    /**
-     * Attribute value.
-     *
-     * @var AttributeValue
-     */
-    protected $_value;
+	/**
+	 * Attribute value.
+	 *
+	 * @var AttributeValue
+	 */
+	protected $_value;
 
-    /**
-     * Constructor.
-     *
-     * @param AttributeType  $type  Attribute type
-     * @param AttributeValue $value Attribute value
-     */
-    public function __construct(AttributeType $type, AttributeValue $value)
-    {
-        $this->_type = $type;
-        $this->_value = $value;
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param AttributeType  $type  Attribute type
+	 * @param AttributeValue $value Attribute value
+	 */
+	public function __construct(AttributeType $type, AttributeValue $value)
+	{
+		$this->_type = $type;
+		$this->_value = $value;
+	}
 
-    /**
-     * @return string
-     */
-    public function __toString()
-    {
-        return $this->toString();
-    }
+	/**
+	 * @return string
+	 */
+	public function __toString()
+	{
+		return $this->toString();
+	}
 
-    /**
-     * Initialize from ASN.1.
-     *
-     * @param Sequence $seq
-     *
-     * @return self
-     */
-    public static function fromASN1(Sequence $seq): self
-    {
-        $type = AttributeType::fromASN1($seq->at(0)->asObjectIdentifier());
-        $value = AttributeValue::fromASN1ByOID($type->oid(), $seq->at(1));
-        return new self($type, $value);
-    }
+	/**
+	 * Initialize from ASN.1.
+	 *
+	 * @param Sequence $seq
+	 *
+	 * @return self
+	 */
+	public static function fromASN1(Sequence $seq): self
+	{
+		$type = AttributeType::fromASN1($seq->at(0)->asObjectIdentifier());
+		$value = AttributeValue::fromASN1ByOID($type->oid(), $seq->at(1));
+		return new self($type, $value);
+	}
 
-    /**
-     * Convenience method to initialize from attribute value.
-     *
-     * @param AttributeValue $value Attribute value
-     *
-     * @return self
-     */
-    public static function fromAttributeValue(AttributeValue $value): self
-    {
-        return new self(new AttributeType($value->oid()), $value);
-    }
+	/**
+	 * Convenience method to initialize from attribute value.
+	 *
+	 * @param AttributeValue $value Attribute value
+	 *
+	 * @return self
+	 */
+	public static function fromAttributeValue(AttributeValue $value): self
+	{
+		return new self(new AttributeType($value->oid()), $value);
+	}
 
-    /**
-     * Get attribute value.
-     *
-     * @return AttributeValue
-     */
-    public function value(): AttributeValue
-    {
-        return $this->_value;
-    }
+	/**
+	 * Get attribute value.
+	 *
+	 * @return AttributeValue
+	 */
+	public function value(): AttributeValue
+	{
+		return $this->_value;
+	}
 
-    /**
-     * Generate ASN.1 structure.
-     *
-     * @return Sequence
-     */
-    public function toASN1(): Sequence
-    {
-        return new Sequence($this->_type->toASN1(), $this->_value->toASN1());
-    }
+	/**
+	 * Generate ASN.1 structure.
+	 *
+	 * @return Sequence
+	 */
+	public function toASN1(): Sequence
+	{
+		return new Sequence($this->_type->toASN1(), $this->_value->toASN1());
+	}
 
-    /**
-     * Get attributeTypeAndValue string conforming to RFC 2253.
-     *
-     * @see https://tools.ietf.org/html/rfc2253#section-2.3
-     *
-     * @return string
-     */
-    public function toString(): string
-    {
-        return $this->_type->typeName() . '=' . $this->_value->rfc2253String();
-    }
+	/**
+	 * Get attributeTypeAndValue string conforming to RFC 2253.
+	 *
+	 * @see https://tools.ietf.org/html/rfc2253#section-2.3
+	 *
+	 * @return string
+	 */
+	public function toString(): string
+	{
+		return $this->_type->typeName() . '=' . $this->_value->rfc2253String();
+	}
 
-    /**
-     * Check whether attribute is semantically equal to other.
-     *
-     * @param AttributeTypeAndValue $other Object to compare to
-     *
-     * @return bool
-     */
-    public function equals(AttributeTypeAndValue $other): bool
-    {
-        // check that attribute types match
-        if ($this->oid() !== $other->oid()) {
-            return false;
-        }
-        $matcher = $this->_value->equalityMatchingRule();
-        $result = $matcher->compare($this->_value->stringValue(),
-            $other->_value->stringValue());
-        // match
-        if ($result) {
-            return true;
-        }
-        // no match or Undefined
-        return false;
-    }
+	/**
+	 * Check whether attribute is semantically equal to other.
+	 *
+	 * @param AttributeTypeAndValue $other Object to compare to
+	 *
+	 * @return bool
+	 */
+	public function equals(AttributeTypeAndValue $other): bool
+	{
+		// check that attribute types match
+		if ($this->oid() !== $other->oid()) {
+			return false;
+		}
+		$matcher = $this->_value->equalityMatchingRule();
+		$result = $matcher->compare($this->_value->stringValue(),
+			$other->_value->stringValue());
+		// match
+		if ($result) {
+			return true;
+		}
+		// no match or Undefined
+		return false;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1;
 

lib/X501/ASN1/Name.php

Indentation +204 added lines, -204 removed lines

@@ -20,208 +20,208 @@
  */
 class Name implements \Countable, \IteratorAggregate
 {
-    /**
-     * Relative distinguished name components.
-     *
-     * @var RDN[]
-     */
-    protected $_rdns;
-
-    /**
-     * Constructor.
-     *
-     * @param RDN ...$rdns RDN components
-     */
-    public function __construct(RDN ...$rdns)
-    {
-        $this->_rdns = $rdns;
-    }
-
-    /**
-     * @return string
-     */
-    public function __toString()
-    {
-        return $this->toString();
-    }
-
-    /**
-     * Initialize from ASN.1.
-     *
-     * @param Sequence $seq
-     *
-     * @return self
-     */
-    public static function fromASN1(Sequence $seq): self
-    {
-        $rdns = array_map(
-            function (UnspecifiedType $el) {
-                return RDN::fromASN1($el->asSet());
-            }, $seq->elements());
-        return new self(...$rdns);
-    }
-
-    /**
-     * Initialize from distinguished name string.
-     *
-     * @see https://tools.ietf.org/html/rfc1779
-     *
-     * @param string $str
-     *
-     * @return self
-     */
-    public static function fromString(string $str): self
-    {
-        $rdns = [];
-        foreach (DNParser::parseString($str) as $nameComponent) {
-            $attribs = [];
-            foreach ($nameComponent as [$name, $val]) {
-                $type = AttributeType::fromName($name);
-                // hexstrings are parsed to ASN.1 elements
-                if ($val instanceof Element) {
-                    $el = $val;
-                } else {
-                    $el = AttributeType::asn1StringForType($type->oid(), $val);
-                }
-                $value = AttributeValue::fromASN1ByOID($type->oid(),
-                    $el->asUnspecified());
-                $attribs[] = new AttributeTypeAndValue($type, $value);
-            }
-            $rdns[] = new RDN(...$attribs);
-        }
-        return new self(...$rdns);
-    }
-
-    /**
-     * Generate ASN.1 structure.
-     *
-     * @return Sequence
-     */
-    public function toASN1(): Sequence
-    {
-        $elements = array_map(
-            function (RDN $rdn) {
-                return $rdn->toASN1();
-            }, $this->_rdns);
-        return new Sequence(...$elements);
-    }
-
-    /**
-     * Get distinguised name string conforming to RFC 2253.
-     *
-     * @see https://tools.ietf.org/html/rfc2253#section-2.1
-     *
-     * @return string
-     */
-    public function toString(): string
-    {
-        $parts = array_map(
-            function (RDN $rdn) {
-                return $rdn->toString();
-            }, array_reverse($this->_rdns));
-        return implode(',', $parts);
-    }
-
-    /**
-     * Whether name is semantically equal to other.
-     *
-     * Comparison conforms to RFC 4518 string preparation algorithm.
-     *
-     * @see https://tools.ietf.org/html/rfc4518
-     *
-     * @param Name $other Object to compare to
-     *
-     * @return bool
-     */
-    public function equals(Name $other): bool
-    {
-        // if RDN count doesn't match
-        if (count($this) != count($other)) {
-            return false;
-        }
-        for ($i = count($this) - 1; $i >= 0; --$i) {
-            $rdn1 = $this->_rdns[$i];
-            $rdn2 = $other->_rdns[$i];
-            if (!$rdn1->equals($rdn2)) {
-                return false;
-            }
-        }
-        return true;
-    }
-
-    /**
-     * Get all RDN objects.
-     *
-     * @return RDN[]
-     */
-    public function all(): array
-    {
-        return $this->_rdns;
-    }
-
-    /**
-     * Get the first AttributeValue of given type.
-     *
-     * Relative name components shall be traversed in encoding order, which is
-     * reversed in regards to the string representation.
-     * Multi-valued RDN with multiple attributes of the requested type is
-     * ambiguous and shall throw an exception.
-     *
-     * @param string $name Attribute OID or name
-     *
-     * @throws \RuntimeException If attribute cannot be resolved
-     *
-     * @return AttributeValue
-     */
-    public function firstValueOf(string $name): AttributeValue
-    {
-        $oid = AttributeType::attrNameToOID($name);
-        foreach ($this->_rdns as $rdn) {
-            $tvs = $rdn->allOf($oid);
-            if (count($tvs) > 1) {
-                throw new \RangeException("RDN with multiple {$name} attributes.");
-            }
-            if (1 == count($tvs)) {
-                return $tvs[0]->value();
-            }
-        }
-        throw new \RangeException("Attribute {$name} not found.");
-    }
-
-    /**
-     * @see \Countable::count()
-     *
-     * @return int
-     */
-    public function count(): int
-    {
-        return count($this->_rdns);
-    }
-
-    /**
-     * Get the number of attributes of given type.
-     *
-     * @param string $name Attribute OID or name
-     *
-     * @return int
-     */
-    public function countOfType(string $name): int
-    {
-        $oid = AttributeType::attrNameToOID($name);
-        return array_sum(
-            array_map(
-                function (RDN $rdn) use ($oid) {
-                    return count($rdn->allOf($oid));
-                }, $this->_rdns));
-    }
-
-    /**
-     * @see \IteratorAggregate::getIterator()
-     *
-     * @return \ArrayIterator
-     */
-    public function getIterator(): \ArrayIterator
-    {
-        return new \ArrayIterator($this->_rdns);
-    }
+	/**
+	 * Relative distinguished name components.
+	 *
+	 * @var RDN[]
+	 */
+	protected $_rdns;
+
+	/**
+	 * Constructor.
+	 *
+	 * @param RDN ...$rdns RDN components
+	 */
+	public function __construct(RDN ...$rdns)
+	{
+		$this->_rdns = $rdns;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function __toString()
+	{
+		return $this->toString();
+	}
+
+	/**
+	 * Initialize from ASN.1.
+	 *
+	 * @param Sequence $seq
+	 *
+	 * @return self
+	 */
+	public static function fromASN1(Sequence $seq): self
+	{
+		$rdns = array_map(
+			function (UnspecifiedType $el) {
+				return RDN::fromASN1($el->asSet());
+			}, $seq->elements());
+		return new self(...$rdns);
+	}
+
+	/**
+	 * Initialize from distinguished name string.
+	 *
+	 * @see https://tools.ietf.org/html/rfc1779
+	 *
+	 * @param string $str
+	 *
+	 * @return self
+	 */
+	public static function fromString(string $str): self
+	{
+		$rdns = [];
+		foreach (DNParser::parseString($str) as $nameComponent) {
+			$attribs = [];
+			foreach ($nameComponent as [$name, $val]) {
+				$type = AttributeType::fromName($name);
+				// hexstrings are parsed to ASN.1 elements
+				if ($val instanceof Element) {
+					$el = $val;
+				} else {
+					$el = AttributeType::asn1StringForType($type->oid(), $val);
+				}
+				$value = AttributeValue::fromASN1ByOID($type->oid(),
+					$el->asUnspecified());
+				$attribs[] = new AttributeTypeAndValue($type, $value);
+			}
+			$rdns[] = new RDN(...$attribs);
+		}
+		return new self(...$rdns);
+	}
+
+	/**
+	 * Generate ASN.1 structure.
+	 *
+	 * @return Sequence
+	 */
+	public function toASN1(): Sequence
+	{
+		$elements = array_map(
+			function (RDN $rdn) {
+				return $rdn->toASN1();
+			}, $this->_rdns);
+		return new Sequence(...$elements);
+	}
+
+	/**
+	 * Get distinguised name string conforming to RFC 2253.
+	 *
+	 * @see https://tools.ietf.org/html/rfc2253#section-2.1
+	 *
+	 * @return string
+	 */
+	public function toString(): string
+	{
+		$parts = array_map(
+			function (RDN $rdn) {
+				return $rdn->toString();
+			}, array_reverse($this->_rdns));
+		return implode(',', $parts);
+	}
+
+	/**
+	 * Whether name is semantically equal to other.
+	 *
+	 * Comparison conforms to RFC 4518 string preparation algorithm.
+	 *
+	 * @see https://tools.ietf.org/html/rfc4518
+	 *
+	 * @param Name $other Object to compare to
+	 *
+	 * @return bool
+	 */
+	public function equals(Name $other): bool
+	{
+		// if RDN count doesn't match
+		if (count($this) != count($other)) {
+			return false;
+		}
+		for ($i = count($this) - 1; $i >= 0; --$i) {
+			$rdn1 = $this->_rdns[$i];
+			$rdn2 = $other->_rdns[$i];
+			if (!$rdn1->equals($rdn2)) {
+				return false;
+			}
+		}
+		return true;
+	}
+
+	/**
+	 * Get all RDN objects.
+	 *
+	 * @return RDN[]
+	 */
+	public function all(): array
+	{
+		return $this->_rdns;
+	}
+
+	/**
+	 * Get the first AttributeValue of given type.
+	 *
+	 * Relative name components shall be traversed in encoding order, which is
+	 * reversed in regards to the string representation.
+	 * Multi-valued RDN with multiple attributes of the requested type is
+	 * ambiguous and shall throw an exception.
+	 *
+	 * @param string $name Attribute OID or name
+	 *
+	 * @throws \RuntimeException If attribute cannot be resolved
+	 *
+	 * @return AttributeValue
+	 */
+	public function firstValueOf(string $name): AttributeValue
+	{
+		$oid = AttributeType::attrNameToOID($name);
+		foreach ($this->_rdns as $rdn) {
+			$tvs = $rdn->allOf($oid);
+			if (count($tvs) > 1) {
+				throw new \RangeException("RDN with multiple {$name} attributes.");
+			}
+			if (1 == count($tvs)) {
+				return $tvs[0]->value();
+			}
+		}
+		throw new \RangeException("Attribute {$name} not found.");
+	}
+
+	/**
+	 * @see \Countable::count()
+	 *
+	 * @return int
+	 */
+	public function count(): int
+	{
+		return count($this->_rdns);
+	}
+
+	/**
+	 * Get the number of attributes of given type.
+	 *
+	 * @param string $name Attribute OID or name
+	 *
+	 * @return int
+	 */
+	public function countOfType(string $name): int
+	{
+		$oid = AttributeType::attrNameToOID($name);
+		return array_sum(
+			array_map(
+				function (RDN $rdn) use ($oid) {
+					return count($rdn->allOf($oid));
+				}, $this->_rdns));
+	}
+
+	/**
+	 * @see \IteratorAggregate::getIterator()
+	 *
+	 * @return \ArrayIterator
+	 */
+	public function getIterator(): \ArrayIterator
+	{
+		return new \ArrayIterator($this->_rdns);
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1;
 
@@ -55,7 +55,7 @@ 
     public static function fromASN1(Sequence $seq): self
     {
         $rdns = array_map(
-            function (UnspecifiedType $el) {
+            function(UnspecifiedType $el) {
                 return RDN::fromASN1($el->asSet());
             }, $seq->elements());
         return new self(...$rdns);
@@ -100,7 +100,7 @@ 
     public function toASN1(): Sequence
     {
         $elements = array_map(
-            function (RDN $rdn) {
+            function(RDN $rdn) {
                 return $rdn->toASN1();
             }, $this->_rdns);
         return new Sequence(...$elements);
@@ -116,7 +116,7 @@ 
     public function toString(): string
     {
         $parts = array_map(
-            function (RDN $rdn) {
+            function(RDN $rdn) {
                 return $rdn->toString();
             }, array_reverse($this->_rdns));
         return implode(',', $parts);
@@ -210,7 +210,7 @@ 
         $oid = AttributeType::attrNameToOID($name);
         return array_sum(
             array_map(
-                function (RDN $rdn) use ($oid) {
+                function(RDN $rdn) use ($oid) {
                     return count($rdn->allOf($oid));
                 }, $this->_rdns));
     }

lib/X501/ASN1/AttributeValue/LocalityNameValue.php

Indentation +12 added lines, -12 removed lines

@@ -14,16 +14,16 @@
  */
 class LocalityNameValue extends DirectoryString
 {
-    /**
-     * Constructor.
-     *
-     * @param string $value      String value
-     * @param int    $string_tag Syntax choice
-     */
-    public function __construct(string $value,
-        int $string_tag = DirectoryString::UTF8)
-    {
-        $this->_oid = AttributeType::OID_LOCALITY_NAME;
-        parent::__construct($value, $string_tag);
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param string $value      String value
+	 * @param int    $string_tag Syntax choice
+	 */
+	public function __construct(string $value,
+		int $string_tag = DirectoryString::UTF8)
+	{
+		$this->_oid = AttributeType::OID_LOCALITY_NAME;
+		parent::__construct($value, $string_tag);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1\AttributeValue;
 

lib/X501/ASN1/AttributeValue/NameValue.php

Indentation +12 added lines, -12 removed lines

@@ -14,16 +14,16 @@
  */
 class NameValue extends DirectoryString
 {
-    /**
-     * Constructor.
-     *
-     * @param string $value      String value
-     * @param int    $string_tag Syntax choice
-     */
-    public function __construct(string $value,
-        int $string_tag = DirectoryString::UTF8)
-    {
-        $this->_oid = AttributeType::OID_NAME;
-        parent::__construct($value, $string_tag);
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param string $value      String value
+	 * @param int    $string_tag Syntax choice
+	 */
+	public function __construct(string $value,
+		int $string_tag = DirectoryString::UTF8)
+	{
+		$this->_oid = AttributeType::OID_NAME;
+		parent::__construct($value, $string_tag);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1\AttributeValue;
 

lib/X501/ASN1/AttributeValue/OrganizationNameValue.php

Indentation +12 added lines, -12 removed lines

@@ -14,16 +14,16 @@
  */
 class OrganizationNameValue extends DirectoryString
 {
-    /**
-     * Constructor.
-     *
-     * @param string $value      String value
-     * @param int    $string_tag Syntax choice
-     */
-    public function __construct(string $value,
-        int $string_tag = DirectoryString::UTF8)
-    {
-        $this->_oid = AttributeType::OID_ORGANIZATION_NAME;
-        parent::__construct($value, $string_tag);
-    }
+	/**
+	 * Constructor.
+	 *
+	 * @param string $value      String value
+	 * @param int    $string_tag Syntax choice
+	 */
+	public function __construct(string $value,
+		int $string_tag = DirectoryString::UTF8)
+	{
+		$this->_oid = AttributeType::OID_ORGANIZATION_NAME;
+		parent::__construct($value, $string_tag);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Sop\X501\ASN1\AttributeValue;