Complex classes like Element often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Element, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | abstract class Element implements ElementBase |
||
| 24 | { |
||
| 25 | // Universal type tags |
||
| 26 | const TYPE_EOC = 0x00; |
||
| 27 | const TYPE_BOOLEAN = 0x01; |
||
| 28 | const TYPE_INTEGER = 0x02; |
||
| 29 | const TYPE_BIT_STRING = 0x03; |
||
| 30 | const TYPE_OCTET_STRING = 0x04; |
||
| 31 | const TYPE_NULL = 0x05; |
||
| 32 | const TYPE_OBJECT_IDENTIFIER = 0x06; |
||
| 33 | const TYPE_OBJECT_DESCRIPTOR = 0x07; |
||
| 34 | const TYPE_EXTERNAL = 0x08; |
||
| 35 | const TYPE_REAL = 0x09; |
||
| 36 | const TYPE_ENUMERATED = 0x0a; |
||
| 37 | const TYPE_EMBEDDED_PDV = 0x0b; |
||
| 38 | const TYPE_UTF8_STRING = 0x0c; |
||
| 39 | const TYPE_RELATIVE_OID = 0x0d; |
||
| 40 | const TYPE_SEQUENCE = 0x10; |
||
| 41 | const TYPE_SET = 0x11; |
||
| 42 | const TYPE_NUMERIC_STRING = 0x12; |
||
| 43 | const TYPE_PRINTABLE_STRING = 0x13; |
||
| 44 | const TYPE_T61_STRING = 0x14; |
||
| 45 | const TYPE_VIDEOTEX_STRING = 0x15; |
||
| 46 | const TYPE_IA5_STRING = 0x16; |
||
| 47 | const TYPE_UTC_TIME = 0x17; |
||
| 48 | const TYPE_GENERALIZED_TIME = 0x18; |
||
| 49 | const TYPE_GRAPHIC_STRING = 0x19; |
||
| 50 | const TYPE_VISIBLE_STRING = 0x1a; |
||
| 51 | const TYPE_GENERAL_STRING = 0x1b; |
||
| 52 | const TYPE_UNIVERSAL_STRING = 0x1c; |
||
| 53 | const TYPE_CHARACTER_STRING = 0x1d; |
||
| 54 | const TYPE_BMP_STRING = 0x1e; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Mapping from universal type tag to implementation class name. |
||
| 58 | * |
||
| 59 | * @internal |
||
| 60 | * |
||
| 61 | * @var array |
||
| 62 | */ |
||
| 63 | const MAP_TAG_TO_CLASS = [ /* @formatter:off */ |
||
| 64 | self::TYPE_EOC => Primitive\EOC::class, |
||
| 65 | self::TYPE_BOOLEAN => Primitive\Boolean::class, |
||
| 66 | self::TYPE_INTEGER => Primitive\Integer::class, |
||
| 67 | self::TYPE_BIT_STRING => Primitive\BitString::class, |
||
| 68 | self::TYPE_OCTET_STRING => Primitive\OctetString::class, |
||
| 69 | self::TYPE_NULL => Primitive\NullType::class, |
||
| 70 | self::TYPE_OBJECT_IDENTIFIER => Primitive\ObjectIdentifier::class, |
||
| 71 | self::TYPE_OBJECT_DESCRIPTOR => Primitive\ObjectDescriptor::class, |
||
| 72 | self::TYPE_REAL => Primitive\Real::class, |
||
| 73 | self::TYPE_ENUMERATED => Primitive\Enumerated::class, |
||
| 74 | self::TYPE_UTF8_STRING => Primitive\UTF8String::class, |
||
| 75 | self::TYPE_RELATIVE_OID => Primitive\RelativeOID::class, |
||
| 76 | self::TYPE_SEQUENCE => Constructed\Sequence::class, |
||
| 77 | self::TYPE_SET => Constructed\Set::class, |
||
| 78 | self::TYPE_NUMERIC_STRING => Primitive\NumericString::class, |
||
| 79 | self::TYPE_PRINTABLE_STRING => Primitive\PrintableString::class, |
||
| 80 | self::TYPE_T61_STRING => Primitive\T61String::class, |
||
| 81 | self::TYPE_VIDEOTEX_STRING => Primitive\VideotexString::class, |
||
| 82 | self::TYPE_IA5_STRING => Primitive\IA5String::class, |
||
| 83 | self::TYPE_UTC_TIME => Primitive\UTCTime::class, |
||
| 84 | self::TYPE_GENERALIZED_TIME => Primitive\GeneralizedTime::class, |
||
| 85 | self::TYPE_GRAPHIC_STRING => Primitive\GraphicString::class, |
||
| 86 | self::TYPE_VISIBLE_STRING => Primitive\VisibleString::class, |
||
| 87 | self::TYPE_GENERAL_STRING => Primitive\GeneralString::class, |
||
| 88 | self::TYPE_UNIVERSAL_STRING => Primitive\UniversalString::class, |
||
| 89 | self::TYPE_CHARACTER_STRING => Primitive\CharacterString::class, |
||
| 90 | self::TYPE_BMP_STRING => Primitive\BMPString::class |
||
| 91 | /* @formatter:on */ |
||
| 92 | ]; |
||
| 93 | |||
| 94 | /** |
||
| 95 | * Pseudotype for all string types. |
||
| 96 | * |
||
| 97 | * May be used as an expectation parameter. |
||
| 98 | * |
||
| 99 | * @var int |
||
| 100 | */ |
||
| 101 | const TYPE_STRING = -1; |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Pseudotype for all time types. |
||
| 105 | * |
||
| 106 | * May be used as an expectation parameter. |
||
| 107 | * |
||
| 108 | * @var int |
||
| 109 | */ |
||
| 110 | const TYPE_TIME = -2; |
||
| 111 | |||
| 112 | /** |
||
| 113 | * Mapping from universal type tag to human readable name. |
||
| 114 | * |
||
| 115 | * @internal |
||
| 116 | * |
||
| 117 | * @var array |
||
| 118 | */ |
||
| 119 | const MAP_TYPE_TO_NAME = [ /* @formatter:off */ |
||
| 120 | self::TYPE_EOC => "EOC", |
||
| 121 | self::TYPE_BOOLEAN => "BOOLEAN", |
||
| 122 | self::TYPE_INTEGER => "INTEGER", |
||
| 123 | self::TYPE_BIT_STRING => "BIT STRING", |
||
| 124 | self::TYPE_OCTET_STRING => "OCTET STRING", |
||
| 125 | self::TYPE_NULL => "NULL", |
||
| 126 | self::TYPE_OBJECT_IDENTIFIER => "OBJECT IDENTIFIER", |
||
| 127 | self::TYPE_OBJECT_DESCRIPTOR => "ObjectDescriptor", |
||
| 128 | self::TYPE_EXTERNAL => "EXTERNAL", |
||
| 129 | self::TYPE_REAL => "REAL", |
||
| 130 | self::TYPE_ENUMERATED => "ENUMERATED", |
||
| 131 | self::TYPE_EMBEDDED_PDV => "EMBEDDED PDV", |
||
| 132 | self::TYPE_UTF8_STRING => "UTF8String", |
||
| 133 | self::TYPE_RELATIVE_OID => "RELATIVE-OID", |
||
| 134 | self::TYPE_SEQUENCE => "SEQUENCE", |
||
| 135 | self::TYPE_SET => "SET", |
||
| 136 | self::TYPE_NUMERIC_STRING => "NumericString", |
||
| 137 | self::TYPE_PRINTABLE_STRING => "PrintableString", |
||
| 138 | self::TYPE_T61_STRING => "T61String", |
||
| 139 | self::TYPE_VIDEOTEX_STRING => "VideotexString", |
||
| 140 | self::TYPE_IA5_STRING => "IA5String", |
||
| 141 | self::TYPE_UTC_TIME => "UTCTime", |
||
| 142 | self::TYPE_GENERALIZED_TIME => "GeneralizedTime", |
||
| 143 | self::TYPE_GRAPHIC_STRING => "GraphicString", |
||
| 144 | self::TYPE_VISIBLE_STRING => "VisibleString", |
||
| 145 | self::TYPE_GENERAL_STRING => "GeneralString", |
||
| 146 | self::TYPE_UNIVERSAL_STRING => "UniversalString", |
||
| 147 | self::TYPE_CHARACTER_STRING => "CHARACTER STRING", |
||
| 148 | self::TYPE_BMP_STRING => "BMPString", |
||
| 149 | self::TYPE_STRING => "Any String", |
||
| 150 | self::TYPE_TIME => "Any Time" |
||
| 151 | /* @formatter:on */ |
||
| 152 | ]; |
||
| 153 | |||
| 154 | /** |
||
| 155 | * Element's type tag. |
||
| 156 | * |
||
| 157 | * @var int |
||
| 158 | */ |
||
| 159 | protected $_typeTag; |
||
| 160 | |||
| 161 | /** |
||
| 162 | * Whether type shall be encoded with indefinite length. |
||
| 163 | * |
||
| 164 | * @var bool |
||
| 165 | */ |
||
| 166 | protected $_indefiniteLength = false; |
||
| 167 | |||
| 168 | /** |
||
| 169 | * |
||
| 170 | * @see \ASN1\Feature\ElementBase::typeClass() |
||
| 171 | * @return int |
||
| 172 | */ |
||
| 173 | abstract public function typeClass(): int; |
||
| 174 | |||
| 175 | /** |
||
| 176 | * |
||
| 177 | * @see \ASN1\Feature\ElementBase::isConstructed() |
||
| 178 | * @return bool |
||
| 179 | */ |
||
| 180 | abstract public function isConstructed(): bool; |
||
| 181 | |||
| 182 | /** |
||
| 183 | * Get the content encoded in DER. |
||
| 184 | * |
||
| 185 | * Returns the DER encoded content without identifier and length header |
||
| 186 | * octets. |
||
| 187 | * |
||
| 188 | * @return string |
||
| 189 | */ |
||
| 190 | abstract protected function _encodedContentDER(): string; |
||
| 191 | |||
| 192 | /** |
||
| 193 | * Decode type-specific element from DER. |
||
| 194 | * |
||
| 195 | * @param Identifier $identifier Pre-parsed identifier |
||
| 196 | * @param string $data DER data |
||
| 197 | * @param int $offset Offset in data to the next byte after identifier |
||
| 198 | * @throws DecodeException If decoding fails |
||
| 199 | * @return ElementBase |
||
| 200 | */ |
||
| 201 | 1 | protected static function _decodeFromDER(Identifier $identifier, |
|
| 207 | |||
| 208 | /** |
||
| 209 | * Decode element from DER data. |
||
| 210 | * |
||
| 211 | * @param string $data DER encoded data |
||
| 212 | * @param int|null $offset Reference to the variable that contains offset |
||
| 213 | * into the data where to start parsing. Variable is updated to |
||
| 214 | * the offset next to the parsed element. If null, start from offset |
||
| 215 | * 0. |
||
| 216 | * @throws DecodeException If decoding fails |
||
| 217 | * @throws \UnexpectedValueException If called in the context of an expected |
||
| 218 | * type, but decoding yields another type |
||
| 219 | * @return ElementBase |
||
| 220 | */ |
||
| 221 | 227 | public static function fromDER(string $data, int &$offset = null): ElementBase |
|
| 253 | |||
| 254 | /** |
||
| 255 | * |
||
| 256 | * @see \ASN1\Feature\Encodable::toDER() |
||
| 257 | * @return string |
||
| 258 | */ |
||
| 259 | 130 | public function toDER(): string |
|
| 275 | |||
| 276 | /** |
||
| 277 | * |
||
| 278 | * @see \ASN1\Feature\ElementBase::tag() |
||
| 279 | * @return int |
||
| 280 | */ |
||
| 281 | 109 | public function tag(): int |
|
| 285 | |||
| 286 | /** |
||
| 287 | * |
||
| 288 | * @see \ASN1\Feature\ElementBase::isType() |
||
| 289 | * @return bool |
||
| 290 | */ |
||
| 291 | 27 | public function isType(int $tag): bool |
|
| 303 | |||
| 304 | /** |
||
| 305 | * |
||
| 306 | * @see \ASN1\Feature\ElementBase::expectType() |
||
| 307 | * @return ElementBase |
||
| 308 | */ |
||
| 309 | 16 | public function expectType(int $tag): ElementBase |
|
| 318 | |||
| 319 | /** |
||
| 320 | * Check whether the element is a concrete type of a given tag. |
||
| 321 | * |
||
| 322 | * @param int $tag |
||
| 323 | * @return bool |
||
| 324 | */ |
||
| 325 | 21 | private function _isConcreteType(int $tag): bool |
|
| 340 | |||
| 341 | /** |
||
| 342 | * Check whether the element is a pseudotype. |
||
| 343 | * |
||
| 344 | * @param int $tag |
||
| 345 | * @return bool |
||
| 346 | */ |
||
| 347 | 4 | private function _isPseudoType(int $tag): bool |
|
| 357 | |||
| 358 | /** |
||
| 359 | * |
||
| 360 | * @see \ASN1\Feature\ElementBase::isTagged() |
||
| 361 | * @return bool |
||
| 362 | */ |
||
| 363 | 20 | public function isTagged(): bool |
|
| 367 | |||
| 368 | /** |
||
| 369 | * |
||
| 370 | * @see \ASN1\Feature\ElementBase::expectTagged() |
||
| 371 | * @return TaggedType |
||
| 372 | */ |
||
| 373 | 13 | public function expectTagged($tag = null): TaggedType |
|
| 386 | |||
| 387 | /** |
||
| 388 | * Whether element has indefinite length. |
||
| 389 | * |
||
| 390 | * @return bool |
||
| 391 | */ |
||
| 392 | 1 | public function hasIndefiniteLength(): bool |
|
| 396 | |||
| 397 | /** |
||
| 398 | * Get self with indefinite length encoding set. |
||
| 399 | * |
||
| 400 | * @param bool $indefinite True for indefinite length, false for definite |
||
| 401 | * length |
||
| 402 | * @return self |
||
| 403 | */ |
||
| 404 | 1 | public function withIndefiniteLength(bool $indefinite = true): self |
|
| 410 | |||
| 411 | /** |
||
| 412 | * |
||
| 413 | * @see \ASN1\Feature\ElementBase::asElement() |
||
| 414 | * @return Element |
||
| 415 | */ |
||
| 416 | 49 | final public function asElement(): Element |
|
| 420 | |||
| 421 | /** |
||
| 422 | * Get element decorated with UnspecifiedType object. |
||
| 423 | * |
||
| 424 | * @return UnspecifiedType |
||
| 425 | */ |
||
| 426 | 36 | public function asUnspecified(): UnspecifiedType |
|
| 430 | |||
| 431 | /** |
||
| 432 | * Determine the class that implements the type. |
||
| 433 | * |
||
| 434 | * @param Identifier $identifier |
||
| 435 | * @return string Class name |
||
| 436 | */ |
||
| 437 | 230 | protected static function _determineImplClass(Identifier $identifier): string |
|
| 454 | |||
| 455 | /** |
||
| 456 | * Determine the class that implements an universal type of the given tag. |
||
| 457 | * |
||
| 458 | * @param int $tag |
||
| 459 | * @throws \UnexpectedValueException |
||
| 460 | * @return string Class name |
||
| 461 | */ |
||
| 462 | 223 | protected static function _determineUniversalImplClass(int $tag): string |
|
| 470 | |||
| 471 | /** |
||
| 472 | * Get textual description of the type for debugging purposes. |
||
| 473 | * |
||
| 474 | * @return string |
||
| 475 | */ |
||
| 476 | 6 | protected function _typeDescriptorString(): string |
|
| 484 | |||
| 485 | /** |
||
| 486 | * Get human readable name for an universal tag. |
||
| 487 | * |
||
| 488 | * @param int $tag |
||
| 489 | * @return string |
||
| 490 | */ |
||
| 491 | 48 | public static function tagToName(int $tag): string |
|
| 498 | } |
||
| 499 |