sonrac / laravel-wamp

src/Routers/RouterTrait.php

<?php
/**
 * Created by PhpStorm.
 *
 * @author Donii Sergii <doniysa@gmail.com>
 * Date: 10/25/17
 * Time: 11:57 AM
 */

namespace sonrac\WAMP\Routers;

use Thruway\Peer\RouterInterface;

/**
 * Trait RouterTrait.
 * Base router trait.
 */
trait RouterTrait
{
    /**
     * Controllers list
     *
     * @var \sonrac\WAMP\Abstracts\WAMPControllerInterface[]
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    protected $controllers;

    /**
     * Main router
     *
     * @var null|\Thruway\Peer\RouterInterface|\sonrac\WAMP\Routers\Router
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    protected $router = null;

    /**
     * Route path prefix.
     *
     * @var string|null
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    private $prefix = null;

    /**
     * Controller namespace.
     *
     * @var string|null
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    private $groupControllerNamespace = null;

    /**
     * Middleware list.
     *
     * @var null|array
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    private $middleware = null;

    /**
     * Group routes.
     *
     * @param array    $config Group config
     * @param \Closure $runner Closure runner group
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function group(array $config, \Closure $runner)
    {
        $middleware = isset($config['middleware']) ? explode('|', $config['middleware']) : [];
        $namespace = isset($config['namespace']) ? $config['namespace'] : 'App\Controllers\WAMP';

        $this->groups[] = [

The property groups does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'middleware' => $middleware,
            'namespace'  => $namespace,
            'prefix'     => isset($config['prefix']) ? $config['prefix'] : '',
            'callback'   => $runner,
        ];
    }

    /**
     * Get route groups
     *
     * @return null|\sonrac\WAMP\GroupsConfigInterface[]
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function getGroups()
    {
        return $this->groups;
    }

    /**
     * Get router
     *
     * @return mixed|null|\sonrac\WAMP\Contracts\WAMPRouterInterface|\sonrac\WAMP\Routers\Router|\Thruway\Peer\RouterInterface
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function getRouter()
    {
        return $this->router ?? $this->router = app()->wampRouter;

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * Set router.
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function setRouter(RouterInterface $router)
    {
        $this->router = $router;
    }

    /**
     * Get client session.
     *
     * @return \Thruway\ClientSession
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function getClientSession()
    {
        return $this->getRouter()->getClient()->getSession();

The method getClient() does not exist on Thruway\Peer\RouterInterface. It seems like you code against a sub-type of Thruway\Peer\RouterInterface such as sonrac\WAMP\Routers\Router.

The method getClient() does not exist on sonrac\WAMP\Contracts\WAMPRouterInterface. It seems like you code against a sub-type of said class. However, the method does not exist in sonrac\WAMP\Contracts\RPCRouterInterface. Are you sure you never get one of those?

    }

    /**
     * Get client.
     *
     * @return \sonrac\WAMP\Client|\Thruway\Peer\ClientInterface
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function getClient()
    {
        return $this->getRouter()->getClient();
    }

    /**
     * Parse callback function
     *
     * @param string|\Closure $callback  Callback
     * @param null            $namespace Controller namespace

Are you sure the doc-type for parameter $namespace is correct as it would always require null to be passed?

     *
     * @return \Closure
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function parseCallback($callback, $namespace = null)
    {
        if ($callback instanceof \Closure) {
            return $callback;
        }

        $namespace = $namespace ? $namespace.'\\' : '';

$namespace is of type null, thus it always evaluated to false.

        $callback = explode('@', $callback);

        return function () use ($callback, $namespace) {
            if (count($callback) === 1) {
                return app()->call([$this, $callback[0]], func_get_args());

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

            }

            if (isset($this->controllers[$callback[0]])) {
                return call_user_func_array([$this->controllers[$callback[0]], $callback[1]], func_get_args());
            }

            $namespace = rtrim($namespace, '\\');

            $className = class_exists($callback[0]) ? $callback[0] : $namespace.'\\'.$callback[0];

            $this->controllers[$callback[0]] = app()->make($className);

            return app()->call([$this->controllers[$callback[0]], $callback[1]], func_get_args());
        };
    }

    /**
     * get controller namespace for group
     *
     * @return null|string
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function getGroupControllerNamespace()
    {
        return $this->groupControllerNamespace;
    }

    /**
     * {@inheritdoc}
     */
    public function parseGroups()
    {
        if (!is_array($this->groups) || !count($this->groups)) {
            return;
        }
        gc_enable();
        $callbacks = [];
        foreach ($this->groups as $group) {
            $this->prefix = $group['prefix'];
            $this->groupControllerNamespace = $group['namespace'];
            $this->middleware = $group['middleware'];
            $callbacks[] = $group['callback']($this->getClientSession(), $this->getClient());
        }

        $this->groups = null;

The property groups does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        unset($this->groups);
        $this->groups = [];

        $this->prefix = null;
        $this->groupControllerNamespace = null;

        gc_collect_cycles();
        gc_disable();

        return $callbacks;
    }

    /**
     * Prepare path.
     *
     * @param \Closure|string $callback Callback
     *
     * @return array
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    protected function prepareCallback($callback)
    {
        $namespace = $this->groupControllerNamespace ?? $this->getRouter()->getGroupControllerNamespace();

The method getGroupControllerNamespace() does not exist on Thruway\Peer\RouterInterface. It seems like you code against a sub-type of Thruway\Peer\RouterInterface such as sonrac\WAMP\Routers\Router.

The method getGroupControllerNamespace() does not exist on sonrac\WAMP\Contracts\WAMPRouterInterface. It seems like you code against a sub-type of said class. However, the method does not exist in sonrac\WAMP\Contracts\RPCRouterInterface. Are you sure you never get one of those?

        $namespace = $namespace ?? $this->getRouter()->getControllerNamespace();

The method getControllerNamespace() does not exist on Thruway\Peer\RouterInterface. It seems like you code against a sub-type of Thruway\Peer\RouterInterface such as sonrac\WAMP\Routers\Router.

The method getControllerNamespace() does not exist on sonrac\WAMP\Contracts\WAMPRouterInterface. It seems like you code against a sub-type of sonrac\WAMP\Contracts\WAMPRouterInterface such as sonrac\WAMP\Routers\Router.

        return [
            'prefix'     => $this->prefix,
            'namespace'  => $namespace,
            'callback'   => $this->parseCallback($callback, $namespace),

It seems like $namespace can also be of type string; however, parameter $namespace of sonrac\WAMP\Routers\RouterTrait::parseCallback() does only seem to accept null, maybe add an additional type check?

            'middleware' => $this->middleware,
        ];
    }
}