sonrac\WAMP\Commands\RegisterRoutes

Complexity

Total Complexity

16

Size/Duplication

Total Lines	126
Duplicated Lines	12.7 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	getTransportProvider()	15	15	5
C	fire()	0	36	7
A	handle()	0	3	1
A	getTransportURI()	0	3	2
A	parseOptions()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: Donii Sergii <doniysa@gmail.com>
 * Date: 11/3/17
 * Time: 5:58 PM
 */

namespace sonrac\WAMP\Commands;

use Illuminate\Console\Command;
use sonrac\WAMP\Exceptions\InvalidWampTransportProvider;

/**
 * @class  RegisterRoutes
 * <summary>
 *
 * @author Donii Sergii <doniysa@gmail.com>
 */
class RegisterRoutes extends Command
{
    use WAMPCommandTrait;

    /**
     * {@inheritdoc}
     */
    protected $name = 'wamp:register-routes {--realm=?} {--host=?} {--port=?} {--tls?} {--transport-provider=?}
                {--no-loop?} {--debug?} {--route=path=?}';

    /**
     * {@inheritdoc}
     */
    protected $description = 'Register wamp routes';

    /**
     * {@inheritdoc}
     */
    protected $signature = 'wamp:register-routes
                                {--realm= : Specify WAMP realm to be used}
                                {--host= : Specify the router host}
                                {--port= : Specify the router port}
                                {--path= : Specify the router path component}
                                {--no-debug : Disable debug mode.}
                                {--no-loop : Disable loop runner}
                                {--route-path=? : Path to routes config}
                                {--tls : Specify the router protocol as wss}
                                {--in-background : Run client in background}
                                {--transport-provider=? : Transport provider class}';

    /**
     * Register wamp routes
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function fire()
    {
        $this->changeWampLogger();
        $this->parseOptions();

        if (!$this->runInBackground) {
            $client = app()->wampClient;

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

            $client->addTransportProvider($this->getTransportProvider());
            $client->setRoutePath($this->routePath);
            $client->start();
        } else {
            $command = ' --port=' . $this->port .
                ' --host=' . $this->host .
                ' --realm=' . $this->realm;

            if ($this->transportProvider) {
                $command .= ' --transport-provider=' . $this->transportProvider;

Are you sure $this->transportProvider of type string|Thruway\Transport\RatchetTransportProvider can be used in concatenation?

            }

            if ($this->noDebug) {
                $command .= ' --no-debug';
            }

            if ($this->tls) {
                $command .= ' --tls';
            }

            if ($this->routePath) {
                $command .= ' --route-path=' . $this->routePath;
            }

            if ($this->noLoop) {
                $command .= ' --no-loop';
            }
            $this->addPidToLog(RunCommandInBackground::factory($command)->runInBackground(), 'clients.pids');
        }
    }

    /**
     * Register wamp routes
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    public function handle()
    {
        return $this->fire();

Are you sure the usage of $this->fire() targeting sonrac\WAMP\Commands\RegisterRoutes::fire() seems to always return null.

    }

    /**
     * {@inheritdoc}
     */
    protected function parseOptions()
    {
        $this->parseBaseOptions();
    }

    /**
     * Get WAMP client transport provider
     *
     * @return null|string|\Thruway\Transport\ClientTransportProviderInterface
     *
     * @throws \sonrac\WAMP\Exceptions\InvalidWampTransportProvider
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    protected function getTransportProvider()

This method seems to be duplicated in your project.

    {
        if (is_object($this->transportProvider)) {
            return $this->transportProvider;

The expression return $this->transportProvider returns the type Thruway\Transport\RatchetTransportProvider which is incompatible with the documented return type null|string|Thruway\Transport\ClientTransportProviderInterface.

        }

        if (is_null($this->transportProvider) || empty($this->transportProvider)) {
            $this->transportProvider = '\Thruway\Transport\PawlTransportProvider';
        }

        if (is_string($this->transportProvider)) {
            return $this->transportProvider = new $this->transportProvider($this->getTransportURI());
        }

        throw new InvalidWampTransportProvider();
    }

    /**
     * Get transport url
     *
     * @author Donii Sergii <doniysa@gmail.com>
     */
    protected function getTransportURI()
    {
        return ($this->tls ? 'wss://' : 'ws://') . $this->host . ':' . $this->port;
    }
}