RunServer::getLogger() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - sonrac/laravel-wamp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4dc059...6205c3 )

by Sergii

created 2018-01-03 15:36 UTC

RunServer::getLogger() A

↳ Parent: RunServer

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 *
 * @author Donii Sergii <[email protected]>
 * Date: 10/24/17
 * Time: 10:33 AM
 */

namespace sonrac\WAMP\Commands;

use Illuminate\Console\Command;
use sonrac\WAMP\Exceptions\InvalidWampTransportProvider;

/**
 * Class RunServer
 * Run WAMP server command.
 */
class RunServer extends Command
{
    use WAMPCommandTrait;
    /**
     * WAMP router host.
     *
     * @var string
     */
    protected $host = '127.0.0.1';

    /**
     * {@inheritdoc}
     */
    protected $name = 'wamp:run-server {--realm=?} {--host=?} {--port=?} {--tls?} {--transport-provider=?}
    {--no-loop?} {--no-debug?} {--in-background?} {--client-transport-provider=?} {--route-path=?}';

    /**
     * {@inheritdoc}
     */
    protected $signature = 'wamp:run-server
                                {--realm= : Specify WAMP realm to be used}
                                {--host= : Specify the router host}
                                {--port= : Specify the router port}
                                {--tls : Specify the router protocol as wss}
                                {--no-debug : Disable debug mode.}
                                {--no-loop : Disable loop runner}
                                {--transport-provider : Transport provider class}
                                {--route-path= : Path to routes config}
                                {--client-transport-provider= : Client transport provider class}
                                {--in-background : Run task in background}
                                ';

    /**
     * {@inheritdoc}
     */
    protected $description = 'Run wamp server';

    /**
     * Wamp server.
     *
     * @var \Thruway\Peer\ClientInterface|\sonrac\WAMP\Client
     */
    protected $WAMPServer = null;

    /**
     * Client transport provider class.
     *
     * @var null|string
     *
     * @author Donii Sergii <[email protected]>
     */
    protected $clientTransportProvider = null;

    /**
     * Run server handle.
     *
     * @throws \Exception
     */
    public function handle()
    {
        $this->parseOptions();
        $this->changeWampLogger();

        if (!$this->runInBackground) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->WAMPServer = app()->wampRouter;
            $transportProvider = $this->getTransportProvider();
            $this->WAMPServer->registerModule($transportProvider);
            $this->WAMPServer->start(!$this->runOnce);
        } else {
            $serverCommand = ' '.$this->getName().$this->getCommandLineOptions();

            if ($this->clientTransportProvider) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $serverCommand .= ' --client-transport-provider='.$this->clientTransportProvider;
            }

            $this->addPidToLog(RunCommandInBackground::factory($serverCommand)->runInBackground(),
                DownWAMP::SERVER_PID_FILE);
        }
    }

    /**
     * Run server handle
     *
     * @throws \Exception
     */
    public function fire()
    {
        return $this->handle();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * Get commandline options for background command
     *
     * @return string
     *
     * @author Donii Sergii <[email protected]>
     */
    protected function getCommandLineOptions()
    {
        $command = ' --port='.$this->port.
            ' --host='.$this->host.
            ' --realm='.$this->realm;

        if ($this->clientTransportProvider) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $command .= ' --transport-provider='.$this->clientTransportProvider;
        }

        if ($this->noDebug) {
            $command .= ' --no-debug';
        }

        if ($this->tls) {
            $command .= ' --tls';
        }

        if ($this->routePath) {
            $command .= ' --route-path='.$this->routePath;
        }

        if ($this->noLoop) {
            $command .= ' --no-loop';
        }

        return $command;
    }

    /**
     * Merge config & input options.
     */
    protected function parseOptions()
    {
        $this->clientTransportProvider = $this->getOptionFromInput('client-transport-provider');
        $this->parseBaseOptions();
    }

    /**
     * Get WAMP server transport provider.
     *
     * @return null|string|\Thruway\Transport\RatchetTransportProvider
     *
     * @throws \sonrac\WAMP\Exceptions\InvalidWampTransportProvider
     *
     * @author Donii Sergii <[email protected]>
     */
    protected function getTransportProvider()
    {
        if (is_object($this->transportProvider)) {
            return $this->transportProvider;
        }

        if (is_null($this->transportProvider) || empty($this->transportProvider)) {
            $this->transportProvider = 'Thruway\Transport\RatchetTransportProvider';
        }

        if (is_string($this->transportProvider)) {
            return $this->transportProvider = new $this->transportProvider($this->host, $this->port);
        }

        throw new InvalidWampTransportProvider();
    }

    /**
     * {@inheritdoc}
     *
     * @author Donii Sergii <[email protected]>
     */
    protected function getLogger()
    {
        return app('wamp.server.logger');
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			*
5			* @author Donii Sergii <[email protected]>
6			* Date: 10/24/17
7			* Time: 10:33 AM
8			*/
9
10			namespace sonrac\WAMP\Commands;
11
12			use Illuminate\Console\Command;
13			use sonrac\WAMP\Exceptions\InvalidWampTransportProvider;
14
15			/**
16			* Class RunServer
17			* Run WAMP server command.
18			*/
19			class RunServer extends Command
20			{
21			use WAMPCommandTrait;
22			/**
23			* WAMP router host.
24			*
25			* @var string
26			*/
27			protected $host = '127.0.0.1';
28
29			/**
30			* {@inheritdoc}
31			*/
32			protected $name = 'wamp:run-server {--realm=?} {--host=?} {--port=?} {--tls?} {--transport-provider=?}
33			{--no-loop?} {--no-debug?} {--in-background?} {--client-transport-provider=?} {--route-path=?}';
34
35			/**
36			* {@inheritdoc}
37			*/
38			protected $signature = 'wamp:run-server
39			{--realm= : Specify WAMP realm to be used}
40			{--host= : Specify the router host}
41			{--port= : Specify the router port}
42			{--tls : Specify the router protocol as wss}
43			{--no-debug : Disable debug mode.}
44			{--no-loop : Disable loop runner}
45			{--transport-provider : Transport provider class}
46			{--route-path= : Path to routes config}
47			{--client-transport-provider= : Client transport provider class}
48			{--in-background : Run task in background}
49			';
50
51			/**
52			* {@inheritdoc}
53			*/
54			protected $description = 'Run wamp server';
55
56			/**
57			* Wamp server.
58			*
59			* @var \Thruway\Peer\ClientInterface\|\sonrac\WAMP\Client
60			*/
61			protected $WAMPServer = null;
62
63			/**
64			* Client transport provider class.
65			*
66			* @var null\|string
67			*
68			* @author Donii Sergii <[email protected]>
69			*/
70			protected $clientTransportProvider = null;
71
72			/**
73			* Run server handle.
74			*
75			* @throws \Exception
76			*/
77			public function handle()
78			{
79			$this->parseOptions();
80			$this->changeWampLogger();
81
82			if (!$this->runInBackground) {
			0 ignored issues – show Bug Best Practice introduced 2018-01-03 15:56 UTC by Report Bug Copy Issue Report The expression `$this->runInBackground` of type `false\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
83			$this->WAMPServer = app()->wampRouter;
84			$transportProvider = $this->getTransportProvider();
85			$this->WAMPServer->registerModule($transportProvider);
86			$this->WAMPServer->start(!$this->runOnce);
87			} else {
88			$serverCommand = ' '.$this->getName().$this->getCommandLineOptions();
89
90			if ($this->clientTransportProvider) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-06 01:10 UTC by Report Bug Copy Issue Report The expression `$this->clientTransportProvider` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
91			$serverCommand .= ' --client-transport-provider='.$this->clientTransportProvider;
92			}
93
94			$this->addPidToLog(RunCommandInBackground::factory($serverCommand)->runInBackground(),
95			DownWAMP::SERVER_PID_FILE);
96			}
97			}
98
99			/**
100			* Run server handle
101			*
102			* @throws \Exception
103			*/
104			public function fire()
105			{
106			return $this->handle();
			0 ignored issues – show Bug introduced 2017-11-06 01:10 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->handle()` targeting `sonrac\WAMP\Commands\RunServer::handle()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
107			}
108
109			/**
110			* Get commandline options for background command
111			*
112			* @return string
113			*
114			* @author Donii Sergii <[email protected]>
115			*/
116			protected function getCommandLineOptions()
117			{
118			$command = ' --port='.$this->port.
119			' --host='.$this->host.
120			' --realm='.$this->realm;
121
122			if ($this->clientTransportProvider) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-06 01:10 UTC by Report Bug Copy Issue Report The expression `$this->clientTransportProvider` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
123			$command .= ' --transport-provider='.$this->clientTransportProvider;
124			}
125
126			if ($this->noDebug) {
127			$command .= ' --no-debug';
128			}
129
130			if ($this->tls) {
131			$command .= ' --tls';
132			}
133
134			if ($this->routePath) {
135			$command .= ' --route-path='.$this->routePath;
136			}
137
138			if ($this->noLoop) {
139			$command .= ' --no-loop';
140			}
141
142			return $command;
143			}
144
145			/**
146			* Merge config & input options.
147			*/
148			protected function parseOptions()
149			{
150			$this->clientTransportProvider = $this->getOptionFromInput('client-transport-provider');
151			$this->parseBaseOptions();
152			}
153
154			/**
155			* Get WAMP server transport provider.
156			*
157			* @return null\|string\|\Thruway\Transport\RatchetTransportProvider
158			*
159			* @throws \sonrac\WAMP\Exceptions\InvalidWampTransportProvider
160			*
161			* @author Donii Sergii <[email protected]>
162			*/
163			protected function getTransportProvider()
164			{
165			if (is_object($this->transportProvider)) {
166			return $this->transportProvider;
167			}
168
169			if (is_null($this->transportProvider) \|\| empty($this->transportProvider)) {
170			$this->transportProvider = 'Thruway\Transport\RatchetTransportProvider';
171			}
172
173			if (is_string($this->transportProvider)) {
174			return $this->transportProvider = new $this->transportProvider($this->host, $this->port);
175			}
176
177			throw new InvalidWampTransportProvider();
178			}
179
180			/**
181			* {@inheritdoc}
182			*
183			* @author Donii Sergii <[email protected]>
184			*/
185			protected function getLogger()
186			{
187			return app('wamp.server.logger');
188			}
189			}
190

sonrac / laravel-wamp

Push — master ( 4dc059...6205c3 )

RunServer::getLogger() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like