Conditions | 3 |
Total Lines | 73 |
Code Lines | 69 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | import React, { Component } from "react" |
||
62 | renderTeamStats = (team) => { |
||
63 | if (this.state.loading === false && this.state.data) { |
||
64 | const { |
||
65 | extraStats = {} |
||
66 | } = this.state.data |
||
67 | return ( |
||
68 | <article className={"team__stats__detail card"}> |
||
69 | <header className={"card__header"}> |
||
70 | <h4>Overzicht</h4> |
||
71 | </header> |
||
72 | <div className={"card__content team__stats__detail--team_stats"}> |
||
73 | <span className={"team__stats--label"}>Gespeeld</span> |
||
74 | <span className={"team__stats--stat"}> |
||
75 | {extraStats.gamesPlayed} |
||
76 | </span> |
||
77 | <span className={"team__stats--label"}>Gewonnen</span> |
||
78 | <span className={"team__stats--stat"}>{extraStats.gamesWon}</span> |
||
79 | <span className={"team__stats--label"}>Gelijk</span> |
||
80 | <span className={"team__stats--stat"}>{extraStats.gamesEqual}</span> |
||
81 | <span className={"team__stats--label"}>Verloren</span> |
||
82 | <span className={"team__stats--stat"}>{extraStats.gamesLost}</span> |
||
83 | <span className={"team__stats--label"}>Doelpunten</span> |
||
84 | <span className={"team__stats--stat"}> |
||
85 | {extraStats.goalsScored} voor / {extraStats.goalsAgainst} tegen |
||
86 | </span> |
||
87 | <span className={"team__stats--label"}>Cleansheets</span> |
||
88 | <span className={"team__stats--stat"}> |
||
89 | {extraStats.cleanSheets} |
||
90 | </span> |
||
91 | <span className={"team__stats--label"}>Gele kaarten</span> |
||
92 | <span className={"team__stats--stat"}> |
||
93 | {extraStats.yellowCards} |
||
94 | </span> |
||
95 | <span className={"team__stats--label"}>Rode kaarten</span> |
||
96 | <span className={"team__stats--stat"}>{extraStats.redCards}</span> |
||
97 | <span className={"team__stats--label"}> |
||
98 | Wedstrijden niet gescoord |
||
99 | </span> |
||
100 | <span className={"team__stats--stat"}>{extraStats.notScored}</span> |
||
101 | <span className={"team__stats--label"}>Grootste overwinning</span> |
||
102 | <span className={"team__stats--stat"}> |
||
103 | {extraStats.biggestWin.result} tegen{" "} |
||
104 | {extraStats.biggestWin.opponent} |
||
105 | </span> |
||
106 | <span className={"team__stats--label"}>Grootste verlies</span> |
||
107 | <span className={"team__stats--stat"}> |
||
108 | {extraStats.biggestLoss.result} tegen{" "} |
||
109 | {extraStats.biggestLoss.opponent} |
||
110 | </span> |
||
111 | <span className={"team__stats--label"}>Meeste doelpunten</span> |
||
112 | <span className={"team__stats--stat"}> |
||
113 | {extraStats.mostGoals.result} tegen{" "} |
||
114 | {extraStats.mostGoals.opponent} |
||
115 | </span> |
||
116 | <span className={"team__stats--label"}>Topschutters</span> |
||
117 | <span className={"team__stats--stat"}> |
||
118 | {extraStats.topscorers.sort((a, b) => b.value - a.value).map((player, i) => ( |
||
119 | <>{player.firstName} {player.lastName} ({player.value})<br/></> |
||
120 | ))} |
||
121 | </span> |
||
122 | <span className={"team__stats--label"}>Laatste wedstrijden</span> |
||
123 | <span className={"team__stats--stat"}> |
||
124 | {extraStats.gameStreak.map((game, i) => ( |
||
125 | <span |
||
126 | className={`team__stats__streak team__stats__streak--${game.result.toLowerCase()}`} |
||
127 | title={`${translateGameResult(game.result)}`} |
||
128 | > |
||
129 | {game.result.charAt(0) !== "E" ? game.result.charAt(0) : "D"} |
||
130 | </span> |
||
131 | ))} |
||
132 | </span> |
||
133 | </div> |
||
134 | </article> |
||
135 | ) |
||
367 |