TranslatableAdminExtension::__construct() - Code Metrics - Inspection of "Add TranslatableListener constructor parameter to..." - sonata-project/SonataTranslationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#70)

unknown

created 2016-01-11 07:00 UTC

TranslatableAdminExtension::__construct() A

↳ Parent: TranslatableAdminExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	3
nc	1
nop	2

<?php
/*
 * This file is part of the Sonata package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Sonata\TranslationBundle\Admin\Extension\Gedmo;

use Gedmo\Translatable\TranslatableListener;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\TranslationBundle\Admin\Extension\AbstractTranslatableAdminExtension;
use Sonata\TranslationBundle\Checker\TranslatableChecker;

/**
 * @author Nicolas Bastien <[email protected]>
 */
class TranslatableAdminExtension extends AbstractTranslatableAdminExtension
{
    /**
     * @var TranslatableListener
     */
    protected $translatableListener;

    public function __construct(TranslatableChecker $translatableChecker, TranslatableListener $translatableListener) {
        parent::__construct($translatableChecker);
        $this->translatableListener = $translatableListener;
    }

    /**
     * @param AdminInterface $admin
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return TranslatableListener
     */
    protected function getTranslatableListener()
    {
        return $this->translatableListener;
    }

    /**
     * {@inheritdoc}
     */
    public function alterObject(AdminInterface $admin, $object)
    {
        if ($this->getTranslatableChecker()->isTranslatable($object)) {
            $this->getTranslatableListener()->setTranslatableLocale($this->getTranslatableLocale($admin));
            $this->getTranslatableListener()->setTranslationFallback('');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $this->getContainer($admin)->get('doctrine')->getManager()->refresh($object);
            $object->setLocale($this->getTranslatableLocale($admin));
        }
    }
}


1			<?php
2			/*
3			* This file is part of the Sonata package.
4			*
5			* (c) Thomas Rabaix <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10			namespace Sonata\TranslationBundle\Admin\Extension\Gedmo;
11
12			use Gedmo\Translatable\TranslatableListener;
13			use Sonata\AdminBundle\Admin\AdminInterface;
14			use Sonata\TranslationBundle\Admin\Extension\AbstractTranslatableAdminExtension;
15			use Sonata\TranslationBundle\Checker\TranslatableChecker;
16
17			/**
18			* @author Nicolas Bastien <[email protected]>
19			*/
20			class TranslatableAdminExtension extends AbstractTranslatableAdminExtension
21			{
22			/**
23			* @var TranslatableListener
24			*/
25			protected $translatableListener;
26
27			public function __construct(TranslatableChecker $translatableChecker, TranslatableListener $translatableListener) {
28			parent::__construct($translatableChecker);
29			$this->translatableListener = $translatableListener;
30			}
31
32			/**
33			* @param AdminInterface $admin
			0 ignored issues – show Bug introduced 2016-01-11 07:02 UTC by Report Bug Copy Issue Report There is no parameter named `$admin`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
34			*
35			* @return TranslatableListener
36			*/
37			protected function getTranslatableListener()
38			{
39			return $this->translatableListener;
40			}
41
42			/**
43			* {@inheritdoc}
44			*/
45			public function alterObject(AdminInterface $admin, $object)
46			{
47			if ($this->getTranslatableChecker()->isTranslatable($object)) {
48			$this->getTranslatableListener()->setTranslatableLocale($this->getTranslatableLocale($admin));
49			$this->getTranslatableListener()->setTranslationFallback('');
			0 ignored issues – show Documentation introduced 2016-01-04 16:10 UTC by Report Bug Copy Issue Report `''` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50
51			$this->getContainer($admin)->get('doctrine')->getManager()->refresh($object);
52			$object->setLocale($this->getTranslatableLocale($admin));
53			}
54			}
55			}
56

sonata-project / SonataTranslationBundle

Pull Request — master (#70)

TranslatableAdminExtension::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like