Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 35 | class TranslatableCheckerTest extends \PHPUnit_Framework_TestCase |
||
| 36 | { |
||
| 37 | /** |
||
| 38 | * @test TranslatableChecker::isTranslatable |
||
| 39 | */ |
||
| 40 | View Code Duplication | public function testIsTranslatableOnInterface() |
|
| 41 | { |
||
| 42 | $translatableChecker = new TranslatableChecker(); |
||
| 43 | |||
| 44 | $object = new ModelTranslatable(); |
||
| 45 | |||
| 46 | $this->assertFalse($translatableChecker->isTranslatable($object)); |
||
| 47 | |||
| 48 | $translatableChecker->setSupportedInterfaces(array( |
||
| 49 | 'Sonata\TranslationBundle\Model\TranslatableInterface', |
||
| 50 | )); |
||
| 51 | |||
| 52 | $this->assertTrue($translatableChecker->isTranslatable($object)); |
||
| 53 | } |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @test TranslatableChecker::isTranslatable |
||
| 57 | */ |
||
| 58 | View Code Duplication | public function testIsTranslatableOnModel() |
|
| 59 | { |
||
| 60 | $translatableChecker = new TranslatableChecker(); |
||
| 61 | |||
| 62 | $object = new ModelCustomTranslatable(); |
||
| 63 | |||
| 64 | $this->assertFalse($translatableChecker->isTranslatable($object)); |
||
| 65 | |||
| 66 | $translatableChecker->setSupportedModels(array( |
||
| 67 | 'Sonata\TranslationBundle\Tests\Checker\ModelCustomTranslatable', |
||
| 68 | )); |
||
| 69 | |||
| 70 | $this->assertTrue($translatableChecker->isTranslatable($object)); |
||
| 71 | } |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @test TranslatableChecker::isTranslatable |
||
| 75 | */ |
||
| 76 | public function testIsTranslatableOnTrait() |
||
| 84 | } |
||
| 85 |
Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule.