LocaleSwitcherBlockService::configureSettings() - Code Metrics - Inspection of "Adapt title to the content below it (#99)" - sonata-project/SonataTranslationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d17154...1fc820 )

by Sullivan

created 2016-06-04 13:51 UTC

LocaleSwitcherBlockService::configureSettings() A

↳ Parent: LocaleSwitcherBlockService

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	12
rs	9.4285
cc	1
eloc	8
nc	1
nop	1

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\TranslationBundle\Block;

use Sonata\BlockBundle\Block\BaseBlockService;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;

/**
 * @author Nicolas Bastien <[email protected]>
 */
class LocaleSwitcherBlockService extends BaseBlockService
{
    /**
     * @deprecated Will be removed when upgrading to SonataBlockBundle 3
     */
    public function setDefaultSettings(OptionsResolverInterface $resolver)
    {
        $this->configureSettings($resolver);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * {@inheritdoc}
     */
    public function configureSettings(OptionsResolver $resolver)
    {
        $resolver->setDefaults(
            array(
                'admin'                            => null,
                'object'                           => null,
                'template'                         => 'SonataTranslationBundle:Block:block_locale_switcher.html.twig',
                'locale_switcher_route'            => null,
                'locale_switcher_route_parameters' => array(),
            )
        );
    }

    /**
     * {@inheritdoc}
     */
    public function execute(BlockContextInterface $blockContext, Response $response = null)
    {
        return $this->renderPrivateResponse($blockContext->getTemplate(), array(
            'block_context'  => $blockContext,
            'block'          => $blockContext->getBlock(),
        ), $response);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\TranslationBundle\Block;
13
14			use Sonata\BlockBundle\Block\BaseBlockService;
15			use Sonata\BlockBundle\Block\BlockContextInterface;
16			use Symfony\Component\HttpFoundation\Response;
17			use Symfony\Component\OptionsResolver\OptionsResolver;
18			use Symfony\Component\OptionsResolver\OptionsResolverInterface;
19
20			/**
21			* @author Nicolas Bastien <[email protected]>
22			*/
23			class LocaleSwitcherBlockService extends BaseBlockService
24			{
25			/**
26			* @deprecated Will be removed when upgrading to SonataBlockBundle 3
27			*/
28			public function setDefaultSettings(OptionsResolverInterface $resolver)
29			{
30			$this->configureSettings($resolver);
			0 ignored issues – show Documentation introduced 2016-04-16 23:24 UTC by Report Bug Copy Issue Report `$resolver` is of type `object<Symfony\Component...tionsResolverInterface>`, but the function expects a `object<Symfony\Component...solver\OptionsResolver>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function configureSettings(OptionsResolver $resolver)
37			{
38			$resolver->setDefaults(
39			array(
40			'admin' => null,
41			'object' => null,
42			'template' => 'SonataTranslationBundle:Block:block_locale_switcher.html.twig',
43			'locale_switcher_route' => null,
44			'locale_switcher_route_parameters' => array(),
45			)
46			);
47			}
48
49			/**
50			* {@inheritdoc}
51			*/
52			public function execute(BlockContextInterface $blockContext, Response $response = null)
53			{
54			return $this->renderPrivateResponse($blockContext->getTemplate(), array(
55			'block_context' => $blockContext,
56			'block' => $blockContext->getBlock(),
57			), $response);
58			}
59			}
60

sonata-project / SonataTranslationBundle

Push — master ( d17154...1fc820 )

LocaleSwitcherBlockService::configureSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like